Code Optimizations

pom.xml

@@ -4,7 +4,7 @@
 
     <groupId>com.massivecraft</groupId>
     <artifactId>Factions</artifactId>
-    <version>1.6.9.5-2.4.1-RC</version>
+    <version>1.6.9.5-2.3.7-RC</version>
     <packaging>jar</packaging>
 
     <name>SaberFactions</name>
@@ -99,6 +99,12 @@
             <version>1.3</version>
             <scope>compile</scope>
         </dependency>
+        <dependency>
+            <groupId>com.mojang</groupId>
+            <artifactId>brigadier</artifactId>
+            <version>1.0.14</version>
+            <scope>compile</scope>
+        </dependency>
         <dependency>
             <groupId>com.github.stefvanschie.inventoryframework</groupId>
             <artifactId>IF</artifactId>
@@ -132,6 +138,11 @@
                 </exclusion>
             </exclusions>
         </dependency>
+        <dependency>
+            <groupId>org.ocpsoft.prettytime</groupId>
+            <artifactId>prettytime</artifactId>
+            <version>4.0.0.Final</version>
+        </dependency>
         <dependency>
             <groupId>net.milkbowl.vault</groupId>
             <artifactId>VaultAPI</artifactId>
@@ -286,12 +297,8 @@
             <scope>compile</scope>
             <exclusions>
                 <exclusion>
-                    <artifactId>*</artifactId>
+                    <artifactId>gson</artifactId>
-                    <groupId>shaded</groupId>
+                    <groupId>com.google.code.gson</groupId>
-                </exclusion>
-                <exclusion>
-                    <artifactId>*</artifactId>
-                    <groupId>gson</groupId>
                 </exclusion>
             </exclusions>
         </dependency>
@@ -343,6 +350,12 @@
                 </exclusion>
             </exclusions>
         </dependency>
+        <dependency>
+            <groupId>com.google.code.gson</groupId>
+            <artifactId>gson</artifactId>
+            <version>2.8.5</version>
+            <scope>compile</scope>
+        </dependency>
         <dependency>
             <groupId>me.clip</groupId>
             <artifactId>placeholderapi</artifactId>
@@ -385,12 +398,6 @@
             <artifactId>authlib</artifactId>
             <version>1.5.21</version>
             <scope>compile</scope>
-            <exclusions>
-                <exclusion>
-                    <groupId>org.apache.logging.log4j</groupId>
-                    <artifactId>*</artifactId>
-                </exclusion>
-            </exclusions>
         </dependency>
         <dependency>
             <groupId>me.rayzr522</groupId>

src/main/java/com/massivecraft/factions/Conf.java

@@ -268,7 +268,6 @@ public class Conf {
     public static boolean ownedMessageInsideTerritory = true;
     public static boolean ownedMessageByChunk = false;
     public static boolean pistonProtectionThroughDenyBuild = true;
-    public static Set<Material> loggableMaterials = EnumSet.noneOf(Material.class);
     public static Set<Material> territoryProtectedMaterials = EnumSet.noneOf(Material.class);
     public static Set<Material> territoryDenyUsageMaterials = EnumSet.noneOf(Material.class);
     public static Set<Material> territoryProtectedMaterialsWhenOffline = EnumSet.noneOf(Material.class);
@@ -577,7 +576,7 @@ public class Conf {
         safeZoneNerfedCreatureTypes.add(EntityType.ENDERMAN);
         safeZoneNerfedCreatureTypes.add(EntityType.GHAST);
         safeZoneNerfedCreatureTypes.add(EntityType.MAGMA_CUBE);
-        if (!FactionsPlugin.getInstance().mc116) safeZoneNerfedCreatureTypes.add(EntityType.PIG_ZOMBIE);
+        safeZoneNerfedCreatureTypes.add(EntityType.PIG_ZOMBIE);
         safeZoneNerfedCreatureTypes.add(EntityType.SILVERFISH);
         safeZoneNerfedCreatureTypes.add(EntityType.SKELETON);
         safeZoneNerfedCreatureTypes.add(EntityType.SPIDER);

src/main/java/com/massivecraft/factions/FactionsPlugin.java

@@ -81,7 +81,6 @@ public class FactionsPlugin extends MPlugin {
     public boolean mc113 = false;
     public boolean mc114 = false;
     public boolean mc115 = false;
-    public boolean mc116 = false;
     public boolean useNonPacketParticles = false;
     public List<String> itemList = getConfig().getStringList("fchest.Items-Not-Allowed");
     SkriptAddon skriptAddon;
@@ -168,16 +167,14 @@ public class FactionsPlugin extends MPlugin {
                 FactionsPlugin.instance.log("Minecraft Version 1.15 found.");
                 mc115 = true;
                 break;
-            case 16:
+            default:
-                FactionsPlugin.instance.log("Minecraft Version 1.16 found.");
+                throw new IllegalStateException("Unexpected value: " + version);
-                mc116 = true;
-                break;
         }
         migrateFPlayerLeaders();
         log("==== End Setup ====");
 
         int pluginId = 7013;
-        Metrics metrics = new Metrics(this, pluginId);
+        new Metrics(this, pluginId);
 
         if (!preEnable()) {
             this.loadSuccessful = false;
@@ -185,7 +182,6 @@ public class FactionsPlugin extends MPlugin {
         }
 
         saveDefaultConfig();
-        this.reloadConfig();
         //Start wait task executor
         WaitExecutor.startTask();
         // Load Conf from disk
@@ -400,14 +396,12 @@ public class FactionsPlugin extends MPlugin {
         return this.mvdwPlaceholderAPIManager;
     }
 
-    private boolean setupPermissions() {
+    private void setupPermissions() {
         try {
             RegisteredServiceProvider<Permission> rsp = getServer().getServicesManager().getRegistration(Permission.class);
             if (rsp != null) perms = rsp.getProvider();
-        } catch (NoClassDefFoundError ex) {
+        } catch (NoClassDefFoundError ignored) {
-            return false;
         }
-        return perms != null;
     }
 
     private boolean setupPlayervaults() {

src/main/java/com/massivecraft/factions/cmd/CmdAdmin.java

@@ -57,7 +57,7 @@ public class CmdAdmin extends FCommand {
                 return;
             }
 
-            if (fyou.isAlt()) {
+            if(fyou.isAlt()){
                 return;
             }
 
@@ -90,7 +90,7 @@ public class CmdAdmin extends FCommand {
             FactionsPlugin.instance.getFlogManager().log(targetFaction, FLogType.RANK_EDIT, context.fPlayer.getName(), fyou.getName(), ChatColor.RED + "Admin");
 
             // Inform all players
-            if (FactionsPlugin.instance.getConfig().getBoolean("faction-leader-broadcast")) {
+            if(FactionsPlugin.instance.getConfig().getBoolean("faction-leader-broadcast")) {
                 for (FPlayer fplayer : FPlayers.getInstance().getOnlinePlayers()) {
                     fplayer.msg(TL.COMMAND_ADMIN_PROMOTED, context.player == null ? TL.GENERIC_SERVERADMIN.toString() : context.fPlayer.describeTo(fplayer, true), fyou.describeTo(fplayer), targetFaction.describeTo(fplayer));
                 }

src/main/java/com/massivecraft/factions/cmd/CmdAnnounce.java

@@ -50,7 +50,7 @@ public class CmdAnnounce extends FCommand {
         return TL.COMMAND_ANNOUNCE_DESCRIPTION;
     }
 
-    protected class AnnounceBrigadier implements BrigadierProvider {
+    protected static class AnnounceBrigadier implements BrigadierProvider {
         @Override
         public ArgumentBuilder<Object, ?> get(ArgumentBuilder<Object, ?> parent) {
             return parent.then(RequiredArgumentBuilder.argument("message", StringArgumentType.greedyString()));

src/main/java/com/massivecraft/factions/cmd/CmdBanner.java

@@ -60,7 +60,6 @@ public class CmdBanner extends FCommand {
     @Deprecated
     public void takeMoney(FPlayer fme, int amt) {
         if (this.hasMoney(fme, amt)) {
-            Economy econ = FactionsPlugin.getInstance().getEcon();
             fme.sendMessage(TL.COMMAND_BANNER_MONEYTAKE.toString().replace("{amount}", amt + ""));
         }
     }

src/main/java/com/massivecraft/factions/cmd/CmdBoom.java

@@ -14,7 +14,6 @@ public class CmdBoom extends FCommand {
         super();
         this.aliases.addAll(Aliases.boom);
 
-        //this.requiredArgs.add("");
         this.optionalArgs.put("on/off", "flip");
 
         this.requirements = new CommandRequirements.Builder(Permission.NO_BOOM)

src/main/java/com/massivecraft/factions/cmd/CmdBypass.java

@@ -14,7 +14,6 @@ public class CmdBypass extends FCommand {
         super();
         this.aliases.addAll(Aliases.bypass);
 
-        //this.requiredArgs.add("");
         this.optionalArgs.put("on/off", "flip");
 
         this.requirements = new CommandRequirements.Builder(Permission.BYPASS)

src/main/java/com/massivecraft/factions/cmd/CmdChat.java

@@ -18,7 +18,6 @@ public class CmdChat extends FCommand {
         super();
         this.aliases.addAll(Aliases.chat);
 
-        //this.requiredArgs.add("");
         this.optionalArgs.put("mode", "next");
 
         this.requirements = new CommandRequirements.Builder(Permission.CHAT)
@@ -86,7 +85,7 @@ public class CmdChat extends FCommand {
         return TL.COMMAND_CHAT_DESCRIPTION;
     }
 
-    protected class ChatBrigadier implements BrigadierProvider {
+    protected static class ChatBrigadier implements BrigadierProvider {
         @Override
         public ArgumentBuilder<Object, ?> get(ArgumentBuilder<Object, ?> parent) {
             return parent.then(LiteralArgumentBuilder.literal("public"))

src/main/java/com/massivecraft/factions/cmd/CmdCheckpoint.java

@@ -2,10 +2,7 @@ package com.massivecraft.factions.cmd;
 
 import com.massivecraft.factions.*;
 import com.massivecraft.factions.struct.Permission;
-import com.massivecraft.factions.struct.Role;
 import com.massivecraft.factions.util.WarmUpUtil;
-import com.massivecraft.factions.zcore.fperms.Access;
-import com.massivecraft.factions.zcore.fperms.PermissableAction;
 import com.massivecraft.factions.zcore.util.TL;
 
 public class CmdCheckpoint extends FCommand {
@@ -20,7 +17,10 @@ public class CmdCheckpoint extends FCommand {
 
         this.optionalArgs.put("set", "");
 
-        this.requirements = new CommandRequirements.Builder(Permission.CHECKPOINT).playerOnly().memberOnly().build();
+        this.requirements = new CommandRequirements.Builder(Permission.CHECKPOINT)
+                .playerOnly()
+                .memberOnly()
+                .build();
     }
 
     @Override
@@ -29,39 +29,17 @@ public class CmdCheckpoint extends FCommand {
             context.msg(TL.COMMAND_CHECKPOINT_DISABLED);
             return;
         }
-        if (context.args.size() == 1 && context.args.get(0).equalsIgnoreCase("set")) {
+        if (context.args.size() == 1) {
-            if (context.fPlayer.getRole() == Role.LEADER) {
+            FLocation myLocation = new FLocation(context.player.getLocation());
-                FLocation myLocation = new FLocation(context.player.getLocation());
+            Faction myLocFaction = Board.getInstance().getFactionAt(myLocation);
-                Faction myLocFaction = Board.getInstance().getFactionAt(myLocation);
+            if (myLocFaction == Factions.getInstance().getWilderness() || myLocFaction == context.faction) {
-                if (myLocFaction == Factions.getInstance().getWilderness() || myLocFaction == context.faction) {
+                context.faction.setCheckpoint(context.player.getLocation());
-                    context.faction.setCheckpoint(context.player.getLocation());
+                context.msg(TL.COMMAND_CHECKPOINT_SET);
-                    context.msg(TL.COMMAND_CHECKPOINT_SET);
-                    return;
-                }
             } else {
                 context.msg(TL.COMMAND_CHECKPOINT_INVALIDLOCATION);
-                return;
-            }
-
-            PermissableAction action = PermissableAction.SETWARP;
-            Access access = context.faction.getAccess(context.fPlayer, action);
-            if (access == Access.DENY) {
-                context.msg(TL.GENERIC_FPERM_NOPERMISSION, action.getName());
-                return;
-            } else {
-                FLocation myLocation = new FLocation(context.player.getLocation());
-                Faction myLocFaction = Board.getInstance().getFactionAt(myLocation);
-                if (myLocFaction == Factions.getInstance().getWilderness() || myLocFaction == context.faction) {
-                    context.faction.setCheckpoint(context.player.getLocation());
-                    context.msg(TL.COMMAND_CHECKPOINT_SET);
-                    return;
-                } else {
-                    context.msg(TL.COMMAND_CHECKPOINT_INVALIDLOCATION);
-                    return;
-                }
             }
+            return;
         }
-
         if (context.faction.getCheckpoint() == null) {
             context.msg(TL.COMMAND_CHECKPOINT_NOT_SET);
             return;
@@ -78,6 +56,8 @@ public class CmdCheckpoint extends FCommand {
         } else {
             context.msg(TL.COMMAND_CHECKPOINT_CLAIMED);
         }
+
+
     }
 
     @Override

src/main/java/com/massivecraft/factions/cmd/CmdColeader.java

@@ -55,7 +55,7 @@ public class CmdColeader extends FCommand {
             return;
         }
 
-        if (you.isAlt()) {
+        if(you.isAlt()){
             return;
         }
 

src/main/java/com/massivecraft/factions/cmd/CmdCreate.java

@@ -54,7 +54,7 @@ public class CmdCreate extends FCommand {
             return;
         }
 
-        if (Cooldown.isOnCooldown(context.fPlayer.getPlayer(), "createCooldown") && !context.fPlayer.isAdminBypassing()) {
+        if(Cooldown.isOnCooldown(context.fPlayer.getPlayer(), "createCooldown") && !context.fPlayer.isAdminBypassing()){
             context.msg(TL.COMMAND_COOLDOWN);
             return;
         }
@@ -66,7 +66,7 @@ public class CmdCreate extends FCommand {
         }
 
         ArrayList<String> tagValidationErrors = MiscUtil.validateTag(tag);
-        if (tagValidationErrors.size() > 0) {
+        if (tagValidationErrors.isEmpty()) {
             context.sendMessage(tagValidationErrors);
             return;
         }

src/main/java/com/massivecraft/factions/cmd/CmdDeinvite.java

@@ -3,7 +3,10 @@ package com.massivecraft.factions.cmd;
 import com.massivecraft.factions.Conf;
 import com.massivecraft.factions.FPlayer;
 import com.massivecraft.factions.FPlayers;
+import com.massivecraft.factions.FactionsPlugin;
 import com.massivecraft.factions.struct.Permission;
+import com.massivecraft.factions.struct.Role;
+import com.massivecraft.factions.zcore.fperms.Access;
 import com.massivecraft.factions.zcore.fperms.PermissableAction;
 import com.massivecraft.factions.zcore.util.TL;
 import mkremins.fanciful.FancyMessage;
@@ -53,7 +56,6 @@ public class CmdDeinvite extends FCommand {
 
         context.faction.msg(TL.COMMAND_DEINVITE_REVOKES, context.fPlayer.describeTo(context.faction), you.describeTo(context.faction));
     }
-
     @Override
     public TL getUsageTranslation() {
         return TL.COMMAND_DEINVITE_DESCRIPTION;

src/main/java/com/massivecraft/factions/cmd/CmdDescription.java

@@ -39,7 +39,7 @@ public class CmdDescription extends FCommand {
 
             // since "&" color tags seem to work even through plain old FPlayer.sendMessage() for some reason, we need to break those up
             // And replace all the % because it messes with string formatting and this is easy way around that.
-            String desc = TextUtil.implode(context.args, " ").replaceAll("%", "").replaceAll("(&([a-f0-9klmnor]))", "& $2");
+            String desc = TextUtil.implode(context.args, " ").replace("%", "").replaceAll("(&([a-f0-9klmnor]))", "& $2");
             context.faction.setDescription(desc);
             Bukkit.getScheduler().scheduleSyncDelayedTask(FactionsPlugin.instance, () -> FactionsPlugin.instance.logFactionEvent(context.faction, FLogType.FDESC_EDIT, context.fPlayer.getName(), desc));
             if (!Conf.broadcastDescriptionChanges) {

src/main/java/com/massivecraft/factions/cmd/CmdDisband.java

@@ -42,8 +42,8 @@ public class CmdDisband extends FCommand {
 
         boolean isMyFaction = context.fPlayer != null && faction == context.faction;
 
-        if (!isMyFaction) {
+        if (!isMyFaction && !Permission.DISBAND_ANY.has(context.sender, true)) {
-            if (!Permission.DISBAND_ANY.has(context.sender, true)) return;
+            return;
         }
 
 
@@ -81,13 +81,9 @@ public class CmdDisband extends FCommand {
             access = true;
         }
 
-        if (!access) {
+        if (!access && Conf.useDisbandGUI && (!context.fPlayer.isAdminBypassing() || !context.player.isOp()) && !disbandMap.containsKey(context.player.getUniqueId().toString())) {
-            if (Conf.useDisbandGUI && (!context.fPlayer.isAdminBypassing() || !context.player.isOp())) {
+            new FDisbandFrame(context.faction).buildGUI(context.fPlayer);
-                if (!disbandMap.containsKey(context.player.getUniqueId().toString())) {
+            return;
-                    new FDisbandFrame(context.faction).buildGUI(context.fPlayer);
-                    return;
-                }
-            }
         }
 
         // check for tnt before disbanding.

src/main/java/com/massivecraft/factions/cmd/CmdFly.java

@@ -19,7 +19,6 @@ import java.util.concurrent.ConcurrentHashMap;
 
 public class CmdFly extends FCommand {
 
-    public static final boolean fly = FactionsPlugin.getInstance().getConfig().getBoolean("enable-faction-flight");
     /**
      * @author FactionsUUID Team
      */
@@ -28,6 +27,8 @@ public class CmdFly extends FCommand {
     public static ConcurrentHashMap<String, Boolean> flyMap = new ConcurrentHashMap<>();
     public static BukkitTask particleTask = null;
 
+    public static final boolean fly = FactionsPlugin.getInstance().getConfig().getBoolean("enable-faction-flight");
+
 
     public CmdFly() {
         super();
@@ -64,25 +65,25 @@ public class CmdFly extends FCommand {
 
         if (toFac != fme.getFaction()) {
             if (!me.hasPermission(Permission.FLY_WILDERNESS.node) && toFac.isWilderness() || !me.hasPermission(Permission.FLY_SAFEZONE.node) && toFac.isSafeZone() || !me.hasPermission(Permission.FLY_WARZONE.node) && toFac.isWarZone()) {
-                if (sendMessage) fme.msg(TL.COMMAND_FLY_NO_ACCESS, toFac.getTag(fme));
+                if(sendMessage) fme.msg(TL.COMMAND_FLY_NO_ACCESS, toFac.getTag(fme));
                 return false;
             }
             Access access = toFac.getAccess(fme, PermissableAction.FLY);
             if ((!(me.hasPermission(Permission.FLY_ENEMY.node) || access == Access.ALLOW)) && toFac.getRelationTo(fme.getFaction()) == Relation.ENEMY) {
-                if (sendMessage) fme.msg(TL.COMMAND_FLY_NO_ACCESS, toFac.getTag(fme));
+                if(sendMessage) fme.msg(TL.COMMAND_FLY_NO_ACCESS, toFac.getTag(fme));
                 return false;
             }
             if (!(me.hasPermission(Permission.FLY_ALLY.node) || access == Access.ALLOW) && toFac.getRelationTo(fme.getFaction()) == Relation.ALLY) {
-                if (sendMessage) fme.msg(TL.COMMAND_FLY_NO_ACCESS, toFac.getTag(fme));
+                if(sendMessage) fme.msg(TL.COMMAND_FLY_NO_ACCESS, toFac.getTag(fme));
                 return false;
             }
             if (!(me.hasPermission(Permission.FLY_TRUCE.node) || access == Access.ALLOW) && toFac.getRelationTo(fme.getFaction()) == Relation.TRUCE) {
-                if (sendMessage) fme.msg(TL.COMMAND_FLY_NO_ACCESS, toFac.getTag(fme));
+                if(sendMessage) fme.msg(TL.COMMAND_FLY_NO_ACCESS, toFac.getTag(fme));
                 return false;
             }
 
             if (!(me.hasPermission(Permission.FLY_NEUTRAL.node) || access == Access.ALLOW) && toFac.getRelationTo(fme.getFaction()) == Relation.NEUTRAL && !toFac.isSystemFaction()) {
-                if (sendMessage) fme.msg(TL.COMMAND_FLY_NO_ACCESS, toFac.getTag(fme));
+                if(sendMessage) fme.msg(TL.COMMAND_FLY_NO_ACCESS, toFac.getTag(fme));
                 return false;
             }
             return me.hasPermission(Permission.FLY_FLY.node) && (access != Access.DENY || toFac.isSystemFaction());

src/main/java/com/massivecraft/factions/cmd/CmdFriendlyFire.java

@@ -11,7 +11,7 @@ import com.massivecraft.factions.zcore.util.TL;
  */
 public class CmdFriendlyFire extends FCommand {
 
-    public CmdFriendlyFire() {
+    public CmdFriendlyFire(){
         super();
         this.aliases.addAll(Aliases.friendlyFire);
 
@@ -23,12 +23,12 @@ public class CmdFriendlyFire extends FCommand {
 
     @Override
     public void perform(CommandContext context) {
-        if (!Conf.friendlyFireFPlayersCommand) {
+        if(!Conf.friendlyFireFPlayersCommand){
             context.msg(TL.GENERIC_DISABLED, "friendly fire");
             return;
         }
 
-        if (context.fPlayer.hasFriendlyFire()) {
+        if(context.fPlayer.hasFriendlyFire()){
             context.fPlayer.setFriendlyFire(false);
             context.msg(TL.COMMAND_FRIENDLY_FIRE_TOGGLE_OFF);
         } else {

src/main/java/com/massivecraft/factions/cmd/CmdHome.java

@@ -88,11 +88,7 @@ public class CmdHome extends FCommand {
         final Location loc = context.player.getLocation().clone();
 
         // if player is not in a safe zone or their own faction territory, only allow teleport if no enemies are nearby
-        if (Conf.homesTeleportAllowedEnemyDistance > 0
+        if (Conf.homesTeleportAllowedEnemyDistance > 0 && !faction.isSafeZone() && (!context.fPlayer.isInOwnTerritory() || !Conf.homesTeleportIgnoreEnemiesIfInOwnTerritory)) {
-                && !faction.isSafeZone()
-                && (!context.fPlayer.isInOwnTerritory()
-                || (context.fPlayer.isInOwnTerritory()
-                && !Conf.homesTeleportIgnoreEnemiesIfInOwnTerritory))) {
 
             World w = loc.getWorld();
             double x = loc.getX();

src/main/java/com/massivecraft/factions/cmd/CmdInventorySee.java

@@ -49,6 +49,7 @@ public class CmdInventorySee extends FCommand {
 
         FPlayer targetInv = context.argAsFPlayer(0);
         if (targetInv == null || !fplayers.contains(targetInv.getPlayer())) {
+            assert targetInv != null;
             context.msg(TL.PLAYER_NOT_FOUND, Objects.requireNonNull(targetInv.getName()));
             return;
         }

src/main/java/com/massivecraft/factions/cmd/CmdInvite.java

@@ -9,6 +9,7 @@ import com.massivecraft.factions.util.CC;
 import com.massivecraft.factions.zcore.fperms.PermissableAction;
 import com.massivecraft.factions.zcore.util.TL;
 import mkremins.fanciful.FancyMessage;
+import org.bukkit.ChatColor;
 
 public class CmdInvite extends FCommand {
 
@@ -60,9 +61,9 @@ public class CmdInvite extends FCommand {
         if (target.isOnline()) {
             // Tooltips, colors, and commands only apply to the string immediately before it.
             FancyMessage message = new FancyMessage(TL.COMMAND_INVITE_INVITEDYOU.toString()
-                    .replace("%1$s", context.fPlayer.describeTo(target, true))
+                        .replace("%1$s", context.fPlayer.describeTo(target, true))
-                    .replace("%2$s", context.faction.getTag())
+                        .replace("%2$s", context.faction.getTag())
-                    .replaceAll("&", "§"))
+                        .replace("&", "§"))
                     .tooltip(TL.COMMAND_INVITE_CLICKTOJOIN.toString())
                     .command("/" + Conf.baseCommandAliases.get(0) + " join " + context.faction.getTag());
             message.send(target.getPlayer());

src/main/java/com/massivecraft/factions/cmd/CmdJoin.java

@@ -1,12 +1,19 @@
 package com.massivecraft.factions.cmd;
 
 import com.massivecraft.factions.*;
+import com.massivecraft.factions.cmd.audit.FLogType;
+import com.massivecraft.factions.discord.Discord;
 import com.massivecraft.factions.event.FPlayerJoinEvent;
 import com.massivecraft.factions.struct.Permission;
+import com.massivecraft.factions.util.CC;
 import com.massivecraft.factions.zcore.frame.fupgrades.UpgradeType;
 import com.massivecraft.factions.zcore.util.TL;
+import net.dv8tion.jda.core.entities.Member;
+import net.dv8tion.jda.core.exceptions.HierarchyException;
 import org.bukkit.Bukkit;
 
+import java.util.Objects;
+
 public class CmdJoin extends FCommand {
 
     public CmdJoin() {

src/main/java/com/massivecraft/factions/cmd/CmdKick.java

@@ -1,9 +1,6 @@
 package com.massivecraft.factions.cmd;
 
-import com.massivecraft.factions.Conf;
+import com.massivecraft.factions.*;
-import com.massivecraft.factions.FPlayer;
-import com.massivecraft.factions.Faction;
-import com.massivecraft.factions.FactionsPlugin;
 import com.massivecraft.factions.cmd.audit.FLogType;
 import com.massivecraft.factions.event.FPlayerLeaveEvent;
 import com.massivecraft.factions.struct.Permission;
@@ -128,7 +125,7 @@ public class CmdKick extends FCommand {
         FactionsPlugin.instance.logFactionEvent(toKickFaction, FLogType.INVITES, context.fPlayer.getName(), CC.Red + "kicked", toKick.getName());
         toKickFaction.deinvite(toKick);
         toKick.resetFactionData();
-        if (!CmdFly.checkBypassPerms(toKick, toKick.getPlayer(), toKickFaction, false)) {
+        if(!CmdFly.checkBypassPerms(toKick, toKick.getPlayer(), toKickFaction, false)){
             CmdFly.disableFlight(toKick);
         }
     }

src/main/java/com/massivecraft/factions/cmd/CmdMod.java

@@ -50,7 +50,7 @@ public class CmdMod extends FCommand {
             return;
         }
 
-        if (you.isAlt()) {
+        if(you.isAlt()){
             return;
         }
 

src/main/java/com/massivecraft/factions/cmd/CmdOpen.java

@@ -39,7 +39,7 @@ public class CmdOpen extends FCommand {
 
             String open = context.faction.getOpen() ? TL.COMMAND_OPEN_OPEN.toString() : TL.COMMAND_OPEN_CLOSED.toString();
 
-            if (Cooldown.isOnCooldown(context.fPlayer.getPlayer(), "openCooldown") && !context.fPlayer.isAdminBypassing()) {
+            if(Cooldown.isOnCooldown(context.fPlayer.getPlayer(), "openCooldown") && !context.fPlayer.isAdminBypassing()){
                 context.msg(TL.COMMAND_COOLDOWN);
                 return;
             }
@@ -51,7 +51,7 @@ public class CmdOpen extends FCommand {
                     Cooldown.setCooldown(fplayer.getPlayer(), "openCooldown", FactionsPlugin.getInstance().getConfig().getInt("fcooldowns.f-open"));
                     continue;
                 }
-                if (FactionsPlugin.getInstance().getConfig().getBoolean("faction-open-broadcast")) return;
+                if(FactionsPlugin.getInstance().getConfig().getBoolean("faction-open-broadcast")) return;
                 fplayer.msg(TL.COMMAND_OPEN_CHANGED, context.faction.getTag(fplayer.getFaction()), open);
             }
         });

src/main/java/com/massivecraft/factions/cmd/CmdRules.java

@@ -66,18 +66,16 @@ public class CmdRules extends FCommand {
                 String message = "";
                 StringBuilder string = new StringBuilder(message);
                 for (int i = 1; i <= context.args.size() - 1; i++) {
-                    string.append(" " + context.args.get(i));
+                    string.append(" ").append(context.args.get(i));
                 }
                 context.faction.addRule(string.toString());
                 context.msg(TL.COMMAND_RULES_ADD_SUCCESS);
             }
 
-            if (context.args.size() == 2) {
+            if (context.args.size() == 2 && context.args.get(0).equalsIgnoreCase("remove")) {
-                if (context.args.get(0).equalsIgnoreCase("remove")) {
                     int index = context.argAsInt(1);
                     context.faction.removeRule(index - 1);
                     context.msg(TL.COMMAND_RULES_REMOVE_SUCCESS);
-                }
             }
 
         }

src/main/java/com/massivecraft/factions/cmd/CmdShow.java

@@ -88,7 +88,7 @@ public class CmdShow extends FCommand {
         Faction finalFaction = faction;
         instance.getServer().getScheduler().runTaskAsynchronously(instance, () -> {
             for (String raw : finalShow) {
-                String parsed = instance.getConfig().getBoolean("relational-show", true) ? TagUtil.parsePlain(finalFaction, context.fPlayer, raw) : TagUtil.parsePlain(finalFaction, raw); // use relations
+                String parsed = TagUtil.parsePlain(finalFaction, context.fPlayer, raw); // use relations
                 if (parsed == null) {
                     continue; // Due to minimal f show.
                 }
@@ -110,7 +110,7 @@ public class CmdShow extends FCommand {
                         parsed = parsed.substring(0, parsed.indexOf("{ig}")) + TL.COMMAND_SHOW_NOHOME.toString();
                     }
                     if (parsed.contains("%")) {
-                        parsed = parsed.replaceAll("%", ""); // Just in case it got in there before we disallowed it.
+                        parsed = parsed.replace("%", ""); // Just in case it got in there before we disallowed it.
                     }
                     parsed = FactionsPlugin.getInstance().txt.parse(parsed);
                     FancyMessage localFancy = instance.txt.parseFancy(parsed);

src/main/java/com/massivecraft/factions/cmd/CmdTag.java

@@ -54,7 +54,7 @@ public class CmdTag extends FCommand {
             return;
         }
 
-        if (Cooldown.isOnCooldown(context.player, "tagCooldown") && !context.fPlayer.isAdminBypassing()) {
+        if(Cooldown.isOnCooldown(context.player, "tagCooldown") && !context.fPlayer.isAdminBypassing()){
             context.msg(TL.COMMAND_COOLDOWN);
             return;
         }
@@ -72,6 +72,7 @@ public class CmdTag extends FCommand {
         }
 
 
+
         String oldtag = context.faction.getTag();
         context.faction.setTag(tag);
 

src/main/java/com/massivecraft/factions/cmd/CmdTpBanner.java

@@ -30,9 +30,7 @@ public class CmdTpBanner extends FCommand {
 
         if (FactionsBlockListener.bannerLocations.containsKey(context.fPlayer.getTag())) {
             context.msg(TL.COMMAND_TPBANNER_SUCCESS);
-            context.doWarmUp(WarmUpUtil.Warmup.BANNER, TL.WARMUPS_NOTIFY_TELEPORT, "Banner", () -> {
+            context.doWarmUp(WarmUpUtil.Warmup.BANNER, TL.WARMUPS_NOTIFY_TELEPORT, "Banner", () -> context.player.teleport(FactionsBlockListener.bannerLocations.get(context.fPlayer.getTag())), FactionsPlugin.getInstance().getConfig().getLong("warmups.f-banner", 0));
-                context.player.teleport(FactionsBlockListener.bannerLocations.get(context.fPlayer.getTag()));
-            }, FactionsPlugin.getInstance().getConfig().getLong("warmups.f-banner", 0));
         } else {
             context.msg(TL.COMMAND_TPBANNER_NOTSET);
         }

src/main/java/com/massivecraft/factions/cmd/CmdUnban.java

@@ -5,6 +5,7 @@ import com.massivecraft.factions.struct.Permission;
 import com.massivecraft.factions.zcore.fperms.Access;
 import com.massivecraft.factions.zcore.fperms.PermissableAction;
 import com.massivecraft.factions.zcore.util.TL;
+import org.bukkit.Material;
 
 public class CmdUnban extends FCommand {
 
@@ -32,12 +33,8 @@ public class CmdUnban extends FCommand {
             return; // the above method sends a message if fails to find someone.
         }
 
-        if (target.getFaction() != context.fPlayer.getFaction()) {
+        if (target.getFaction() != context.fPlayer.getFaction() && target.getFaction().getAccess(context.fPlayer, PermissableAction.BAN) != Access.ALLOW && !context.fPlayer.isAdminBypassing()) {
-            if (target.getFaction().getAccess(context.fPlayer, PermissableAction.BAN) != Access.ALLOW) {
-                if (!context.fPlayer.isAdminBypassing()) {
                     context.fPlayer.msg(TL.COMMAND_UNBAN_TARGET_IN_OTHER_FACTION, target.getName());
-                }
-            }
         }
 
         if (!context.faction.isBanned(target)) {

src/main/java/com/massivecraft/factions/cmd/CommandRequirements.java

@@ -70,13 +70,9 @@ public class CommandRequirements {
                     return false;
                 }
 
-                if (access != Access.ALLOW) {
+                if (access != Access.ALLOW && role != null && !context.fPlayer.getRole().isAtLeast(role)) {
-                    // They have undefined assert their role
+                    if (informIfNot) context.msg(TL.GENERIC_YOUMUSTBE, role.translation);
-                    if (role != null && !context.fPlayer.getRole().isAtLeast(role)) {
+                    return false;
-                        // They do not fullfill the role
-                        if (informIfNot) context.msg(TL.GENERIC_YOUMUSTBE, role.translation);
-                        return false;
-                    }
                 }
                 // They have been explicitly allowed
                 return true;

src/main/java/com/massivecraft/factions/cmd/FCmdRoot.java

@@ -26,7 +26,6 @@ import com.massivecraft.factions.discord.CmdInviteBot;
 import com.massivecraft.factions.discord.CmdSetGuild;
 import com.massivecraft.factions.missions.CmdMissions;
 import com.massivecraft.factions.shop.CmdShop;
-import com.massivecraft.factions.shop.ShopGUIFrame;
 import com.massivecraft.factions.zcore.util.TL;
 import me.lucko.commodore.CommodoreProvider;
 import org.bukkit.Bukkit;
@@ -378,7 +377,6 @@ public class FCmdRoot extends FCommand implements CommandExecutor {
         }
         if (FactionsPlugin.getInstance().getConfig().getBoolean("F-Shop.Enabled", false) && !fShopEnabled) {
             this.addSubCommand(this.cmdShop);
-            new ShopGUIFrame(null).checkShopConfig();
             fShopEnabled = true;
         }
         if (FactionsPlugin.getInstance().getConfig().getBoolean("f-inventory-see.Enabled", false) && !invSeeEnabled) {

src/main/java/com/massivecraft/factions/cmd/alts/CmdAltsList.java

@@ -44,7 +44,7 @@ public class CmdAltsList extends FCommand {
             return;
         }
 
-        if (faction.getAltPlayers().size() == 0) {
+        if (faction.getAltPlayers().isEmpty()) {
             context.msg(TL.COMMAND_ALTS_LIST_NOALTS, faction.getTag());
             return;
         }

src/main/java/com/massivecraft/factions/cmd/audit/FAuditMenu.java

@@ -114,7 +114,7 @@ public class FAuditMenu extends GUIMenu {
                         }
                         lore.add("");
                         lore.add(CC.Gray + "Click to toggle timestamp");
-                        setItem(slot++, (new ClickableItemStack((new ItemBuilder(Material.PAPER)).name(CC.GreenB + "Log #" + page).lore(lore).build())).setClickCallback((e) -> {
+                        setItem(slot++, (new ClickableItemStack((new ItemBuilder(Material.PAPER)).name(CC.GreenB + "Log #" + page).lore(lore).build())).setClickCallback(e -> {
                             e.setCancelled(true);
                             timeStamp = !timeStamp;
                             drawItems();
@@ -122,7 +122,7 @@ public class FAuditMenu extends GUIMenu {
                     }
                 }
             }
-            setItem(getSize() - 1, (new ClickableItemStack((new ItemBuilder(Material.ARROW)).name(CC.Green + "Previous Page").lore("", CC.Gray + "Click to view previous page!").build())).setClickCallback((event) -> {
+            setItem(getSize() - 1, (new ClickableItemStack((new ItemBuilder(Material.ARROW)).name(CC.Green + "Previous Page").lore("", CC.Gray + "Click to view previous page!").build())).setClickCallback(event -> {
                 event.setCancelled(true);
                 Bukkit.getScheduler().scheduleSyncDelayedTask(FactionsPlugin.instance, () -> (new FAuditMenu(player, faction)).open(player));
             }));

src/main/java/com/massivecraft/factions/cmd/audit/FLogManager.java

@@ -25,8 +25,6 @@ public class FLogManager {
     private Map<UUID, LogTimer> logTimers = new ConcurrentHashMap<>();
     private boolean saving = false;
 
-    public FLogManager() {
-    }
 
     public void log(Faction faction, FLogType type, String... arguments) {
         FactionLogs logs = factionLogMap.computeIfAbsent(faction.getId(), (n) -> new FactionLogs());
@@ -90,8 +88,7 @@ public class FLogManager {
         Faction faction = null;
 
         for (Map.Entry<UUID, LogTimer> uuidLogTimerEntry : getLogTimers().entrySet()) {
-            Map.Entry<UUID, LogTimer> timer = uuidLogTimerEntry;
+            LogTimer logTimer = uuidLogTimerEntry.getValue();
-            LogTimer logTimer = timer.getValue();
             if (faction == null) {
                 faction = Factions.getInstance().getFactionById(logTimer.getFactionId());
             }

src/main/java/com/massivecraft/factions/cmd/audit/FactionLogs.java

@@ -65,11 +65,11 @@ public class FactionLogs {
                         }
                     }
                 }
-                if (logs.size() <= 0)
+                if (logs.isEmpty())
                     toRemove.add(logType);
             }
         });
-        toRemove.forEach((rem) -> mostRecentLogs.remove(rem));
+        toRemove.forEach(rem -> mostRecentLogs.remove(rem));
     }
 
     public Map<FLogType, LinkedList<FactionLog>> getMostRecentLogs() {

src/main/java/com/massivecraft/factions/cmd/audit/LogTimer.java

@@ -26,11 +26,11 @@ public class LogTimer extends ConcurrentHashMap<LogTimer.TimerType, Map<LogTimer
     }
 
     public Map<LogTimer.TimerSubType, LogTimer.Timer> getCurrentTimersOrCreate(LogTimer.TimerType type) {
-        return this.computeIfAbsent(type, (m) -> new ConcurrentHashMap<>());
+        return this.computeIfAbsent(type, m -> new ConcurrentHashMap<>());
     }
 
     public LogTimer.Timer attemptLog(LogTimer.TimerType type, LogTimer.TimerSubType subType, long increment) {
-        return this.getCurrentTimersOrCreate(type).computeIfAbsent(subType, (e) -> new Timer(System.currentTimeMillis(), 0L, null)).increment(increment);
+        return this.getCurrentTimersOrCreate(type).computeIfAbsent(subType, e -> new Timer(System.currentTimeMillis(), 0L, null)).increment(increment);
     }
 
     public void pushLogs(Faction faction, LogTimer.TimerType type) {

src/main/java/com/massivecraft/factions/cmd/check/CheckHistoryFrame.java

@@ -13,24 +13,19 @@ import org.bukkit.inventory.Inventory;
 import org.bukkit.inventory.ItemStack;
 import org.bukkit.inventory.meta.ItemMeta;
 import org.bukkit.material.MaterialData;
+import org.jetbrains.annotations.NotNull;
 
 import java.text.SimpleDateFormat;
 import java.util.*;
 
 public class CheckHistoryFrame implements FactionGUI {
 
-    /**
-     * @author Driftay
-     */
-
-    private FactionsPlugin plugin;
     private Faction faction;
     private Inventory inventory;
     private SimpleDateFormat simpleDateFormat;
 
     public CheckHistoryFrame(FactionsPlugin plugin, Faction faction) {
         this.simpleDateFormat = new SimpleDateFormat(Conf.dateFormat);
-        this.plugin = plugin;
         this.faction = faction;
         this.inventory = plugin.getServer().createInventory(this, 54, TL.CHECK_HISTORY_GUI_TITLE.toString());
     }
@@ -88,6 +83,7 @@ public class CheckHistoryFrame implements FactionGUI {
         }
     }
 
+    @NotNull
     public Inventory getInventory() {
         return inventory;
     }

src/main/java/com/massivecraft/factions/cmd/check/CheckSettingsFrame.java

@@ -12,6 +12,7 @@ import org.bukkit.inventory.Inventory;
 import org.bukkit.inventory.InventoryHolder;
 import org.bukkit.inventory.ItemStack;
 import org.bukkit.inventory.meta.ItemMeta;
+import org.jetbrains.annotations.NotNull;
 
 import java.util.Collections;
 
@@ -71,6 +72,7 @@ public class CheckSettingsFrame implements InventoryHolder, FactionGUI {
         inventory.setItem(FactionsPlugin.getInstance().getConfig().getInt("f-check.history.slot"), historyStack);
     }
 
+    @NotNull
     public Inventory getInventory() {
         return this.inventory;
     }
@@ -92,9 +94,6 @@ public class CheckSettingsFrame implements InventoryHolder, FactionGUI {
             case 15: {
                 return 30;
             }
-            case 30: {
-                return 0;
-            }
             default: {
                 return 0;
             }

src/main/java/com/massivecraft/factions/cmd/check/WeeWooTask.java

@@ -11,14 +11,7 @@ import net.dv8tion.jda.core.entities.TextChannel;
 
 public class WeeWooTask implements Runnable {
 
-    /**
-     * @author Driftay
-     */
-
-    private FactionsPlugin plugin;
-
     public WeeWooTask(FactionsPlugin plugin) {
-        this.plugin = plugin;
     }
 
     @Override

src/main/java/com/massivecraft/factions/cmd/chest/AntiChestListener.java

@@ -29,13 +29,11 @@ public class AntiChestListener implements Listener {
         Inventory clicked = e.getClickedInventory();
         Inventory clicker = e.getWhoClicked().getInventory();
 
-        if (e.getClick().isShiftClick()) {
+        if (e.getClick().isShiftClick() && clicked == clicker) {
-            if (clicked == clicker) {
+            ItemStack clickedOn = e.getCurrentItem();
-                ItemStack clickedOn = e.getCurrentItem();
+            if (clickedOn != null && FactionsPlugin.getInstance().itemList.contains(clickedOn.getType().toString())) {
-                if (clickedOn != null && FactionsPlugin.getInstance().itemList.contains(clickedOn.getType().toString())) {
+                fPlayer.msg(TL.CHEST_ITEM_DENIED_TRANSFER, clickedOn.getType().toString());
-                    fPlayer.msg(TL.CHEST_ITEM_DENIED_TRANSFER, clickedOn.getType().toString());
+                e.setCancelled(true);
-                    e.setCancelled(true);
-                }
             }
         }
 

src/main/java/com/massivecraft/factions/cmd/claim/CmdAutoClaim.java

@@ -26,7 +26,6 @@ public class CmdAutoClaim extends FCommand {
         super();
         this.aliases.addAll(Aliases.claim_auto);
 
-        //this.requiredArgs.add("");
         this.optionalArgs.put("faction", "your");
 
         this.requirements = new CommandRequirements.Builder(Permission.AUTOCLAIM)
@@ -39,13 +38,9 @@ public class CmdAutoClaim extends FCommand {
     public void perform(CommandContext context) {
         Faction forFaction = context.argAsFaction(0, context.faction);
 
-        if (forFaction != context.fPlayer.getFaction()) {
+        if (forFaction != context.fPlayer.getFaction() && !context.fPlayer.isAdminBypassing() && forFaction.getAccess(context.fPlayer, PermissableAction.TERRITORY) != Access.ALLOW) {
-            if (!context.fPlayer.isAdminBypassing()) {
+            context.msg(TL.COMMAND_CLAIM_DENIED);
-                if (forFaction.getAccess(context.fPlayer, PermissableAction.TERRITORY) != Access.ALLOW) {
+            return;
-                    context.msg(TL.COMMAND_CLAIM_DENIED);
-                    return;
-                }
-            }
         }
 
         if (forFaction == null || forFaction == context.fPlayer.getAutoClaimFor()) {

src/main/java/com/massivecraft/factions/cmd/claim/CmdClaim.java

@@ -41,13 +41,9 @@ public class CmdClaim extends FCommand {
         int radius = context.argAsInt(0, 1); // Default to 1
         final Faction forFaction = context.argAsFaction(1, context.faction); // Default to own
 
-        if (!context.fPlayer.isAdminBypassing()) {
+        if (!context.fPlayer.isAdminBypassing() && !(context.fPlayer.getFaction().equals(forFaction) && context.fPlayer.getRole() == Role.LEADER) && forFaction.getAccess(context.fPlayer, PermissableAction.TERRITORY) != Access.ALLOW) {
-            if (!(context.fPlayer.getFaction().equals(forFaction) && context.fPlayer.getRole() == Role.LEADER)) {
+            context.msg(TL.COMMAND_CLAIM_DENIED);
-                if (forFaction.getAccess(context.fPlayer, PermissableAction.TERRITORY) != Access.ALLOW) {
+            return;
-                    context.msg(TL.COMMAND_CLAIM_DENIED);
-                    return;
-                }
-            }
         }
 
 
@@ -90,12 +86,11 @@ public class CmdClaim extends FCommand {
                     return true;
                 }
 
+                @Override
                 public void finish() {
-                    if (FactionsPlugin.cachedRadiusClaim) {
+                    if (FactionsPlugin.cachedRadiusClaim && successfulClaims > 0) {
-                        if (successfulClaims > 0) {
+                        context.fPlayer.getFaction().getFPlayersWhereOnline(true).forEach(f -> f.msg(TL.CLAIM_RADIUS_CLAIM, context.fPlayer.describeTo(f, true), String.valueOf(successfulClaims), context.fPlayer.getPlayer().getLocation().getChunk().getX(), context.fPlayer.getPlayer().getLocation().getChunk().getZ()));
-                            context.fPlayer.getFaction().getFPlayersWhereOnline(true).forEach(f -> f.msg(TL.CLAIM_RADIUS_CLAIM, context.fPlayer.describeTo(f, true), String.valueOf(successfulClaims), context.fPlayer.getPlayer().getLocation().getChunk().getX(), context.fPlayer.getPlayer().getLocation().getChunk().getZ()));
+                        stop();
-                            stop();
-                        }
                     }
                 }
             };

src/main/java/com/massivecraft/factions/cmd/claim/CmdClaimLine.java

@@ -68,15 +68,10 @@ public class CmdClaimLine extends FCommand {
         }
 
         final Faction forFaction = context.argAsFaction(2, context.faction);
-        Faction at = Board.getInstance().getFactionAt(new FLocation(context.fPlayer.getPlayer().getLocation()));
 
-        if (forFaction != context.fPlayer.getFaction()) {
+        if (forFaction != context.fPlayer.getFaction() && !context.fPlayer.isAdminBypassing() && forFaction.getAccess(context.fPlayer, PermissableAction.TERRITORY) != Access.ALLOW) {
-            if (!context.fPlayer.isAdminBypassing()) {
-                if (forFaction.getAccess(context.fPlayer, PermissableAction.TERRITORY) != Access.ALLOW) {
                     context.msg(TL.COMMAND_CLAIM_DENIED);
                     return;
-                }
-            }
         }
 
         Location location = context.player.getLocation();
@@ -85,13 +80,11 @@ public class CmdClaimLine extends FCommand {
         int claims = 0;
 
         for (int i = 0; i < amount; i++) {
-            if (FactionsPlugin.cachedRadiusClaim && context.fPlayer.attemptClaim(forFaction, context.player.getLocation(), false)) {
+            if (!FactionsPlugin.cachedRadiusClaim || !context.fPlayer.attemptClaim(forFaction, context.player.getLocation(), false)) {
-                claims++;
-            } else {
                 context.fPlayer.attemptClaim(forFaction, location, true);
-                claims++;
             }
-            location = location.add(blockFace.getModX() * 16, 0, blockFace.getModZ() * 16);
+            claims++;
+            location = location.add(blockFace.getModX() * 16D, 0, blockFace.getModZ() * 16D);
             FactionsPlugin.instance.logFactionEvent(forFaction, FLogType.CHUNK_CLAIMS, context.fPlayer.getName(), CC.GreenB + "CLAIMED", String.valueOf(i), new FLocation(context.player.getLocation()).formatXAndZ(","));
         }
         int cachedClaims = claims;

src/main/java/com/massivecraft/factions/cmd/claim/CmdUnclaim.java

@@ -31,16 +31,13 @@ public class CmdUnclaim extends FCommand {
 
         this.requirements = new CommandRequirements.Builder(Permission.UNCLAIM)
                 .playerOnly()
+                .memberOnly()
                 .withAction(PermissableAction.TERRITORY)
                 .build();
     }
 
     @Override
     public void perform(CommandContext context) {
-        if (!context.fPlayer.isAdminBypassing() && !context.fPlayer.hasFaction()) {
-            context.fPlayer.msg(TL.GENERIC_MEMBERONLY);
-            return;
-        }
 
         if (context.args.size() == 2) {
             Faction target = context.argAsFaction(1);
@@ -66,11 +63,6 @@ public class CmdUnclaim extends FCommand {
             boolean didUnClaim = unClaim(new FLocation(context.player), context);
             if (didUnClaim && !context.fPlayer.canFlyAtLocation())
                 context.fPlayer.setFFlying(false, false);
-
-            for(FPlayer fPlayer : context.faction.getFPlayersWhereOnline(true)){
-                if(!fPlayer.canFlyAtLocation())
-                    fPlayer.setFFlying(false, false);
-            }
         } else {
             // radius claim
             if (!Permission.CLAIM_RADIUS.has(context.sender, false)) {
@@ -91,13 +83,10 @@ public class CmdUnclaim extends FCommand {
                         this.stop();
                         return false;
                     }
+
                     return true;
                 }
             };
-
-            boolean didUnClaim = unClaim(new FLocation(context.player), context);
-            if (didUnClaim && !context.fPlayer.canFlyAtLocation())
-                context.fPlayer.setFFlying(false, false);
         }
     }
 

src/main/java/com/massivecraft/factions/cmd/claim/CmdUnclaimall.java

@@ -57,8 +57,14 @@ public class CmdUnclaimall extends FCommand {
         }
         if (Econ.shouldBeUsed()) {
             double refund = Econ.calculateTotalLandRefund(target.getLandRounded());
-            if (!Econ.modifyMoney(target, refund, TL.COMMAND_UNCLAIMALL_TOUNCLAIM.toString(), TL.COMMAND_UNCLAIMALL_FORUNCLAIM.toString())) {
+            if (Conf.bankEnabled && Conf.bankFactionPaysLandCosts) {
-                return;
+                if (!Econ.modifyMoney(target, refund, TL.COMMAND_UNCLAIMALL_TOUNCLAIM.toString(), TL.COMMAND_UNCLAIMALL_FORUNCLAIM.toString())) {
+                    return;
+                }
+            } else {
+                if (!Econ.modifyMoney(target, refund, TL.COMMAND_UNCLAIMALL_TOUNCLAIM.toString(), TL.COMMAND_UNCLAIMALL_FORUNCLAIM.toString())) {
+                    return;
+                }
             }
         }
 

src/main/java/com/massivecraft/factions/cmd/econ/CmdMoneyWithdraw.java

@@ -8,7 +8,6 @@ import com.massivecraft.factions.cmd.CommandContext;
 import com.massivecraft.factions.cmd.CommandRequirements;
 import com.massivecraft.factions.cmd.FCommand;
 import com.massivecraft.factions.cmd.audit.FLogType;
-import com.massivecraft.factions.iface.EconomyParticipator;
 import com.massivecraft.factions.integration.Econ;
 import com.massivecraft.factions.struct.Permission;
 import com.massivecraft.factions.struct.Role;
@@ -44,23 +43,21 @@ public class CmdMoneyWithdraw extends FCommand {
             return;
         }
 
-        EconomyParticipator faction = context.argAsFaction(1, context.faction);
+        Faction faction = context.argAsFaction(1, context.faction);
         if (faction == null) {
             return;
         }
 
         Access access = context.faction.getAccess(context.fPlayer, PermissableAction.WITHDRAW);
-        if (context.fPlayer.getRole() != Role.LEADER) {
+        if (context.fPlayer.getRole() != Role.LEADER && access == Access.DENY) {
-            if (access == Access.DENY) {
+            context.msg(TL.GENERIC_NOPERMISSION, "withdraw", "withdraw money from the bank");
-                context.msg(TL.GENERIC_NOPERMISSION, "withdraw", "withdraw money from the bank");
+            return;
-                return;
-            }
         }
         boolean success = Econ.transferMoney(context.fPlayer, faction, context.fPlayer, amount);
 
         if (success && Conf.logMoneyTransactions) {
             FactionsPlugin.getInstance().log(ChatColor.stripColor(FactionsPlugin.getInstance().txt.parse(TL.COMMAND_MONEYWITHDRAW_WITHDRAW.toString(), context.fPlayer.getName(), Econ.moneyString(amount), faction.describeTo(null))));
-            FactionsPlugin.instance.logFactionEvent((Faction) faction, FLogType.BANK_EDIT, context.fPlayer.getName(), CC.RedB + "WITHDREW", amount + "");
+            FactionsPlugin.instance.logFactionEvent(faction, FLogType.BANK_EDIT, context.fPlayer.getName(), CC.RedB + "WITHDREW", amount + "");
         }
     }
 

src/main/java/com/massivecraft/factions/cmd/grace/CmdGrace.java

@@ -37,27 +37,25 @@ public class CmdGrace extends FCommand {
             return;
         }
 
-        if (context.args.size() == 1) {
+        if (context.args.size() == 1 && context.sender.hasPermission(String.valueOf(Permission.GRACETOGGLE))) {
-            if (context.sender.hasPermission(String.valueOf(Permission.GRACETOGGLE))) {
+            if (context.argAsString(0).equalsIgnoreCase("on") || context.argAsString(0).equalsIgnoreCase("start")) {
-                if (context.argAsString(0).equalsIgnoreCase("on") || context.argAsString(0).equalsIgnoreCase("start")) {
+                FactionsPlugin.getInstance().getTimerManager().graceTimer.setPaused(false);
-                    FactionsPlugin.getInstance().getTimerManager().graceTimer.setPaused(false);
+                FactionsPlugin.getInstance().getTimerManager().graceTimer.setRemaining(TimeUnit.DAYS.toMillis(Conf.gracePeriodTimeDays), true);
-                    FactionsPlugin.getInstance().getTimerManager().graceTimer.setRemaining(TimeUnit.DAYS.toMillis(Conf.gracePeriodTimeDays), true);
+                if (Conf.broadcastGraceToggles) {
-                    if (Conf.broadcastGraceToggles) {
+                    for (FPlayer follower : FPlayers.getInstance().getOnlinePlayers())
-                        for (FPlayer follower : FPlayers.getInstance().getOnlinePlayers())
+                        follower.msg(TL.COMMAND_GRACE_ENABLED_FORMAT, String.valueOf(TimerManager.getRemaining(FactionsPlugin.getInstance().getTimerManager().graceTimer.getRemaining(), true)));
-                            follower.msg(TL.COMMAND_GRACE_ENABLED_FORMAT, String.valueOf(TimerManager.getRemaining(FactionsPlugin.getInstance().getTimerManager().graceTimer.getRemaining(), true)));
-                    }
-                    return;
                 }
+                return;
+            }
 
-                if (context.argAsString(0).equalsIgnoreCase("off") || context.argAsString(0).equalsIgnoreCase("stop")) {
+            if (context.argAsString(0).equalsIgnoreCase("off") || context.argAsString(0).equalsIgnoreCase("stop")) {
-                    FactionsPlugin.getInstance().getTimerManager().graceTimer.setRemaining(TimeUnit.SECONDS.toMillis(0L), true);
+                FactionsPlugin.getInstance().getTimerManager().graceTimer.setRemaining(TimeUnit.SECONDS.toMillis(0L), true);
-                    FactionsPlugin.getInstance().getTimerManager().graceTimer.setPaused(false);
+                FactionsPlugin.getInstance().getTimerManager().graceTimer.setPaused(false);
-                    if (Conf.broadcastGraceToggles) {
+                if (Conf.broadcastGraceToggles) {
-                        for (FPlayer follower : FPlayers.getInstance().getOnlinePlayers())
+                    for (FPlayer follower : FPlayers.getInstance().getOnlinePlayers())
-                            follower.msg(TL.COMMAND_GRACE_DISABLED_FORMAT);
+                        follower.msg(TL.COMMAND_GRACE_DISABLED_FORMAT);
-                    }
-                    return;
                 }
+                return;
             }
         }
 

src/main/java/com/massivecraft/factions/cmd/logout/LogoutHandler.java

@@ -15,10 +15,8 @@ public class LogoutHandler {
 
     public static Map<String, LogoutHandler> factionDatas = new HashMap<>();
     private Map<UUID, Long> logoutCooldown = new HashMap<>();
-    private String name;
 
     public LogoutHandler(String name) {
-        this.name = name;
         factionDatas.put(name, this);
     }
 

src/main/java/com/massivecraft/factions/cmd/relational/FRelationCommand.java

@@ -112,16 +112,14 @@ public abstract class FRelationCommand extends FCommand {
 
     private boolean hasMaxRelations(Faction us, Faction them, Relation targetRelation) {
         int max = FactionsPlugin.getInstance().getConfig().getInt("max-relations." + targetRelation.toString(), -1);
-        if (FactionsPlugin.getInstance().getConfig().getBoolean("max-relations.enabled", false)) {
+        if (FactionsPlugin.getInstance().getConfig().getBoolean("max-relations.enabled", false) && max != -1) {
-            if (max != -1) {
+            if (us.getRelationCount(targetRelation) >= max) {
-                if (us.getRelationCount(targetRelation) >= max) {
+                us.msg(TL.COMMAND_RELATIONS_EXCEEDS_ME, max, targetRelation.getPluralTranslation());
-                    us.msg(TL.COMMAND_RELATIONS_EXCEEDS_ME, max, targetRelation.getPluralTranslation());
+                return true;
-                    return true;
+            }
-                }
+            if (them.getRelationCount(targetRelation) >= max) {
-                if (them.getRelationCount(targetRelation) >= max) {
+                them.msg(TL.COMMAND_RELATIONS_EXCEEDS_THEY, max, targetRelation.getPluralTranslation());
-                    them.msg(TL.COMMAND_RELATIONS_EXCEEDS_THEY, max, targetRelation.getPluralTranslation());
+                return true;
-                    return true;
-                }
             }
         }
         return false;

src/main/java/com/massivecraft/factions/cmd/roles/FPromoteCommand.java

@@ -74,7 +74,7 @@ public class FPromoteCommand extends FCommand {
             }
         }
 
-        if (target.isAlt()) {
+        if(target.isAlt()){
             return;
         }
 

src/main/java/com/massivecraft/factions/cmd/wild/CmdWild.java

@@ -26,8 +26,8 @@ import java.util.Random;
  * @author DroppingAnvil
  */
 public class CmdWild extends FCommand implements WaitedTask {
-    public static HashMap<Player, String> teleportRange;
+    public static HashMap<Player, String> teleportRange = new HashMap<>();
-    public static HashSet<Player> teleporting;
+    public static HashSet<Player> teleporting = new HashSet<>();
     public static CmdWild instance;
 
     public CmdWild() {
@@ -37,9 +37,7 @@ public class CmdWild extends FCommand implements WaitedTask {
         this.requirements = new CommandRequirements.Builder(Permission.WILD)
                 .playerOnly()
                 .build();
-        teleporting = new HashSet<>();
+      }
-        teleportRange = new HashMap<>();
-    }
 
     @Override
     public void perform(CommandContext context) {

src/main/java/com/massivecraft/factions/discord/CmdSetGuild.java

@@ -60,17 +60,17 @@ public class CmdSetGuild extends FCommand {
 
                 if (guild == null) {
                     context.msg(TL.SET_GUILD_ID_INVALID_ID);
-                } else if (Factions.getInstance().getAllFactions().stream().anyMatch((f) -> guildId.equals(f.getGuildId()))) {
+                } else if (Factions.getInstance().getAllFactions().stream().anyMatch(f -> guildId.equals(f.getGuildId()))) {
                     context.msg(TL.SET_GUILD_ID_GUILD_ALREADY_LINKED);
                 } else {
                     context.msg(TL.SET_GUILD_ID_PMING_OWNER);
                     User user = guild.getOwner().getUser();
                     Guild finalGuild = guild;
                     Guild finalGuild1 = guild;
-                    user.openPrivateChannel().queue((privateChannel) -> privateChannel.sendMessage("Link guild **" + finalGuild1.getName() + "** to faction **" + ChatColor.stripColor(faction.getTag()) + "**?").queue((message) -> {
+                    user.openPrivateChannel().queue(privateChannel -> privateChannel.sendMessage("Link guild **" + finalGuild1.getName() + "** to faction **" + ChatColor.stripColor(faction.getTag()) + "**?").queue(message -> {
                         String checkMark = "✅";
                         message.addReaction(checkMark).queue();
-                        this.eventWaiter.waitForEvent(PrivateMessageReactionAddEvent.class, (event) -> event.getReactionEmote().getName().equals(checkMark) && event.getUser().getId().equals(user.getId()) && event.getMessageId().equals(message.getId()), (event) -> {
+                        this.eventWaiter.waitForEvent(PrivateMessageReactionAddEvent.class, event -> event.getReactionEmote().getName().equals(checkMark) && event.getUser().getId().equals(user.getId()) && event.getMessageId().equals(message.getId()), event -> {
                             faction.setGuildId(context.argAsString(0));
                             context.msg(TL.SET_GUILD_ID_SUCCESS);
                             privateChannel.sendMessage("Successfully linked **" + finalGuild.getName() + " & " + ChatColor.stripColor(faction.getTag()) + "**").queue();
@@ -78,9 +78,7 @@ public class CmdSetGuild extends FCommand {
                             privateChannel.sendMessage(TL.SET_GUILD_ID_TIMED_OUT_DISCORD.toString()).queue();
                             context.msg(TL.SET_GUILD_ID_TIMED_OUT_MINECRAFT);
                         });
-                    }, (t) -> {
+                    }, t -> context.msg(TL.SET_GUILD_ID_UNABLE_TO_MESSAGE_GUILD_OWNER)), t -> context.msg(TL.SET_GUILD_ID_UNABLE_TO_MESSAGE_GUILD_OWNER));
-                        context.msg(TL.SET_GUILD_ID_UNABLE_TO_MESSAGE_GUILD_OWNER);
-                    }), (t) -> context.msg(TL.SET_GUILD_ID_UNABLE_TO_MESSAGE_GUILD_OWNER));
                 }
             } else {
                 faction.setGuildId(null);

src/main/java/com/massivecraft/factions/discord/Discord.java

@@ -31,7 +31,7 @@ public class Discord {
     public static Boolean confUseDiscord;
     public static String botToken;
     public static String mainGuildID;
-    public static Boolean useDiscord;
+    public static boolean useDiscord;
     public static java.awt.Color roleColor;
     public static Guild mainGuild;
     public static Role leader;
@@ -53,13 +53,11 @@ public class Discord {
      * Called to reload variables and if needed start JDA
      */
     public static void setupDiscord() {
-        if (jda == null) {
+        if (jda == null && startBot()) {
-            if (startBot()) {
+            varSetup();
-                varSetup();
+            jda.addEventListener(new FactionChatHandler(plugin));
-                jda.addEventListener(new FactionChatHandler(plugin));
+            jda.addEventListener(new DiscordListener(plugin));
-                jda.addEventListener(new DiscordListener(plugin));
+            return;
-                return;
-            }
         }
         varSetup();
     }
@@ -84,6 +82,7 @@ public class Discord {
             confUseDiscord = Conf.useDiscordSystem;
             botToken = Conf.discordBotToken;
             if (jda != null && Conf.leaderRoles || Conf.factionDiscordTags) {
+                assert jda != null;
                 mainGuild = jda.getGuildById(Conf.mainGuildID);
             } else {
                 mainGuild = null;
@@ -151,12 +150,9 @@ public class Discord {
      * @param s String target Faction tag
      * @return
      */
-    public static Boolean doesFactionRoleExist(String s) {
+    public static boolean doesFactionRoleExist(String s) {
-        StringBuilder sb = new StringBuilder();
+        String sb = Conf.factionRolePrefix + s + Conf.factionRoleSuffix;
-        sb.append(Conf.factionRolePrefix);
+        return getRoleFromName(sb) != null;
-        sb.append(s);
-        sb.append(Conf.factionRoleSuffix);
-        return getRoleFromName(sb.toString()) != null;
     }
 
     public static Role getRoleFromName(String s) {
@@ -189,7 +185,8 @@ public class Discord {
         sb.append(Conf.factionRoleSuffix);
         if (!doesFactionRoleExist(sb.toString())) {
             try {
-                Role newRole = mainGuild.getController().createRole()
+                Role newRole;
+                newRole = mainGuild.getController().createRole()
                         .setName(sb.toString())
                         .setColor(roleColor)
                         .setPermissions(Permission.EMPTY_PERMISSIONS)
@@ -211,11 +208,7 @@ public class Discord {
      * @return Name of would be Role
      */
     public static String getFactionRoleName(String tag) {
-        StringBuilder sb = new StringBuilder();
+        return Conf.factionRolePrefix + tag + Conf.factionRoleSuffix;
-        sb.append(Conf.factionRolePrefix);
-        sb.append(tag);
-        sb.append(Conf.factionRoleSuffix);
-        return sb.toString();
     }
 
     /**
@@ -224,7 +217,7 @@ public class Discord {
      * @param u User
      * @return Boolean
      */
-    public static Boolean isInMainGuild(User u) {
+    public static boolean isInMainGuild(User u) {
         if (mainGuild == null) return false;
         return mainGuild.getMember(u) == null ? Boolean.FALSE : Boolean.TRUE;
     }
@@ -252,10 +245,12 @@ public class Discord {
             if (fp.discordSetup() && isInMainGuild(fp.discordUser())) {
                 try {
                     Member m = mainGuild.getMember(fp.discordUser());
-                    if (Conf.factionDiscordTags) {
+                    boolean discordTags = Conf.factionDiscordTags;
+                    boolean factionRoles = Conf.factionRoles;
+                    if (discordTags) {
                         mainGuild.getController().setNickname(m, Discord.getNicknameString(fp)).queue();
                     }
-                    if (Conf.factionRoles) {
+                    if (factionRoles) {
                         mainGuild.getController().removeSingleRoleFromMember(m, Objects.requireNonNull(getRoleFromName(oldTag))).queue();
                         mainGuild.getController().addSingleRoleToMember(m, Objects.requireNonNull(createFactionRole(f.getTag()))).queue();
                     }

src/main/java/com/massivecraft/factions/discord/DiscordListener.java

@@ -37,7 +37,7 @@ public class DiscordListener extends ListenerAdapter {
         this.decimalFormat = new DecimalFormat("$#,###.##");
         this.plugin = plugin;
         int minute = 3600;
-        plugin.getServer().getScheduler().runTaskTimerAsynchronously(plugin, DiscordListener::saveGuilds, minute * 15, minute * 15);
+        plugin.getServer().getScheduler().runTaskTimerAsynchronously(plugin, DiscordListener::saveGuilds, minute * 15L, minute * 15L);
     }
 
     private static JSONGuilds loadGuilds() {
@@ -64,6 +64,7 @@ public class DiscordListener extends ListenerAdapter {
         }
     }
 
+    @Override
     public void onPrivateMessageReceived(PrivateMessageReceivedEvent e) {
         Integer i;
         if (e.getAuthor().isBot()) return;
@@ -85,6 +86,7 @@ public class DiscordListener extends ListenerAdapter {
         }
     }
 
+    @Override
     public void onGuildMessageReceived(GuildMessageReceivedEvent event) {
         try {
             if (event.getMessage().isWebhookMessage() || event.getAuthor().isBot()) return;

src/main/java/com/massivecraft/factions/discord/DiscordSetupAttempt.java

@@ -109,7 +109,7 @@ public class DiscordSetupAttempt {
         sb.append(inProcessTime);
         //Just a separator for looks
         sb.append(" ");
-        String s = "";
+        String s;
         switch (timeIndex) {
             case 0:
                 s = "MS";
@@ -129,6 +129,8 @@ public class DiscordSetupAttempt {
             case 5:
                 s = "Years";
                 break;
+            default:
+                throw new IllegalStateException("Unexpected value: " + timeIndex);
         }
         sb.append(s);
         sb.append(" ago");

src/main/java/com/massivecraft/factions/discord/FactionChatHandler.java

@@ -35,7 +35,7 @@ public class FactionChatHandler extends ListenerAdapter {
         this.plugin = plugin;
     }
 
-    public static void sendMessage(FactionsPlugin plugin, Faction faction, UUID uuid, String username, String message) {
+    public static void sendMessage(Faction faction, UUID uuid, String username, String message) {
         String factionsChatChannelId = faction.getFactionChatChannelId();
         String messageWithMentions = null;
         if (factionsChatChannelId == null || factionsChatChannelId.isEmpty()) return;

src/main/java/com/massivecraft/factions/integration/Econ.java

@@ -48,9 +48,7 @@ public class Econ {
         }
         econ = rsp.getProvider();
         FactionsPlugin.getInstance().log("Economy integration through Vault plugin successful.");
-        if (!Conf.econEnabled)
+        if (!Conf.econEnabled) FactionsPlugin.getInstance().log("NOTE: Economy is disabled. You can enable it with the command: f config econEnabled true");
-            FactionsPlugin.getInstance().log("NOTE: Economy is disabled. You can enable it with the command: f config econEnabled true");
-        //FactionsPlugin.getInstance().cmdBase.cmdHelp.updateHelp();
     }
 
     public static boolean shouldBeUsed() {
@@ -104,7 +102,6 @@ public class Econ {
         // Factions can be controlled by members that are moderators... or any member if any member can withdraw.
         if (you instanceof Faction && fI == fYou && (Conf.bankMembersCanWithdraw || (i instanceof FPlayer && ((FPlayer) i).getRole().value >= Role.MODERATOR.value)))
             return true;
-        // Otherwise you may not!;,,;
         i.msg(TL.ECON_CANTCONTROLMONEY, i.describeTo(i, true), you.describeTo(i));
         return false;
     }
@@ -238,7 +235,7 @@ public class Econ {
             acc = Bukkit.getOfflinePlayer(UUID.fromString(ep.getAccountId()));
             if (acc.getName() == null) return false;
         } else acc = Bukkit.getOfflinePlayer(ep.getAccountId());
-        String You = ep.describeTo(ep, true);
+        String you = ep.describeTo(ep, true);
 
         if (delta == 0) return true;
         else if (delta > 0) {
@@ -248,12 +245,12 @@ public class Econ {
             if (er.transactionSuccess()) {
                 modifyUniverseMoney(-delta);
                 if (forDoingThis != null && !forDoingThis.isEmpty())
-                    ep.msg(TL.COMMAND_MONEY_GAINED, You, moneyString(delta), forDoingThis);
+                    ep.msg(TL.COMMAND_MONEY_GAINED, you, moneyString(delta), forDoingThis);
                 return true;
             } else {
                 // transfer to account failed
                 if (forDoingThis != null && !forDoingThis.isEmpty())
-                    ep.msg(TL.ECON_DEPOSITFAILED, You, moneyString(delta), forDoingThis);
+                    ep.msg(TL.ECON_DEPOSITFAILED, you, moneyString(delta), forDoingThis);
                 return false;
             }
         } else {
@@ -263,12 +260,12 @@ public class Econ {
                 // There is enough money to pay
                 modifyUniverseMoney(-delta);
                 if (forDoingThis != null && !forDoingThis.isEmpty())
-                    ep.msg(TL.ECON_MONEYLOST, You, moneyString(-delta), forDoingThis);
+                    ep.msg(TL.ECON_MONEYLOST, you, moneyString(-delta), forDoingThis);
                 return true;
             } else {
                 // There was not enough money to pay
                 if (toDoThis != null && !toDoThis.isEmpty())
-                    ep.msg(TL.ECON_CANTAFFORD, You, moneyString(-delta), toDoThis);
+                    ep.msg(TL.ECON_CANTAFFORD, you, moneyString(-delta), toDoThis);
                 return false;
             }
         }

src/main/java/com/massivecraft/factions/integration/Worldguard.java

@@ -159,7 +159,6 @@ public class Worldguard {
                     FactionsPlugin.getInstance().log("We failed to load Vector Classes from WorldGuard! Support will be removed!");
                     FactionsPlugin.getInstance().log("WorldGuard 7.0.0 support is currently in BETA. Please be careful!");
                     regionContainer = null;
-                    return;
                 }
             }
         }

src/main/java/com/massivecraft/factions/integration/dynmap/EngineDynmap.java

@@ -12,8 +12,6 @@ import org.dynmap.DynmapAPI;
 import org.dynmap.markers.*;
 import org.dynmap.utils.TileFlags;
 
-import java.awt.*;
-import java.util.List;
 import java.util.*;
 import java.util.Map.Entry;
 
@@ -28,20 +26,17 @@ public class EngineDynmap {
     // CONSTANTS
     // -------------------------------------------- //
 
-    public final static int BLOCKS_PER_CHUNK = 16;
+    public static final int BLOCKS_PER_CHUNK = 16;
 
-    public final static String DYNMAP_INTEGRATION = "\u00A7dDynmap Integration: \u00A7e";
+    public static final String DYNMAP_INTEGRATION = "\u00A7dDynmap Integration: \u00A7e";
 
-    public final static String FACTIONS = "factions";
+    public static final String FACTIONS = "factions";
-    public final static String FACTIONS_ = FACTIONS + "_";
+    public static final String FACTIONS_ = FACTIONS + "_";
-
+    public static final String FACTIONS_MARKERSET = FACTIONS_ + "markerset";
-    public final static String FACTIONS_MARKERSET = FACTIONS_ + "markerset";
+    public static final String FACTIONS_HOME = FACTIONS_ + "home";
-
+    public static final String FACTIONS_HOME_ = FACTIONS_HOME + "_";
-    public final static String FACTIONS_HOME = FACTIONS_ + "home";
+    public static final String FACTIONS_PLAYERSET = FACTIONS_ + "playerset";
-    public final static String FACTIONS_HOME_ = FACTIONS_HOME + "_";
+    public static final String FACTIONS_PLAYERSET_ = FACTIONS_PLAYERSET + "_";
-
-    public final static String FACTIONS_PLAYERSET = FACTIONS_ + "playerset";
-    public final static String FACTIONS_PLAYERSET_ = FACTIONS_PLAYERSET + "_";
 
     // -------------------------------------------- //
     // INSTANCE & CONSTRUCT
@@ -52,8 +47,6 @@ public class EngineDynmap {
     public MarkerAPI markerApi;
     public MarkerSet markerset;
 
-    List<List<Point>> polyLine = new ArrayList<List<Point>>();
-
     private EngineDynmap() {
     }
 
@@ -84,7 +77,9 @@ public class EngineDynmap {
         for (int i = 0; i < string.length(); i++) {
             char c = string.charAt(i);
             if (c > 127 || c == '"' || c == '<' || c == '>' || c == '&') {
-                out.append("&#").append((int) c).append(';');
+                out.append("&#")
+                        .append((int) c)
+                        .append(';');
             } else {
                 out.append(c);
             }
@@ -123,12 +118,10 @@ public class EngineDynmap {
         }
 
         // Shedule non thread safe sync at the end!
-        Bukkit.getScheduler().scheduleSyncRepeatingTask(FactionsPlugin.getInstance(), () ->
+        Bukkit.getScheduler().scheduleSyncRepeatingTask(FactionsPlugin.getInstance(), () -> {
-        {
 
             final Map<String, TempMarker> homes = createHomes();
             final Map<String, TempAreaMarker> areas = createAreas();
-            final Map<String, TempPolyLineMarker> polys = createPolys(areas);
             final Map<String, Set<String>> playerSets = createPlayersets();
 
             if (!updateCore()) {
@@ -142,7 +135,6 @@ public class EngineDynmap {
 
             updateHomes(homes);
             updateAreas(areas);
-            updatePolys(polys);
             updatePlayersets(playerSets);
         }, 100L, 100L);
     }
@@ -244,7 +236,6 @@ public class EngineDynmap {
             // NOTE: That way what is left at the end will be outdated markers to remove.
             Marker marker = markers.remove(markerId);
             if (marker == null) {
-                marker = temp.create(this.markerApi, this.markerset, markerId);
                 marker = temp.create(this.markerApi, this.markerset, markerId);
                 if (marker == null) {
                     EngineDynmap.severe("Could not get/create the home marker " + markerId);
@@ -266,29 +257,6 @@ public class EngineDynmap {
     // -------------------------------------------- //
 
     // Thread Safe: YES
-
-    public Map<String, TempPolyLineMarker> createPolys(Map<String, TempAreaMarker> areas) {
-        Map<String, TempPolyLineMarker> ret = new HashMap<String, TempPolyLineMarker>();
-        for (Entry<String, TempAreaMarker> entry : areas.entrySet()) {
-            String markerID = entry.getKey();
-            TempAreaMarker area = entry.getValue();
-
-            int counter = 0;
-            for (List<Point> points : area.getPolyLine()) {
-                markerID = markerID + "_poly_" + counter;
-                TempPolyLineMarker tempPoly = new TempPolyLineMarker();
-                tempPoly.polyLine = points;
-                tempPoly.lineColor = area.lineColor;
-                tempPoly.lineOpacity = area.lineOpacity;
-                tempPoly.lineWeight = area.lineWeight;
-                tempPoly.world = area.world;
-                ret.put(markerID, tempPoly);
-                counter++;
-            }
-        }
-        return ret;
-    }
-
     public Map<String, TempAreaMarker> createAreas() {
         Map<String, Map<Faction, Set<FLocation>>> worldFactionChunks = createWorldFactionChunks();
         return createAreas(worldFactionChunks);
@@ -306,13 +274,13 @@ public class EngineDynmap {
             String world = entry.getKey().getWorldName();
             Faction chunkOwner = Factions.getInstance().getFactionById(entry.getValue());
 
-            Map<Faction, Set<FLocation>> factionChunks = worldFactionChunks.get(world);
+            Map<Faction, Set<FLocation>> factionChunks = worldFactionChunks.computeIfAbsent(world, s -> null);
             if (factionChunks == null) {
                 factionChunks = new HashMap<>();
                 worldFactionChunks.put(world, factionChunks);
             }
 
-            Set<FLocation> factionTerritory = factionChunks.get(chunkOwner);
+            Set<FLocation> factionTerritory = factionChunks.computeIfAbsent(chunkOwner, s -> null);
             if (factionTerritory == null) {
                 factionTerritory = new HashSet<>();
                 factionChunks.put(chunkOwner, factionTerritory);
@@ -380,11 +348,12 @@ public class EngineDynmap {
 
         // Loop through until we don't find more areas
         while (allChunks != null) {
-
             TileFlags ourChunkFlags = null;
             LinkedList<FLocation> ourChunks = null;
             LinkedList<FLocation> newChunks = null;
 
+            int minimumX = Integer.MAX_VALUE;
+            int minimumZ = Integer.MAX_VALUE;
             for (FLocation chunk : allChunks) {
                 int chunkX = (int) chunk.getX();
                 int chunkZ = (int) chunk.getZ();
@@ -395,10 +364,18 @@ public class EngineDynmap {
                     ourChunks = new LinkedList<>();
                     floodFillTarget(allChunkFlags, ourChunkFlags, chunkX, chunkZ); // Copy shape
                     ourChunks.add(chunk); // Add it to our chunk list
+                    minimumX = chunkX;
+                    minimumZ = chunkZ;
                 }
                 // If shape found, and we're in it, add to our node list
                 else if (ourChunkFlags != null && ourChunkFlags.getFlag(chunkX, chunkZ)) {
                     ourChunks.add(chunk);
+                    if (chunkX < minimumX) {
+                        minimumX = chunkX;
+                        minimumZ = chunkZ;
+                    } else if (chunkX == minimumX && chunkZ < minimumZ) {
+                        minimumZ = chunkZ;
+                    }
                 }
                 // Else, keep it in the list for the next polygon
                 else {
@@ -411,129 +388,86 @@ public class EngineDynmap {
 
             // Replace list (null if no more to process)
             allChunks = newChunks;
+
             if (ourChunkFlags == null) {
                 continue;
             }
-            List<TempLine> outputLines = new ArrayList<TempLine>();
-            Map<TempLine, Integer> lines = new HashMap<TempLine, Integer>();
 
-            if (ourChunks == null) {
+            // Trace outline of blocks - start from minx, minz going to x+
-                continue;
+            int initialX = minimumX;
-            }
+            int initialZ = minimumZ;
-
+            int currentX = minimumX;
-            for (FLocation loc : ourChunks) {
+            int currentZ = minimumZ;
-                int x = loc.getChunk().getX();
+            Direction direction = Direction.XPLUS;
-                int z = loc.getChunk().getZ();
+            ArrayList<int[]> linelist = new ArrayList<>();
-
+            linelist.add(new int[]{initialX, initialZ}); // Add start point
-                TempLine line = new TempLine(new Point(x * 16, z * 16), new Point(x * 16 + 16, z * 16));
+            while ((currentX != initialX) || (currentZ != initialZ) || (direction != Direction.ZMINUS)) {
-                if (lines.containsKey(line)) {
+                switch (direction) {
-                    lines.put(line, lines.get(line) + 1);
+                    case XPLUS: // Segment in X+ direction
-                } else {
+                        if (!ourChunkFlags.getFlag(currentX + 1, currentZ)) { // Right turn?
-                    lines.put(line, 1);
+                            linelist.add(new int[]{currentX + 1, currentZ}); // Finish line
-                }
+                            direction = Direction.ZPLUS; // Change direction
-
+                        } else if (!ourChunkFlags.getFlag(currentX + 1, currentZ - 1)) { // Straight?
-                line = new TempLine(new Point(x * 16 + 16, z * 16), new Point(x * 16 + 16, z * 16 + 16));
+                            currentX++;
-                if (lines.containsKey(line)) {
+                        } else { // Left turn
-                    lines.put(line, lines.get(line) + 1);
+                            linelist.add(new int[]{currentX + 1, currentZ}); // Finish line
-                } else {
+                            direction = Direction.ZMINUS;
-                    lines.put(line, 1);
+                            currentX++;
-                }
+                            currentZ--;
-
+                        }
-                line = new TempLine(new Point(x * 16 + 16, z * 16 + 16), new Point(x * 16, z * 16 + 16));
+                        break;
-                if (lines.containsKey(line)) {
+                    case ZPLUS: // Segment in Z+ direction
-                    lines.put(line, lines.get(line) + 1);
+                        if (!ourChunkFlags.getFlag(currentX, currentZ + 1)) { // Right turn?
-                } else {
+                            linelist.add(new int[]{currentX + 1, currentZ + 1}); // Finish line
-                    lines.put(line, 1);
+                            direction = Direction.XMINUS; // Change direction
-                }
+                        } else if (!ourChunkFlags.getFlag(currentX + 1, currentZ + 1)) { // Straight?
-
+                            currentZ++;
-                line = new TempLine(new Point(x * 16, z * 16 + 16), new Point(x * 16, z * 16));
+                        } else { // Left turn
-                if (lines.containsKey(line)) {
+                            linelist.add(new int[]{currentX + 1, currentZ + 1}); // Finish line
-                    lines.put(line, lines.get(line) + 1);
+                            direction = Direction.XPLUS;
-                } else {
+                            currentX++;
-                    lines.put(line, 1);
+                            currentZ++;
+                        }
+                        break;
+                    case XMINUS: // Segment in X- direction
+                        if (!ourChunkFlags.getFlag(currentX - 1, currentZ)) { // Right turn?
+                            linelist.add(new int[]{currentX, currentZ + 1}); // Finish line
+                            direction = Direction.ZMINUS; // Change direction
+                        } else if (!ourChunkFlags.getFlag(currentX - 1, currentZ + 1)) { // Straight?
+                            currentX--;
+                        } else { // Left turn
+                            linelist.add(new int[]{currentX, currentZ + 1}); // Finish line
+                            direction = Direction.ZPLUS;
+                            currentX--;
+                            currentZ++;
+                        }
+                        break;
+                    case ZMINUS: // Segment in Z- direction
+                        if (!ourChunkFlags.getFlag(currentX, currentZ - 1)) { // Right turn?
+                            linelist.add(new int[]{currentX, currentZ}); // Finish line
+                            direction = Direction.XPLUS; // Change direction
+                        } else if (!ourChunkFlags.getFlag(currentX - 1, currentZ - 1)) { // Straight?
+                            currentZ--;
+                        } else { // Left turn
+                            linelist.add(new int[]{currentX, currentZ}); // Finish line
+                            direction = Direction.XMINUS;
+                            currentX--;
+                            currentZ--;
+                        }
+                        break;
                 }
             }
 
-            Iterator<Entry<TempLine, Integer>> iterator = lines.entrySet().iterator();
+            int sz = linelist.size();
-
+            double[] x = new double[sz];
-            List<TempLine> lineList = new ArrayList<TempLine>();
+            double[] z = new double[sz];
-            lineList.addAll(lines.keySet());
+            for (int i = 0; i < sz; i++) {
-
+                int[] line = linelist.get(i);
-            while (iterator.hasNext()) {
+                x[i] = (double) line[0] * (double) BLOCKS_PER_CHUNK;
-                Entry<TempLine, Integer> entry = iterator.next();
+                z[i] = (double) line[1] * (double) BLOCKS_PER_CHUNK;
-                if (entry.getValue() > 1) {
-                    lineList.remove(entry.getKey());
-                }
             }
 
-            // Find the leftmost MCRWPoint
-
-            TempLine l = null;
-            for (Iterator<TempLine> it = lineList.iterator(); it.hasNext(); ) {
-                TempLine tl = it.next();
-                if (l == null || tl.getP1().x < l.getP1().x)
-                    l = tl;
-            }
-
-            for (Iterator<TempLine> it = lineList.iterator(); it.hasNext(); ) {
-                TempLine tl = it.next();
-                if (tl.getP2().x < l.getP2().x)
-                    l = tl;
-            }
-
-            outputLines.add(l);
-            lineList.remove(l);
-            while (lineList.size() > 0) {
-                // MCRWPoint targetp = new MCRWPoint((int) lastLine.x1, (int) lastLine.y1);
-                // MCRWPointWLines.get(targetp);
-
-                TempLine nextLine = null;
-                for (Iterator<TempLine> it = lineList.iterator(); it.hasNext(); ) {
-                    TempLine line = it.next();
-                    if (l.getP2().x == line.getP1().x && l.getP2().y == line.getP1().y) {
-
-                        nextLine = line;
-                    }
-
-                }
-
-                if (nextLine != null) {
-                    outputLines.add(nextLine);
-                    lineList.remove(nextLine);
-                    l = nextLine;
-                } else {
-                    outputLines.get(outputLines.size() - 1).addAdditionLines(CamScan1(lineList));
-                    break;
-                }
-
-            }
-            List<Point> outputPoints = new ArrayList<Point>();
-
-            List<Point> polyPoints = new ArrayList<Point>();
-
-            for (int i = 0; i < outputLines.size(); i++) {
-                Point p = new Point(outputLines.get(i).getP1().x, outputLines.get(i).getP1().y);
-                outputPoints.add(p);
-                polyPoints.add(p);
-                if (outputLines.get(i).getConnectedLines().size() > 0) {
-
-                    outputPoints.addAll(addRecursivePoints(new Point(outputLines.get(i).getP1().x, outputLines.get(i).getP1().y), outputLines.get(i)));
-                }
-                p = new Point(outputLines.get(i).getP2().x, outputLines.get(i).getP2().y);
-                outputPoints.add(p);
-                polyPoints.add(p);
-            }
-            polyLine.add(polyPoints);
-
             // Build information for specific area
-            double[] x = new double[outputPoints.size()];
-            double[] z = new double[outputPoints.size()];
-
-            for (int i = 0; i < outputPoints.size(); i++) {
-                x[i] = outputPoints.get(i).x;
-                z[i] = outputPoints.get(i).y;
-            }
-
             String markerId = FACTIONS_ + world + "__" + faction.getId() + "__" + markerIndex;
 
             TempAreaMarker temp = new TempAreaMarker();
@@ -551,10 +485,8 @@ public class EngineDynmap {
             temp.fillOpacity = style.getFillOpacity();
 
             temp.boost = style.getBoost();
-            temp.setPolyLine(polyLine);
 
             ret.put(markerId, temp);
-            polyLine.clear();
 
             markerIndex++;
         }
@@ -562,114 +494,10 @@ public class EngineDynmap {
         return ret;
     }
 
-    public List<Point> addRecursivePoints(Point returnPoint, TempLine line) {
-        List<Point> ret = new ArrayList<Point>();
-        boolean shouldReturn = false;
-        List<TempLine> connectedLines = line.getConnectedLines();
-        List<Point> polyPoints = new ArrayList<Point>();
-        for (TempLine line2 : connectedLines) {
-            Point p = new Point(line2.getP1().x, line2.getP1().y);
-            ret.add(p);
-            polyPoints.add(p);
-            shouldReturn = true;
-            if (line2.getConnectedLines().size() > 0) {
-                ret.addAll(addRecursivePoints(new Point(line2.getP1().x, line2.getP1().y), line2));
-            }
-            p = new Point(line2.getP2().x, line2.getP2().y);
-            ret.add(p);
-            polyPoints.add(p);
-
-        }
-        if (shouldReturn) {
-            ret.add(returnPoint);
-        }
-        polyLine.add(polyPoints);
-        return ret;
-    }
-
-    private List<TempLine> CamScan1(List<TempLine> lineList) {
-        List<TempLine> ret = new ArrayList<TempLine>();
-
-        // Find the leftmost MCRWPoint
-
-        TempLine l = null;
-        for (Iterator<TempLine> it = lineList.iterator(); it.hasNext(); ) {
-
-            TempLine tl = it.next();
-            if (l == null || tl.getP1().x < l.getP1().x)
-                l = tl;
-        }
-
-        for (Iterator<TempLine> it = lineList.iterator(); it.hasNext(); ) {
-            TempLine tl = it.next();
-            if (tl.getP2().x < l.getP2().x)
-                l = tl;
-        }
-
-        ret.add(l);
-        lineList.remove(l);
-        while (lineList.size() > 0) {
-            // MCRWPoint targetp = new MCRWPoint((int) lastLine.x1, (int) lastLine.y1);
-            // MCRWPointWLines.get(targetp);
-
-            TempLine thisChunkLine = null;
-            for (Iterator<TempLine> it = lineList.iterator(); it.hasNext(); ) {
-                TempLine line = it.next();
-                if (l.getP2().x == line.getP1().x && l.getP2().y == line.getP1().y) {
-
-                    thisChunkLine = line;
-                }
-
-            }
-            if (thisChunkLine != null) {
-                ret.add(thisChunkLine);
-                lineList.remove(thisChunkLine);
-                l = thisChunkLine;
-            } else {
-                // break;
-                ret.get(ret.size() - 1).addAdditionLines(CamScan1(lineList));
-            }
-
-        }
-        return ret;
-    }
-
     // -------------------------------------------- //
     // UTIL & SHARED
     // -------------------------------------------- //
 
-    public void updatePolys(Map<String, TempPolyLineMarker> polys) {
-        // Map Current
-        Map<String, PolyLineMarker> markers = new HashMap<>();
-        for (PolyLineMarker marker : this.markerset.getPolyLineMarkers()) {
-            markers.put(marker.getMarkerID(), marker);
-        }
-
-        // Loop New
-        for (Entry<String, TempPolyLineMarker> entry : polys.entrySet()) {
-            String markerId = entry.getKey();
-            TempPolyLineMarker temp = entry.getValue();
-
-            // Get Creative
-            // NOTE: I remove from the map created just in the beginning of this method.
-            // NOTE: That way what is left at the end will be outdated markers to remove.
-            PolyLineMarker marker = markers.remove(markerId);
-            if (marker == null) {
-                marker = temp.create(this.markerset, markerId);
-                if (marker == null) {
-                    severe("Could not get/create the area marker " + markerId);
-                }
-            } else {
-                temp.update(marker);
-            }
-        }
-
-        // Only old/outdated should now be left. Delete them.
-        for (PolyLineMarker marker : markers.values()) {
-            marker.deleteMarker();
-        }
-    }
-
     // Thread Safe: NO
     public void updateAreas(Map<String, TempAreaMarker> areas) {
         // Map Current
@@ -827,6 +655,7 @@ public class EngineDynmap {
             money = String.format("%.2f", Econ.getBalance(faction.getAccountId()));
         ret = ret.replace("%money%", money);
 
+
         // Players
         Set<FPlayer> playersList = faction.getFPlayers();
         String playersCount = String.valueOf(playersList.size());
@@ -843,6 +672,7 @@ public class EngineDynmap {
         String playersModeratorsCount = String.valueOf(playersModeratorsList.size());
         String playersModerators = getHtmlPlayerString(playersModeratorsList);
 
+
         ArrayList<FPlayer> playersNormalsList = faction.getFPlayersWhereRole(Role.NORMAL);
         String playersNormalsCount = String.valueOf(playersNormalsList.size());
         String playersNormals = getHtmlPlayerString(playersNormalsList);
@@ -902,8 +732,7 @@ public class EngineDynmap {
     }
 
     // Find all contiguous blocks, set in target and clear in source
-    private int floodFillTarget(TileFlags source, TileFlags destination, int x, int y) {
+    private void floodFillTarget(TileFlags source, TileFlags destination, int x, int y) {
-        int cnt = 0;
         ArrayDeque<int[]> stack = new ArrayDeque<>();
         stack.push(new int[]{x, y});
 
@@ -914,7 +743,6 @@ public class EngineDynmap {
             if (source.getFlag(x, y)) { // Set in src
                 source.setFlag(x, y, false); // Clear source
                 destination.setFlag(x, y, true); // Set in destination
-                cnt++;
                 if (source.getFlag(x + 1, y)) {
                     stack.push(new int[]{x + 1, y});
                 }
@@ -929,7 +757,6 @@ public class EngineDynmap {
                 }
             }
         }
-        return cnt;
     }
 
     enum Direction {

src/main/java/com/massivecraft/factions/integration/dynmap/TempAreaMarker.java

@@ -3,10 +3,6 @@ package com.massivecraft.factions.integration.dynmap;
 import org.dynmap.markers.AreaMarker;
 import org.dynmap.markers.MarkerSet;
 
-import java.awt.*;
-import java.util.ArrayList;
-import java.util.List;
-
 public class TempAreaMarker {
 
     /**
@@ -22,13 +18,15 @@ public class TempAreaMarker {
     public double[] x;
     public double[] z;
     public String description;
+
     public int lineColor;
     public double lineOpacity;
     public int lineWeight;
+
     public int fillColor;
     public double fillOpacity;
+
     public boolean boost;
-    private List<List<Point>> polyLine = new ArrayList<List<Point>>();
 
     // -------------------------------------------- //
     // CREATE
@@ -56,15 +54,6 @@ public class TempAreaMarker {
         return true;
     }
 
-    public List<List<Point>> getPolyLine() {
-        return polyLine;
-    }
-
-    public void setPolyLine(List<List<Point>> points) {
-        polyLine.clear();
-        polyLine.addAll(points);
-    }
-
     // -------------------------------------------- //
     // UPDATE
     // -------------------------------------------- //
@@ -72,17 +61,16 @@ public class TempAreaMarker {
     public AreaMarker create(MarkerSet markerset, String markerId) {
         AreaMarker ret = markerset.createAreaMarker(markerId, this.label, false, this.world, this.x, this.z, false // not persistent
         );
+
         if (ret == null) {
             return null;
         }
 
-        int counter = 0;
-
         // Description
         ret.setDescription(this.description);
 
         // Line Style
-        ret.setLineStyle(0, 0, 0);
+        ret.setLineStyle(this.lineWeight, this.lineOpacity, this.lineColor);
 
         // Fill Style
         ret.setFillStyle(this.fillOpacity, this.fillColor);
@@ -92,6 +80,7 @@ public class TempAreaMarker {
 
         return ret;
     }
+
     // -------------------------------------------- //
     // UTIL
     // -------------------------------------------- //
@@ -106,15 +95,18 @@ public class TempAreaMarker {
         if (!marker.getLabel().equals(this.label)) {
             marker.setLabel(this.label);
         }
+
+        // Description
         if (!marker.getDescription().equals(this.description)) {
             marker.setDescription(this.description);
         }
 
-        // // Line Style
+        // Line Style
-        // if (marker.getLineWeight() != this.lineWeight || marker.getLineOpacity() != this.lineOpacity || marker.getLineColor() != this.lineColor)
+        if (marker.getLineWeight() != this.lineWeight ||
-        // {
+                marker.getLineOpacity() != this.lineOpacity ||
-        // marker.setLineStyle(this.lineWeight, this.lineOpacity, this.lineColor);
+                marker.getLineColor() != this.lineColor) {
-        // }
+            marker.setLineStyle(this.lineWeight, this.lineOpacity, this.lineColor);
+        }
 
         // Fill Style
         if ((marker.getFillOpacity() != this.fillOpacity) || (marker.getFillColor() != this.fillColor)) {

src/main/java/com/massivecraft/factions/integration/dynmap/TempLine.java

@@ -1,49 +0,0 @@
-package com.massivecraft.factions.integration.dynmap;
-
-import java.awt.*;
-import java.util.ArrayList;
-import java.util.List;
-
-public class TempLine {
-    private Point p1;
-    private Point p2;
-    private List<TempLine> connectedLines = new ArrayList<TempLine>();
-
-    TempLine(Point p1, Point p2) {
-        this.p1 = p1;
-        this.p2 = p2;
-    }
-
-    public Point getP1() {
-        return p1;
-    }
-
-    public Point getP2() {
-        return p2;
-    }
-
-    public void addAdditionLines(List<TempLine> connectedLines) {
-        this.connectedLines = connectedLines;
-    }
-
-    public List<TempLine> getConnectedLines() {
-        return connectedLines;
-    }
-
-    @Override
-    public boolean equals(Object o) {
-        TempLine line = (TempLine) o;
-        if (line.p1.x == this.p1.x && line.p2.x == this.p2.x && line.p1.y == this.p1.y && line.p2.y == this.p2.y) {
-            return true;
-        }
-		return line.p1.x == this.p2.x && line.p2.x == this.p1.x && line.p1.y == this.p2.y && line.p2.y == this.p1.y;
-	}
-
-    @Override
-    public int hashCode() {
-        String test = "" + (p1.x + p2.x);
-        test += " " + (p1.y + p2.y);
-        return test.hashCode();
-    }
-
-}

src/main/java/com/massivecraft/factions/integration/dynmap/TempMarkerSet.java

@@ -15,7 +15,7 @@ public class TempMarkerSet {
     public boolean hideByDefault;
 
     public MarkerSet create(MarkerAPI markerApi, String id) {
-        MarkerSet ret = markerApi.createMarkerSet(id, this.label, null, false); // ("null, false" at the end means "all icons allowed, not perisistent")
+        MarkerSet ret = markerApi.createMarkerSet(id, this.label, null, false); // ("null, false" at the end means "all icons allowed, not persistent")
 
         if (ret == null) {
             return null;
@@ -41,10 +41,8 @@ public class TempMarkerSet {
             markerset.setMarkerSetLabel(this.label);
         }
 
-        if (this.minimumZoom > 0) {
+        if (this.minimumZoom > 0 && markerset.getMinZoom() != this.minimumZoom) {
-            if (markerset.getMinZoom() != this.minimumZoom) {
                 markerset.setMinZoom(this.minimumZoom);
-            }
         }
 
         if (markerset.getLayerPriority() != this.priority) {

src/main/java/com/massivecraft/factions/integration/dynmap/TempPolyLineMarker.java

@@ -1,99 +0,0 @@
-package com.massivecraft.factions.integration.dynmap;
-
-import org.dynmap.markers.MarkerSet;
-import org.dynmap.markers.PolyLineMarker;
-
-import java.awt.*;
-import java.util.ArrayList;
-import java.util.List;
-
-public class TempPolyLineMarker {
-
-    /**
-     * @author FactionsUUID Team
-     */
-
-    // -------------------------------------------- //
-    // FIELDS
-    // -------------------------------------------- //
-
-    public String world;
-
-    public List<Point> polyLine = new ArrayList<Point>();
-
-    public int lineColor;
-    public double lineOpacity;
-    public int lineWeight;
-
-    // -------------------------------------------- //
-    // CREATE
-    // -------------------------------------------- //
-
-    public static boolean equals(PolyLineMarker marker, List<Point> points) {
-        int length = marker.getCornerCount();
-
-        if (points.size() != length) {
-            return false;
-        }
-        for (int i = 0; i < length; i++) {
-            if (marker.getCornerX(i) != points.get(i).x) {
-                return false;
-            }
-            if (marker.getCornerZ(i) != points.get(i).y) {
-                return false;
-            }
-        }
-
-        return true;
-    }
-
-    // -------------------------------------------- //
-    // UPDATE
-    // -------------------------------------------- //
-
-    public PolyLineMarker create(MarkerSet markerset, String markerId) {
-        double[] polyX = new double[polyLine.size()];
-        double[] polyY = new double[polyLine.size()];
-        double[] polyZ = new double[polyLine.size()];
-        for (int i = 0; i < polyLine.size(); i++) {
-            Point p = polyLine.get(i);
-            polyX[i] = p.getX();
-            polyY[i] = 64;
-            polyZ[i] = p.getY();
-        }
-        PolyLineMarker poly = markerset.createPolyLineMarker(markerId, "", false, this.world, polyX, polyY, polyZ, false);
-        // Poly Line Style
-        if (poly != null) {
-            poly.setLineStyle(this.lineWeight, this.lineOpacity, this.lineColor);
-        }
-        return poly;
-    }
-
-    // -------------------------------------------- //
-    // UTIL
-    // -------------------------------------------- //
-
-    public void update(PolyLineMarker marker) {
-        // Corner Locations
-        if (!equals(marker, polyLine)) {
-            double[] polyX = new double[polyLine.size()];
-            double[] polyY = new double[polyLine.size()];
-            double[] polyZ = new double[polyLine.size()];
-            for (int i = 0; i < polyLine.size(); i++) {
-                Point p = polyLine.get(i);
-                polyX[i] = p.getX();
-                polyY[i] = 64;
-                polyZ[i] = p.getY();
-            }
-            marker.setCornerLocations(polyX, polyY, polyZ);
-            marker.setLineStyle(this.lineWeight, this.lineOpacity, this.lineColor);
-        }
-
-        // Line Style
-        if (marker.getLineWeight() != this.lineWeight || marker.getLineOpacity() != this.lineOpacity || marker.getLineColor() != this.lineColor) {
-            marker.setLineStyle(this.lineWeight, this.lineOpacity, this.lineColor);
-        }
-
-    }
-
-}

src/main/java/com/massivecraft/factions/listeners/FactionsBlockListener.java

@@ -47,6 +47,8 @@ public class FactionsBlockListener implements Listener {
     public static HashMap<String, Location> bannerLocations = new HashMap<>();
     private HashMap<String, Boolean> bannerCooldownMap = new HashMap<>();
     private long placeTimer = TimeUnit.SECONDS.toMillis(15L);
+    private static final String varFac = "{faction}";
+    private static final String varAction = "{action}";
 
 
     public static boolean playerCanBuildDestroyBlock(Player player, Location location, String action, boolean justCheck) {
@@ -61,9 +63,8 @@ public class FactionsBlockListener implements Listener {
 
         if (otherFaction.isWilderness()) {
             if (Conf.worldGuardBuildPriority && Worldguard.getInstance().playerCanBuild(player, location)) return true;
-            if (location.getWorld() != null) {
+            if (location.getWorld() != null && !Conf.wildernessDenyBuild || Conf.worldsNoWildernessProtection.contains(location.getWorld().getName())) {
-                if (!Conf.wildernessDenyBuild || Conf.worldsNoWildernessProtection.contains(location.getWorld().getName()))
+                return true;
-                    return true;
             }
             if (!justCheck) me.msg(TL.ACTION_DENIED_WILDERNESS, action);
             return false;
@@ -93,24 +94,27 @@ public class FactionsBlockListener implements Listener {
         boolean landOwned = (myFaction.doesLocationHaveOwnersSet(loc) && !myFaction.getOwnerList(loc).isEmpty());
         if ((landOwned && myFaction.getOwnerListString(loc).contains(player.getName())) || (me.getRole() == Role.LEADER && me.getFactionId().equals(myFaction.getId())))
             return true;
-        else if (landOwned && !myFaction.getOwnerListString(loc).contains(player.getName())) {
+        else {
-            me.msg(TL.ACTIONS_OWNEDTERRITORYDENY.toString().replace("{owners}", myFaction.getOwnerListString(loc)));
+            String replace = TL.ACTIONS_NOPERMISSIONPAIN.toString().replace(varAction, action.toString());
-            if (shouldHurt) {
+            if (landOwned && !myFaction.getOwnerListString(loc).contains(player.getName())) {
-                player.damage(Conf.actionDeniedPainAmount);
+                me.msg(TL.ACTIONS_OWNEDTERRITORYDENY.toString().replace("{owners}", myFaction.getOwnerListString(loc)));
-                me.msg(TL.ACTIONS_NOPERMISSIONPAIN.toString().replace("{action}", action.toString()).replace("{faction}", Board.getInstance().getFactionAt(loc).getTag(myFaction)));
+                if (shouldHurt) {
-            }
+                    player.damage(Conf.actionDeniedPainAmount);
-            return false;
+                    me.msg(replace.replace(varFac, Board.getInstance().getFactionAt(loc).getTag(myFaction)));
-        } else if (!landOwned && access == Access.DENY) { // If land is not owned but access is set to DENY anyway
+                }
-            if (shouldHurt) {
+                return false;
-                player.damage(Conf.actionDeniedPainAmount);
+            } else if (!landOwned && access == Access.DENY) { // If land is not owned but access is set to DENY anyway
-                if ((Board.getInstance().getFactionAt(loc).getTag(myFaction)) != null)
+                if (shouldHurt) {
-                    me.msg(TL.ACTIONS_NOPERMISSIONPAIN.toString().replace("{action}", action.toString()).replace("{faction}", Board.getInstance().getFactionAt(loc).getTag(myFaction)));
+                    player.damage(Conf.actionDeniedPainAmount);
-            }
+                    if ((Board.getInstance().getFactionAt(loc).getTag(myFaction)) != null)
-            if (myFaction.getTag(me.getFaction()) != null && action != null)
+                        me.msg(replace.replace(varFac, Board.getInstance().getFactionAt(loc).getTag(myFaction)));
-                me.msg(TL.ACTIONS_NOPERMISSION.toString().replace("{faction}", myFaction.getTag(me.getFaction())).replace("{action}", action.toString()));
+                }
-            return false;
+                if (myFaction.getTag(me.getFaction()) != null && action != null)
-        } else if (access == Access.ALLOW) return true;
+                    me.msg(TL.ACTIONS_NOPERMISSION.toString().replace(varFac, myFaction.getTag(me.getFaction())).replace(varAction, action.toString()));
-        me.msg(TL.ACTIONS_NOPERMISSION.toString().replace("{faction}", myFaction.getTag(me.getFaction())).replace("{action}", action.toString()));
+                return false;
+            } else if (access == Access.ALLOW) return true;
+        }
+        me.msg(TL.ACTIONS_NOPERMISSION.toString().replace(varFac, myFaction.getTag(me.getFaction())).replace(varAction, action.toString()));
         return false;
     }
 
@@ -118,10 +122,10 @@ public class FactionsBlockListener implements Listener {
         if (Conf.ownedAreasEnabled && target.doesLocationHaveOwnersSet(location) && !target.playerHasOwnershipRights(me, location)) {
             // If pain should be applied
             if (pain && Conf.ownedAreaPainBuild)
-                me.msg(TL.ACTIONS_OWNEDTERRITORYPAINDENY.toString().replace("{action}", action.toString()).replace("{faction}", target.getOwnerListString(location)));
+                me.msg(TL.ACTIONS_OWNEDTERRITORYPAINDENY.toString().replace(varAction, action.toString()).replace(varFac, target.getOwnerListString(location)));
             if (Conf.ownedAreaDenyBuild && pain) return false;
             else if (Conf.ownedAreaDenyBuild) {
-                me.msg(TL.ACTIONS_NOPERMISSION.toString().replace("{faction}", target.getTag(me.getFaction())).replace("{action}", action.toString()));
+                me.msg(TL.ACTIONS_NOPERMISSION.toString().replace(varFac, target.getTag(me.getFaction())).replace(varAction, action.toString()));
                 return false;
             }
         }
@@ -168,11 +172,9 @@ public class FactionsBlockListener implements Listener {
             return;
         }
 
-        if (isSpawner) {
+        if (isSpawner && Conf.spawnerLock) {
-            if (Conf.spawnerLock) {
+            event.setCancelled(true);
-                event.setCancelled(true);
+            event.getPlayer().sendMessage(FactionsPlugin.getInstance().color(TL.COMMAND_SPAWNER_LOCK_CANNOT_PLACE.toString()));
-                event.getPlayer().sendMessage(FactionsPlugin.getInstance().color(TL.COMMAND_SPAWNER_LOCK_CANNOT_PLACE.toString()));
-            }
         }
     }
 
@@ -180,23 +182,21 @@ public class FactionsBlockListener implements Listener {
     public void onBlockFromTo(BlockFromToEvent event) {
         if (!Conf.handleExploitLiquidFlow) return;
 
-        if (event.getBlock().isLiquid()) {
+        if (event.getBlock().isLiquid() && event.getToBlock().isEmpty()) {
-            if (event.getToBlock().isEmpty()) {
+            Faction from = Board.getInstance().getFactionAt(new FLocation(event.getBlock()));
-                Faction from = Board.getInstance().getFactionAt(new FLocation(event.getBlock()));
+            Faction to = Board.getInstance().getFactionAt(new FLocation(event.getToBlock()));
-                Faction to = Board.getInstance().getFactionAt(new FLocation(event.getToBlock()));
+            if (from == to) return;
-                if (from == to) return;
+            // from faction != to faction
-                // from faction != to faction
+            if (to.isSystemFaction()) {
-                if (to.isSystemFaction()) {
+                event.setCancelled(true);
-                    event.setCancelled(true);
+                return;
+            }
+
+            if (to.isNormal()) {
+                if (from.isNormal() && from.getRelationTo(to).isAlly()) {
                     return;
                 }
-
+                event.setCancelled(true);
-                if (to.isNormal()) {
-                    if (from.isNormal() && from.getRelationTo(to).isAlly()) {
-                        return;
-                    }
-                    event.setCancelled(true);
-                }
             }
         }
     }
@@ -217,7 +217,7 @@ public class FactionsBlockListener implements Listener {
         Block targetBlock = event.getBlock().getRelative(event.getDirection(), event.getLength() + 1);
 
         // if potentially pushing into air/water/lava in another territory, we need to check it out
-        if ((targetBlock.isEmpty() || targetBlock.isLiquid()) && !canPistonMoveBlock(pistonFaction, targetBlock.getLocation()))
+        if ((targetBlock.isEmpty() || targetBlock.isLiquid()) && canPistonMoveBlock(pistonFaction, targetBlock.getLocation()))
             event.setCancelled(true);
     }
 
@@ -286,12 +286,10 @@ public class FactionsBlockListener implements Listener {
                         continue;
                     }
 
-                    if (blockLoc.getBlock().getType() == XMaterial.CHEST.parseMaterial()) {
+                    if (blockLoc.getBlock().getType() == XMaterial.CHEST.parseMaterial() && factionAt.getVault().equals(blockLoc)) {
-                        if (factionAt.getVault().equals(blockLoc)) {
+                        e.setCancelled(true);
-                            e.setCancelled(true);
+                        fme.msg(TL.COMMAND_VAULT_NO_HOPPER);
-                            fme.msg(TL.COMMAND_VAULT_NO_HOPPER);
+                        return;
-                            return;
-                        }
                     }
                 }
             }
@@ -316,7 +314,7 @@ public class FactionsBlockListener implements Listener {
         // if potentially retracted block is just air/water/lava, no worries
         if (targetLoc.getBlock().isEmpty() || targetLoc.getBlock().isLiquid()) return;
         Faction pistonFaction = Board.getInstance().getFactionAt(new FLocation(event.getBlock()));
-        if (!canPistonMoveBlock(pistonFaction, targetLoc)) event.setCancelled(true);
+        if (canPistonMoveBlock(pistonFaction, targetLoc)) event.setCancelled(true);
     }
 
     @EventHandler
@@ -326,11 +324,9 @@ public class FactionsBlockListener implements Listener {
             return;
         }
 
-        if (bannerLocations.containsValue(e.getBlock().getLocation())) {
+        if (bannerLocations.containsValue(e.getBlock().getLocation()) && e.getBlock().getType().name().contains("BANNER")) {
-            if (e.getBlock().getType().name().contains("BANNER")) {
+            e.setCancelled(true);
-                e.setCancelled(true);
+            fme.msg(TL.BANNER_CANNOT_BREAK);
-                fme.msg(TL.BANNER_CANNOT_BREAK);
-            }
         }
     }
 
@@ -430,7 +426,7 @@ public class FactionsBlockListener implements Listener {
         if (!justCheck) fPlayer.setLastFrostwalkerMessage();
 
         // Check if they have build permissions here. If not, block this from happening.
-        if (!playerCanBuildDestroyBlock(player, location, "frostwalk", justCheck))
+        if (!playerCanBuildDestroyBlock(player, location, PermissableAction.FROST_WALK.toString(), justCheck))
             event.setCancelled(true);
     }
 
@@ -449,15 +445,15 @@ public class FactionsBlockListener implements Listener {
     private boolean canPistonMoveBlock(Faction pistonFaction, Location target) {
         Faction otherFaction = Board.getInstance().getFactionAt(new FLocation(target));
 
-        if (pistonFaction == otherFaction) return true;
+        if (pistonFaction == otherFaction) return false;
 
         if (otherFaction.isWilderness())
-            return !Conf.wildernessDenyBuild || Conf.worldsNoWildernessProtection.contains(target.getWorld().getName());
+            return Conf.wildernessDenyBuild && !Conf.worldsNoWildernessProtection.contains(target.getWorld().getName());
-        else if (otherFaction.isSafeZone()) return !Conf.safeZoneDenyBuild;
+        else if (otherFaction.isSafeZone()) return Conf.safeZoneDenyBuild;
-        else if (otherFaction.isWarZone()) return !Conf.warZoneDenyBuild;
+        else if (otherFaction.isWarZone()) return Conf.warZoneDenyBuild;
 
         Relation rel = pistonFaction.getRelationTo(otherFaction);
-        return !rel.confDenyBuild(otherFaction.hasPlayersOnline());
+        return rel.confDenyBuild(otherFaction.hasPlayersOnline());
     }
 
     @EventHandler(priority = EventPriority.NORMAL, ignoreCancelled = true)
@@ -505,14 +501,12 @@ public class FactionsBlockListener implements Listener {
 
 
     @EventHandler(priority = EventPriority.HIGHEST)
-    public void FrameRemove(HangingBreakByEntityEvent event) {
+    public void frameRemove(HangingBreakByEntityEvent event) {
         if (event.getRemover() == null) return;
-        if ((event.getRemover() instanceof Player)) {
+        if ((event.getRemover() instanceof Player) && event.getEntity().getType().equals(EntityType.ITEM_FRAME)) {
-            if (event.getEntity().getType().equals(EntityType.ITEM_FRAME)) {
+            Player p = (Player) event.getRemover();
-                Player p = (Player) event.getRemover();
+            if (!playerCanBuildDestroyBlock(p, event.getEntity().getLocation(), "destroy", true)) {
-                if (!playerCanBuildDestroyBlock(p, event.getEntity().getLocation(), "destroy", true)) {
+                event.setCancelled(true);
-                    event.setCancelled(true);
-                }
             }
         }
     }
@@ -521,7 +515,7 @@ public class FactionsBlockListener implements Listener {
     public void onFarmLandDamage(EntityChangeBlockEvent event) {
         if (event.getEntity() instanceof Player) {
             Player player = (Player) event.getEntity();
-            if (!playerCanBuildDestroyBlock(player, event.getBlock().getLocation(), "destroy", true)) {
+            if (!playerCanBuildDestroyBlock(player, event.getBlock().getLocation(), PermissableAction.DESTROY.name(), true)) {
                 FPlayer me = FPlayers.getInstance().getByPlayer(player);
                 Faction otherFaction = Board.getInstance().getFactionAt(new FLocation(event.getBlock().getLocation()));
                 me.msg(TL.ACTION_DENIED_OTHER, otherFaction.getTag(), "trample crops");

src/main/java/com/massivecraft/factions/listeners/FactionsChatListener.java

@@ -87,7 +87,7 @@ public class FactionsChatListener implements Listener {
                     fplayer.sendMessage("[FCspy] " + myFaction.getTag() + ": " + message);
                 }
             }
-            FactionChatHandler.sendMessage(FactionsPlugin.getInstance(), myFaction, me.getPlayer().getUniqueId(), me.getPlayer().getName(), event.getMessage());
+            FactionChatHandler.sendMessage(myFaction, me.getPlayer().getUniqueId(), me.getPlayer().getName(), event.getMessage());
             event.setCancelled(true);
         } else if (chat == ChatMode.ALLIANCE) {
             Faction myFaction = me.getFaction();

src/main/java/com/massivecraft/factions/listeners/FactionsEntityListener.java

@@ -143,7 +143,7 @@ public class FactionsEntityListener implements Listener {
                     } else {
                         // we don't want to let mobs/arrows destroy item frames/armor stands
                         // so we only have to run the check as if there had been an explosion at the damager location
-                        if (!this.checkExplosionForBlock(damager, damagee.getLocation().getBlock()))
+                        if (this.checkExplosionForBlock(damager, damagee.getLocation().getBlock()))
                             event.setCancelled(true);
                     }
                     // we don't need to go after
@@ -216,7 +216,7 @@ public class FactionsEntityListener implements Listener {
         Entity boomer = event.getEntity();
 
         // Before we need to check the location where the block is placed
-        if (!this.checkExplosionForBlock(boomer, event.getLocation().getBlock())) {
+        if (this.checkExplosionForBlock(boomer, event.getLocation().getBlock())) {
             event.setCancelled(true);
             return;
         }
@@ -224,7 +224,7 @@ public class FactionsEntityListener implements Listener {
         // Loop the blocklist to run checks on each aimed block
 
         // The block don't have to explode
-        event.blockList().removeIf(block -> !this.checkExplosionForBlock(boomer, block));
+        event.blockList().removeIf(block -> this.checkExplosionForBlock(boomer, block));
 
         // Cancel the event if no block will explode
         if (!event.blockList().isEmpty() && (boomer instanceof TNTPrimed || boomer instanceof ExplosiveMinecart) && Conf.handleExploitTNTWaterlog) {
@@ -259,7 +259,7 @@ public class FactionsEntityListener implements Listener {
         Faction faction = Board.getInstance().getFactionAt(new FLocation(block.getLocation()));
 
         if (faction.noExplosionsInTerritory() || (faction.isPeaceful() && Conf.peacefulTerritoryDisableBoom))
-            return false;
+            return true;
         // faction is peaceful and has explosions set to disabled
 
         boolean online = faction.hasPlayersOnline();
@@ -269,17 +269,17 @@ public class FactionsEntityListener implements Listener {
                 (faction.isWarZone() && Conf.warZoneBlockCreepers) ||
                 faction.isSafeZone())) {
             // creeper which needs prevention
-            return false;
+            return true;
         } else if (
             // it's a bit crude just using fireball protection for Wither boss too, but I'd rather not add in a whole new set of xxxBlockWitherExplosion or whatever
                 (boomer instanceof Fireball || boomer instanceof Wither) && (faction.isWilderness() && Conf.wildernessBlockFireballs && !Conf.worldsNoWildernessProtection.contains(block.getWorld().getName()) || faction.isNormal() && (online ? Conf.territoryBlockFireballs : Conf.territoryBlockFireballsWhenOffline) || faction.isWarZone() && Conf.warZoneBlockFireballs || faction.isSafeZone())) {
             // ghast fireball which needs prevention
-            return false;
+            return true;
         } else
-            return (!(boomer instanceof TNTPrimed) && !(boomer instanceof ExplosiveMinecart)) || ((!faction.isWilderness() || !Conf.wildernessBlockTNT || Conf.worldsNoWildernessProtection.contains(block.getWorld().getName())) &&
+            return (boomer instanceof TNTPrimed || boomer instanceof ExplosiveMinecart) && ((faction.isWilderness() && Conf.wildernessBlockTNT && !Conf.worldsNoWildernessProtection.contains(block.getWorld().getName())) ||
-                    (!faction.isNormal() || (online ? !Conf.territoryBlockTNT : !Conf.territoryBlockTNTWhenOffline)) &&
+                    (faction.isNormal() && (online ? Conf.territoryBlockTNT : Conf.territoryBlockTNTWhenOffline)) ||
-                    (!faction.isWarZone() || !Conf.warZoneBlockTNT) &&
+                    (faction.isWarZone() && Conf.warZoneBlockTNT) ||
-                    (!faction.isSafeZone() || !Conf.safeZoneBlockTNT));
+                    (faction.isSafeZone() && Conf.safeZoneBlockTNT));
 
         // No condition retained, destroy the block!
     }
@@ -311,7 +311,7 @@ public class FactionsEntityListener implements Listener {
         if (thrower instanceof Player) {
             Player player = (Player) thrower;
             FPlayer fPlayer = FPlayers.getInstance().getByPlayer(player);
-            if (badjuju && fPlayer.getFaction().isPeaceful()) {
+            if (fPlayer.getFaction().isPeaceful()) {
                 event.setCancelled(true);
                 return;
             }
@@ -506,10 +506,8 @@ public class FactionsEntityListener implements Listener {
         if (!(e.getRemover() instanceof Player)) return;
         Player p = (Player) e.getRemover();
 
-        if (e.getEntity().getType() == EntityType.PAINTING || e.getEntity().getType() == EntityType.ITEM_FRAME) {
+        if (e.getEntity().getType() == EntityType.PAINTING || e.getEntity().getType() == EntityType.ITEM_FRAME && !FactionsBlockListener.playerCanBuildDestroyBlock(p, e.getEntity().getLocation(), "destroy", false)) {
-            if (!FactionsBlockListener.playerCanBuildDestroyBlock(p, e.getEntity().getLocation(), "destroy", false)) {
+            e.setCancelled(true);
-                e.setCancelled(true);
-            }
         }
     }
 
@@ -517,11 +515,9 @@ public class FactionsEntityListener implements Listener {
     public void onPaintingPlace(HangingPlaceEvent e) {
         if (e.getPlayer() == null) return;
 
-        if (e.getEntity().getType() == EntityType.PAINTING || e.getEntity().getType() == EntityType.ITEM_FRAME) {
+        if (e.getEntity().getType() == EntityType.PAINTING || e.getEntity().getType() == EntityType.ITEM_FRAME && !FactionsBlockListener.playerCanBuildDestroyBlock(e.getPlayer(), e.getBlock().getLocation(), "build", false)) {
-            if (!FactionsBlockListener.playerCanBuildDestroyBlock(e.getPlayer(), e.getBlock().getLocation(), "build", false)) {
+            e.setCancelled(true);
-                e.setCancelled(true);
+            e.getPlayer().updateInventory();
-                e.getPlayer().updateInventory();
-            }
         }
     }
 
@@ -546,73 +542,37 @@ public class FactionsEntityListener implements Listener {
     }
 
 
-    /*
-    @EventHandler
-    public void onTravel(PlayerPortalEvent event) {
-        if (!FactionsPlugin.getInstance().getConfig().getBoolean("portals.limit", false))
-            return; // Don't do anything if they don't want us to.
-
-
-        TravelAgent agent = event.getPortalTravelAgent();
-
-        // If they aren't able to find a portal, it'll try to create one.
-        if (event.useTravelAgent() && agent.getCanCreatePortal() && agent.findPortal(event.getTo()) == null) {
-            FLocation loc = new FLocation(event.getTo());
-            Faction faction = Board.getInstance().getFactionAt(loc);
-            if (faction.isWilderness()) {
-                return; // We don't care about wilderness.
-            } else if (!faction.isNormal() && !event.getPlayer().isOp()) {
-                // Don't let non ops make portals in safezone or warzone.
-                event.setCancelled(true);
-                return;
-            }
-
-            FPlayer fp = FPlayers.getInstance().getByPlayer(event.getPlayer());
-            String mininumRelation = FactionsPlugin.getInstance().getConfig().getString("portals.minimum-relation", "MEMBER"); // Defaults to Neutral if typed wrong.
-            if (!fp.getFaction().getRelationTo(faction).isAtLeast(Relation.fromString(mininumRelation))) {
-                event.setCancelled(true);
-            }
-        }
-    }
-     */
-
     @EventHandler
     public void onHit(EntityDamageByEntityEvent e) {
-        if (e.getDamager() instanceof Player) {
+        if (e.getDamager() instanceof Player && e.getEntity() instanceof Player) {
-            if (e.getEntity() instanceof Player) {
+            Player victim = (Player) e.getEntity();
-                Player victim = (Player) e.getEntity();
+            Player attacker = (Player) e.getDamager();
-                Player attacker = (Player) e.getDamager();
+            FPlayer fvictim = FPlayers.getInstance().getByPlayer(victim);
-                FPlayer fvictim = FPlayers.getInstance().getByPlayer(victim);
+            FPlayer fattacker = FPlayers.getInstance().getByPlayer(attacker);
-                FPlayer fattacker = FPlayers.getInstance().getByPlayer(attacker);
+            if (fattacker.getRelationTo(fvictim) == Relation.TRUCE) {
-                if (fattacker.getRelationTo(fvictim) == Relation.TRUCE) {
+                fattacker.msg(TL.PLAYER_PVP_CANTHURT, fvictim.describeTo(fattacker));
-                    fattacker.msg(TL.PLAYER_PVP_CANTHURT, fvictim.describeTo(fattacker));
+                e.setCancelled(true);
-                    e.setCancelled(true);
-                }
             }
         }
     }
 
     @EventHandler
     public void onBowHit(EntityDamageByEntityEvent e) {
-        if (e.getDamager() instanceof Projectile) {
+        if (e.getDamager() instanceof Projectile && e.getEntity() instanceof Player) {
-            if (e.getEntity() instanceof Player) {
+            Projectile arrow = ((Projectile) e.getDamager());
-                Projectile arrow = ((Projectile) e.getDamager());
+            if (arrow.getShooter() instanceof Player) {
-                if (arrow.getShooter() instanceof Player) {
+                Player damager = (Player) ((Projectile) e.getDamager()).getShooter();
-                    Player damager = (Player) ((Projectile) e.getDamager()).getShooter();
+                Player victim = (Player) e.getEntity();
-                    Player victim = (Player) e.getEntity();
+                FPlayer fdamager = FPlayers.getInstance().getByPlayer(damager);
-                    FPlayer fdamager = FPlayers.getInstance().getByPlayer(damager);
+                FPlayer fvictim = FPlayers.getInstance().getByPlayer(victim);
-                    FPlayer fvictim = FPlayers.getInstance().getByPlayer(victim);
+                if (damager == victim) return;
-                    if (damager == victim) return;
+                if (fdamager == fvictim) return;
-                    if (fdamager == fvictim) return;
+                if (fvictim.getRelationTo(fdamager) == Relation.TRUCE) {
-                    if (fvictim.getRelationTo(fdamager) == Relation.TRUCE) {
+                    fdamager.msg(TL.PLAYER_PVP_CANTHURT, fvictim.describeTo(fdamager));
-                        fdamager.msg(TL.PLAYER_PVP_CANTHURT, fvictim.describeTo(fdamager));
+                    e.setCancelled(true);
-                        e.setCancelled(true);
+                }
-                    }
+                if (fvictim.getRelationTo(fdamager) == Relation.ENEMY && fvictim.isFlying()) {
-                    if (fvictim.getRelationTo(fdamager) == Relation.ENEMY) {
+                    fvictim.setFFlying(false, true);
-                        if (fvictim.isFlying()) {
-                            fvictim.setFFlying(false, true);
-                        }
-                    }
                 }
             }
         }

src/main/java/com/massivecraft/factions/listeners/FactionsPlayerListener.java

@@ -54,9 +54,7 @@ import java.util.logging.Level;
 
 public class FactionsPlayerListener implements Listener {
 
-    public final static Map<UUID, Location> lastLocations = new HashMap<>();
     public static Set<FLocation> corners;
-    public static BukkitTask positionTask = null;
     /**
      * @author FactionsUUID Team
      */
@@ -190,7 +188,6 @@ public class FactionsPlayerListener implements Listener {
         FLocation loc = new FLocation(block);
         Faction otherFaction = Board.getInstance().getFactionAt(loc);
         Faction myFaction = me.getFaction();
-        Relation rel = myFaction.getRelationTo(otherFaction);
 
         // no door/chest/whatever protection in wilderness, war zones, or safe zones
         if (otherFaction.isSystemFaction()) return true;
@@ -489,7 +486,7 @@ public class FactionsPlayerListener implements Listener {
 
         if (FactionsPlugin.instance.getConfig().getBoolean("scoreboard.default-enabled", false)) {
             FScoreboard.init(me);
-            FScoreboard.get(me).setDefaultSidebar(new FDefaultSidebar());
+            FScoreboard.get(me).setDefaultSidebar(new FDefaultSidebar(), FactionsPlugin.instance.getConfig().getInt("scoreboard.default-update-interval", 20));
             FScoreboard.get(me).setSidebarVisibility(me.showScoreboard());
         }
 
@@ -521,13 +518,11 @@ public class FactionsPlayerListener implements Listener {
 
     @EventHandler
     public void onPlayerFall(EntityDamageEvent e) {
-        if (e.getEntity() instanceof Player) {
+        if (e.getEntity() instanceof Player && e.getCause() == EntityDamageEvent.DamageCause.FALL) {
-            if (e.getCause() == EntityDamageEvent.DamageCause.FALL) {
+            Player player = (Player) e.getEntity();
-                Player player = (Player) e.getEntity();
+            if (fallMap.containsKey(player)) {
-                if (fallMap.containsKey(player)) {
+                e.setCancelled(true);
-                    e.setCancelled(true);
+                fallMap.remove(player);
-                    fallMap.remove(player);
-                }
             }
         }
     }
@@ -564,7 +559,7 @@ public class FactionsPlayerListener implements Listener {
 
         CmdSeeChunk.seeChunkMap.remove(event.getPlayer().getName());
 
-        FScoreboard.remove(me, event.getPlayer());
+        FScoreboard.remove(me);
     }
 
     public String parseAllPlaceholders(String string, Faction faction, Player player) {
@@ -615,7 +610,7 @@ public class FactionsPlayerListener implements Listener {
                 fplayer.msg(TL.COMMAND_INSPECT_BYPASS);
             }
             List<String[]> info = CoreProtect.getInstance().getAPI().blockLookup(e.getClickedBlock(), 0);
-            if (info.size() == 0) {
+            if (info.isEmpty()) {
                 e.getPlayer().sendMessage(TL.COMMAND_INSPECT_NODATA.toString());
                 return;
             }
@@ -654,6 +649,9 @@ public class FactionsPlayerListener implements Listener {
         return (result.length() == 3 ? result + "0" : result) + "/hrs ago";
     }
 
+    public static BukkitTask positionTask = null;
+    public final Map<UUID, Location> lastLocations = new HashMap<>();
+
     public void startPositionCheck() {
         positionTask = Bukkit.getScheduler().runTaskTimer(FactionsPlugin.getInstance(), () -> {
             if (lastLocations.isEmpty()) return;
@@ -737,9 +735,7 @@ public class FactionsPlayerListener implements Listener {
                     me.attemptClaim(me.getAutoClaimFor(), newLocation, true);
                 }
                 FactionsPlugin.instance.logFactionEvent(me.getAutoClaimFor(), FLogType.CHUNK_CLAIMS, me.getName(), CC.GreenB + "CLAIMED", String.valueOf(1), (new FLocation(player.getLocation())).formatXAndZ(","));
-                if (Conf.disableFlightOnFactionClaimChange && FactionsPlugin.getInstance().getConfig().getBoolean("enable-faction-flight"))
+                if (Conf.disableFlightOnFactionClaimChange) CmdFly.disableFlight(me);
-                    CmdFly.disableFlight(me);
-
             } else if (me.isAutoSafeClaimEnabled()) {
                 if (!Permission.MANAGE_SAFE_ZONE.has(player)) {
                     me.setIsAutoSafeClaimEnabled(false);
@@ -828,18 +824,14 @@ public class FactionsPlayerListener implements Listener {
         // Do type null checks so if XMaterial has a parsing issue and fills null as a value it will not bypass.
         // territoryCancelAndAllowItemUseMaterial bypass the protection system but only if they're not clicking on territoryDenySwitchMaterials
         // if they're clicking on territoryDenySwitchMaterials, let the protection system handle the permissions
-        if (type != null && !Conf.territoryDenySwitchMaterials.contains(block.getType())) {
+        if (type != null && !Conf.territoryDenySwitchMaterials.contains(block.getType()) && Conf.territoryCancelAndAllowItemUseMaterial.contains(type)) {
-            if (Conf.territoryCancelAndAllowItemUseMaterial.contains(type)) {
+            return;
-                return;
-            }
         }
 
-        if (GetPermissionFromUsableBlock(block.getType()) != null) {
+        if (GetPermissionFromUsableBlock(block.getType()) != null && !canPlayerUseBlock(player, block, false)) {
-            if (!canPlayerUseBlock(player, block, false)) {
+            event.setCancelled(true);
-                event.setCancelled(true);
+            event.setUseInteractedBlock(Event.Result.DENY);
-                event.setUseInteractedBlock(Event.Result.DENY);
+            return;
-                return;
-            }
         }
 
         if (type != null && !playerCanUseItemHere(player, block.getLocation(), event.getItem().getType(), false, PermissableAction.ITEM)) {
@@ -860,14 +852,13 @@ public class FactionsPlayerListener implements Listener {
     public void onPlayerBoneMeal(PlayerInteractEvent event) {
         Block block = event.getClickedBlock();
         if (event.getAction() == Action.RIGHT_CLICK_BLOCK && block.getType() == XMaterial.GRASS_BLOCK.parseMaterial()
-                && event.hasItem() && event.getItem().getType() == XMaterial.BONE_MEAL.parseMaterial()) {
+                && event.hasItem() && event.getItem().getType() == XMaterial.BONE_MEAL.parseMaterial()
-            if (!FactionsBlockListener.playerCanBuildDestroyBlock(event.getPlayer(), block.getLocation(), "build", true)) {
+                && !FactionsBlockListener.playerCanBuildDestroyBlock(event.getPlayer(), block.getLocation(), PermissableAction.BUILD.name(), true)) {
-                FPlayer me = FPlayers.getInstance().getById(event.getPlayer().getUniqueId().toString());
+            FPlayer me = FPlayers.getInstance().getById(event.getPlayer().getUniqueId().toString());
-                Faction myFaction = me.getFaction();
+            Faction myFaction = me.getFaction();
 
-                me.msg(TL.ACTIONS_NOPERMISSION.toString().replace("{faction}", myFaction.getTag(me.getFaction())).replace("{action}", "use bone meal"));
+            me.msg(TL.ACTIONS_NOPERMISSION.toString().replace("{faction}", myFaction.getTag(me.getFaction())).replace("{action}", "use bone meal"));
-                event.setCancelled(true);
+            event.setCancelled(true);
-            }
         }
     }
 
@@ -935,10 +926,8 @@ public class FactionsPlayerListener implements Listener {
                 player.sendMessage(String.valueOf(TL.COMMAND_LOGOUT_DAMAGE_TAKEN));
             }
             WaitExecutor.handleAction(player);
-            if (CmdWild.teleporting.contains(player)) {
+            if (CmdWild.teleporting.contains(player) && !FactionsPlugin.getInstance().getConfig().getBoolean("Wild.FallDamage") && e.getCause() == EntityDamageEvent.DamageCause.FALL) {
-                if (!FactionsPlugin.getInstance().getConfig().getBoolean("Wild.FallDamage") && e.getCause() == EntityDamageEvent.DamageCause.FALL) {
+                e.setCancelled(true);
-                    e.setCancelled(true);
-                }
             }
         }
     }
@@ -947,7 +936,6 @@ public class FactionsPlayerListener implements Listener {
     public void onTeleport(PlayerTeleportEvent e) {
         Player player = e.getPlayer();
 
-        if (player == null) return;
         LogoutHandler handler = LogoutHandler.getByName(player.getName());
         if (handler.isLogoutActive(player)) {
             handler.cancelLogout(player);
@@ -985,7 +973,7 @@ public class FactionsPlayerListener implements Listener {
     }
 
     @EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true)
-    final public void onFactionJoin(FPlayerJoinEvent event) {
+    final void onFactionJoin(FPlayerJoinEvent event) {
         FTeamWrapper.applyUpdatesLater(event.getFaction());
     }
 
@@ -999,7 +987,7 @@ public class FactionsPlayerListener implements Listener {
     }
 
     @EventHandler
-    public void AsyncPlayerChatEvent(AsyncPlayerChatEvent e) {
+    public void asyncPlayerChatEvent(AsyncPlayerChatEvent e) {
         Player p = e.getPlayer();
 
         if (CmdFGlobal.toggled.contains(p.getUniqueId())) {
@@ -1025,10 +1013,8 @@ public class FactionsPlayerListener implements Listener {
 
         for (int i = l.size() - 1; i >= 0; i--) { // going backwards in the list to prevent a ConcurrentModificationException
             Player recipient = l.get(i);
-            if (recipient != null) {
+            if (recipient != null && CmdFGlobal.toggled.contains(recipient.getUniqueId())) {
-                if (CmdFGlobal.toggled.contains(recipient.getUniqueId())) {
+                e.getRecipients().remove(recipient);
-                    e.getRecipients().remove(recipient);
-                }
             }
         }
     }

src/main/java/com/massivecraft/factions/listeners/MenuListener.java

@@ -15,9 +15,6 @@ import org.bukkit.inventory.ItemStack;
  */
 public class MenuListener implements Listener {
 
-    public MenuListener() {
-    }
-
     @EventHandler
     public void onInventoryClick(InventoryClickEvent event) {
         if (event.getView().getTitle().equals("Faction Logs")) {

src/main/java/com/massivecraft/factions/scoreboards/BufferedObjective.java

@@ -9,27 +9,15 @@ import org.bukkit.scoreboard.Team;
 
 import java.lang.reflect.Method;
 import java.util.*;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
 
 public class BufferedObjective {
+
+    /**
+     * @author FactionsUUID Team
+     */
+
     private static final Method addEntryMethod;
     private static final int MAX_LINE_LENGTH;
-    private static final Pattern PATTERN = Pattern.compile("(\u00A7[0-9a-fk-r])|(.)");
-
-    private final Scoreboard scoreboard;
-    private final String baseName;
-
-    private Objective current;
-    private List<Team> currentTeams = new ArrayList<>();
-    private String title;
-    private DisplaySlot displaySlot;
-
-    private int objPtr;
-    private int teamPtr;
-    private boolean requiresUpdate = false;
-
-    private final Map<Integer, String> contents = new HashMap<>();
 
     static {
         // Check for long line support.
@@ -51,6 +39,17 @@ public class BufferedObjective {
         }
     }
 
+    private final Scoreboard scoreboard;
+    private final String baseName;
+    private final Map<Integer, String> contents = new HashMap<>();
+    private Objective current;
+    private List<Team> currentTeams = new ArrayList<>();
+    private String title;
+    private DisplaySlot displaySlot;
+    private int objPtr;
+    private int teamPtr;
+    private boolean requiresUpdate = false;
+
     public BufferedObjective(Scoreboard scoreboard) {
         this.scoreboard = scoreboard;
         this.baseName = createBaseName();
@@ -123,75 +122,14 @@ public class BufferedObjective {
                 Team team = scoreboard.registerNewTeam(getNextTeamName());
                 bufferTeams.add(team);
 
-                String name, prefix = null, suffix = null;
+                Iterator<String> split = Splitter.fixedLength(16).split(entry.getValue()).iterator();
 
-                String value = entry.getValue();
+                team.setPrefix(split.next());
-                if (value.length() > 16) {
+                String name = split.next();
-                    String[] arrImAPirate = new String[3];
+                if (split.hasNext()) { // We only guarantee two splits
-                    Matcher matcherrr = PATTERN.matcher(value);
+                    team.setSuffix(split.next());
-                    StringBuilder builderrr = new StringBuilder();
-                    int sCURvy = 0;
-                    char currrentColorrr = 'r';
-                    char currrentFormat = 'r';
-                    while (sCURvy < 3 && matcherrr.find()) {
-                        String tharSheBlows = matcherrr.group();
-                        boolean hoist = false;
-                        if (tharSheBlows.length() == 1) {
-                            builderrr.append(tharSheBlows);
-                            if (builderrr.length() == 16) {
-                                hoist = true;
-                            }
-                        } else {
-                            char c = tharSheBlows.charAt(1);
-                            if (c >= 'k' && c <= 'r') { // format!
-                                currrentFormat = c;
-                                if (c == 'r') {
-                                    currrentColorrr = 'r';
-                                }
-                            } else {
-                                currrentColorrr = c;
-                                currrentFormat = 'r';
-                            }
-                            if (builderrr.length() < 14) {
-                                builderrr.append(tharSheBlows);
-                            } else {
-                                hoist = true;
-                            }
-                        }
-                        if (hoist) {
-                            arrImAPirate[sCURvy++] = builderrr.toString();
-                            builderrr = new StringBuilder();
-                            if (currrentColorrr != 'r') {
-                                builderrr.append('\u00A7').append(currrentColorrr);
-                            }
-                            if (currrentFormat != 'r') {
-                                builderrr.append('\u00A7').append(currrentFormat);
-                            }
-                        }
-                    }
-                    if (sCURvy < 3 && builderrr.length() > 0) {
-                        arrImAPirate[sCURvy] = builderrr.toString();
-                    }
-                    if (arrImAPirate[2] == null) {
-                        name = arrImAPirate[0];
-                        suffix = arrImAPirate[1];
-                    } else {
-                        prefix = arrImAPirate[0];
-                        name = arrImAPirate[1];
-                        suffix = arrImAPirate[2];
-                    }
-                } else {
-                    name = value;
                 }
 
-                if (prefix != null) {
-                    team.setPrefix(prefix);
-                }
-                if (suffix != null) {
-                    team.setSuffix(suffix);
-                }
-
-
                 try {
                     addEntryMethod.invoke(team, name);
                 } catch (ReflectiveOperationException ignored) {

src/main/java/com/massivecraft/factions/scoreboards/FScoreboard.java

@@ -58,13 +58,10 @@ public class FScoreboard {
         FTeamWrapper.track(fboard);
     }
 
-    public static void remove(FPlayer fplayer, Player player) {
+    public static void remove(FPlayer fplayer) {
         FScoreboard fboard = fscoreboards.remove(fplayer);
 
         if (fboard != null) {
-            if (fboard.scoreboard == player.getScoreboard()) { // No equals method implemented, so may as well skip a nullcheck
-                player.setScoreboard(Bukkit.getScoreboardManager().getMainScoreboard());
-            }
             fboard.removed = true;
             FTeamWrapper.untrack(fboard);
         }
@@ -94,7 +91,7 @@ public class FScoreboard {
         bufferedObjective.setDisplaySlot(visible ? DisplaySlot.SIDEBAR : null);
     }
 
-    public void setDefaultSidebar(final FSidebarProvider provider) {
+    public void setDefaultSidebar(final FSidebarProvider provider, int updateInterval) {
         if (!isSupportedByServer()) {
             return;
         }
@@ -117,7 +114,7 @@ public class FScoreboard {
                     updateObjective();
                 }
             }
-        }.runTaskTimer(FactionsPlugin.getInstance(), 20, 20);
+        }.runTaskTimer(FactionsPlugin.getInstance(), updateInterval, updateInterval);
     }
 
     public void setTemporarySidebar(final FSidebarProvider provider) {
@@ -140,7 +137,7 @@ public class FScoreboard {
                     updateObjective();
                 }
             }
-        }.runTaskLater(FactionsPlugin.getInstance(), FactionsPlugin.getInstance().getConfig().getInt("scoreboard.expiration", 7) * 20);
+        }.runTaskLater(FactionsPlugin.getInstance(), FactionsPlugin.getInstance().getConfig().getInt("scoreboard.expiration", 7) * 20L);
     }
 
     private void updateObjective() {

src/main/java/com/massivecraft/factions/scoreboards/FSidebarProvider.java

@@ -3,7 +3,6 @@ package com.massivecraft.factions.scoreboards;
 import com.massivecraft.factions.FPlayer;
 import com.massivecraft.factions.Faction;
 import com.massivecraft.factions.FactionsPlugin;
-import com.massivecraft.factions.tag.Tag;
 import com.massivecraft.factions.zcore.util.TL;
 import com.massivecraft.factions.zcore.util.TagUtil;
 
@@ -21,16 +20,16 @@ public abstract class FSidebarProvider {
     public abstract List<String> getLines(FPlayer fplayer);
 
     public String replaceTags(FPlayer fPlayer, String s) {
-        s = Tag.parsePlaceholders(fPlayer.getPlayer(), s);
+        s = TagUtil.parsePlaceholders(fPlayer.getPlayer(), s);
 
-        return qualityAssure(Tag.parsePlain(fPlayer, s));
+        return qualityAssure(TagUtil.parsePlain(fPlayer, s));
     }
 
     public String replaceTags(Faction faction, FPlayer fPlayer, String s) {
         // Run through Placeholder API first
-        s = Tag.parsePlaceholders(fPlayer.getPlayer(), s);
+        s = TagUtil.parsePlaceholders(fPlayer.getPlayer(), s);
 
-        return qualityAssure(Tag.parsePlain(faction, fPlayer, s));
+        return qualityAssure(Objects.requireNonNull(TagUtil.parsePlain(faction, fPlayer, s)));
     }
 
     private String qualityAssure(String line) {

src/main/java/com/massivecraft/factions/scoreboards/FTeamWrapper.java

@@ -19,13 +19,14 @@ public class FTeamWrapper {
 
     private static final Map<Faction, FTeamWrapper> wrappers = new HashMap<>();
     private static final List<FScoreboard> tracking = new ArrayList<>();
-    private static int factionTeamPtr;
     private static final Set<Faction> updating = new HashSet<>();
-
+    private static int factionTeamPtr;
     private final Map<FScoreboard, Team> teams = new HashMap<>();
     private final String teamName;
     private final Faction faction;
     private final Set<OfflinePlayer> members = new HashSet<>();
+    private static final String defaultPrefixes = "scoreboard.default-prefixes";
+    private static final String invisFactionMembers = "See-Invisible-Faction-Members";
 
     private FTeamWrapper(Faction faction) {
         this.teamName = "faction_" + (factionTeamPtr++);
@@ -37,11 +38,18 @@ public class FTeamWrapper {
     }
 
     public static void applyUpdatesLater(final Faction faction) {
-        if (!FScoreboard.isSupportedByServer()) return;
+        if (!FScoreboard.isSupportedByServer()) {
-        if (faction.isWilderness()) return;
-        if (!FactionsPlugin.getInstance().getConfig().getBoolean("scoreboard.default-prefixes", false)
-                || FactionsPlugin.getInstance().getConfig().getBoolean("See-Invisible-Faction-Members"))
             return;
+        }
+
+        if (faction.isWilderness()) {
+            return;
+        }
+
+        if (!FactionsPlugin.getInstance().getConfig().getBoolean(defaultPrefixes, false) || FactionsPlugin.getInstance().getConfig().getBoolean(invisFactionMembers)) {
+            return;
+        }
+
 
         if (updating.add(faction)) {
             Bukkit.getScheduler().runTask(FactionsPlugin.getInstance(), () -> {
@@ -52,17 +60,22 @@ public class FTeamWrapper {
     }
 
     public static void applyUpdates(Faction faction) {
-        if (!FScoreboard.isSupportedByServer()) return;
+        if (!FScoreboard.isSupportedByServer()) {
-
-        if (faction.isWilderness()) return;
-
-
-        if (!FactionsPlugin.getInstance().getConfig().getBoolean("scoreboard.default-prefixes", false)
-                || FactionsPlugin.getInstance().getConfig().getBoolean("See-Invisible-Faction-Members"))
             return;
+        }
 
+        if (faction.isWilderness()) {
+            return;
+        }
 
-        if (updating.contains(faction)) return;
+        if (!FactionsPlugin.getInstance().getConfig().getBoolean(defaultPrefixes, false) || FactionsPlugin.getInstance().getConfig().getBoolean(invisFactionMembers)) {
+            return;
+        }
+
+        if (updating.contains(faction)) {
+            // Faction will be updated soon.
+            return;
+        }
 
         FTeamWrapper wrapper = wrappers.get(faction);
         Set<FPlayer> factionMembers = faction.getFPlayers();
@@ -87,16 +100,21 @@ public class FTeamWrapper {
         }
 
         for (FPlayer fmember : factionMembers) {
-            if (!fmember.isOnline()) continue;
+            if (!fmember.isOnline()) {
+                continue;
+            }
 
             // Scoreboard might not have player; add him/her
             wrapper.addPlayer(fmember.getPlayer());
         }
+
         wrapper.updatePrefixes();
     }
 
     public static void updatePrefixes(Faction faction) {
-        if (!FScoreboard.isSupportedByServer()) return;
+        if (!FScoreboard.isSupportedByServer()) {
+            return;
+        }
 
         if (!wrappers.containsKey(faction)) {
             applyUpdates(faction);
@@ -106,22 +124,34 @@ public class FTeamWrapper {
     }
 
     protected static void track(FScoreboard fboard) {
-        if (!FScoreboard.isSupportedByServer()) return;
+        if (!FScoreboard.isSupportedByServer()) {
+            return;
+        }
         tracking.add(fboard);
-        for (FTeamWrapper wrapper : wrappers.values()) wrapper.add(fboard);
+        for (FTeamWrapper wrapper : wrappers.values()) {
+            wrapper.add(fboard);
+        }
     }
 
     protected static void untrack(FScoreboard fboard) {
-        if (!FScoreboard.isSupportedByServer()) return;
+        if (!FScoreboard.isSupportedByServer()) {
+            return;
+        }
         tracking.remove(fboard);
-        for (FTeamWrapper wrapper : wrappers.values()) wrapper.remove(fboard);
+        for (FTeamWrapper wrapper : wrappers.values()) {
+            wrapper.remove(fboard);
+        }
     }
 
     private void add(FScoreboard fboard) {
         Scoreboard board = fboard.getScoreboard();
         Team team = board.registerNewTeam(teamName);
         teams.put(fboard, team);
-        for (OfflinePlayer player : getPlayers()) team.addPlayer(player);
+
+        for (OfflinePlayer player : getPlayers()) {
+            team.addPlayer(player);
+        }
+
         updatePrefix(fboard);
     }
 
@@ -130,25 +160,27 @@ public class FTeamWrapper {
     }
 
     private void updatePrefixes() {
-        if (FactionsPlugin.getInstance().getConfig().getBoolean("scoreboard.default-prefixes", false)) {
+        if (FactionsPlugin.getInstance().getConfig().getBoolean(defaultPrefixes, false)) {
-            for (FScoreboard fboard : teams.keySet()) updatePrefix(fboard);
+            for (FScoreboard fboard : teams.keySet()) {
+                updatePrefix(fboard);
+            }
         }
     }
 
     private void updatePrefix(FScoreboard fboard) {
-        if (FactionsPlugin.getInstance().getConfig().getBoolean("scoreboard.default-prefixes", false)) {
+        if (FactionsPlugin.getInstance().getConfig().getBoolean(defaultPrefixes, false)) {
             FPlayer fplayer = fboard.getFPlayer();
             Team team = teams.get(fboard);
             boolean focused = false;
 
-            if (FactionsPlugin.getInstance().getConfig().getBoolean("See-Invisible-Faction-Members", false)) {
+            if (FactionsPlugin.getInstance().getConfig().getBoolean(invisFactionMembers, false)) {
                 team.setCanSeeFriendlyInvisibles(true);
             }
 
             if ((FactionsPlugin.getInstance().getConfig().getBoolean("ffocus.Enabled")) && (fplayer.getFaction() != null) && (fplayer.getFaction().getFocused() != null)) {
                 for (FPlayer fp : faction.getFPlayersWhereOnline(true)) {
                     if (fplayer.getFaction().getFocused().equalsIgnoreCase(fp.getName())) {
-                        team.setPrefix(ChatColor.translateAlternateColorCodes('&', FactionsPlugin.getInstance().getConfig().getString("ffocus.Prefix", "&7»&b")));
+                        team.setPrefix(ChatColor.translateAlternateColorCodes('&', Objects.requireNonNull(FactionsPlugin.getInstance().getConfig().getString("ffocus.Prefix", "&7»&b"))));
                         focused = true;
                     }
                 }
@@ -161,7 +193,8 @@ public class FTeamWrapper {
                 prefix = prefix.replace("{relationcolor}", faction.getRelationTo(fplayer).getColor().toString());
                 prefix = prefix.replace("{faction}",
                         faction.getTag().substring(0, Math.min("{faction}".length() + 16 - prefix.length(), faction.getTag().length())));
-                if ((team.getPrefix() == null) || (!team.getPrefix().equals(prefix))) {
+                team.getPrefix();
+                if (!team.getPrefix().equals(prefix)) {
                     team.setPrefix(prefix);
                 }
             }

src/main/java/com/massivecraft/factions/shop/ShopGUIFrame.java

@@ -11,7 +11,6 @@ import com.massivecraft.factions.util.XMaterial;
 import com.massivecraft.factions.zcore.util.TL;
 import org.bukkit.Bukkit;
 import org.bukkit.ChatColor;
-import org.bukkit.Material;
 import org.bukkit.configuration.ConfigurationSection;
 import org.bukkit.enchantments.Enchantment;
 import org.bukkit.entity.Player;
@@ -21,9 +20,6 @@ import org.bukkit.inventory.meta.ItemMeta;
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Map;
-import java.util.Set;
-import java.util.logging.Level;
 import java.util.stream.Collectors;
 
 public class ShopGUIFrame {
@@ -35,28 +31,28 @@ public class ShopGUIFrame {
     private Gui gui;
 
     public ShopGUIFrame(Faction f) {
-        gui = new Gui(FactionsPlugin.getInstance(), FactionsPlugin.getInstance().getConfig().getInt("F-Shop.GUI.Rows", 4), FactionsPlugin.getInstance().color(FactionsPlugin.getInstance().getConfig().getString("F-Shop.GUI.Name")));
+        gui = new Gui(FactionsPlugin.getInstance(),
+                FactionsPlugin.getInstance().getConfig().getInt("F-Shop.GUI.Rows", 4),
+                FactionsPlugin.getInstance().color(FactionsPlugin.getInstance().getConfig().getString("F-Shop.GUI.Name")));
     }
 
     public void buildGUI(FPlayer fplayer) {
         PaginatedPane pane = new PaginatedPane(0, 0, 9, gui.getRows());
         List<GuiItem> GUIItems = new ArrayList<>();
         ItemStack dummy = buildDummyItem(fplayer.getFaction());
-        for (int x = 0; x <= (gui.getRows() * 9) - 1; x++)
+        for (int x = 0; x <= (gui.getRows() * 9) - 1; x++) GUIItems.add(new GuiItem(dummy, e -> e.setCancelled(true)));
-            GUIItems.add(new GuiItem(dummy, e -> e.setCancelled(true)));
 
-        Set<String> items = FactionsPlugin.getInstance().getFileManager().getShop().getConfig().getConfigurationSection("items").getKeys(false);
+        int items = FactionsPlugin.getInstance().getFileManager().getShop().getConfig().getConfigurationSection("items").getKeys(false).size();
-        for (String s : items) {
+        for (int a = 1; a <= items; a++) {
-            if (!checkShopConfig(s)) {
+            String s = a + "";
-                continue;
+            String varItems = "items.";
-            }
+            int slot = FactionsPlugin.getInstance().getFileManager().getShop().fetchInt(varItems + s + ".slot");
+            ItemStack item = XMaterial.matchXMaterial(FactionsPlugin.getInstance().getFileManager().getShop().fetchString(varItems + s + ".block")).get().parseItem();
+            int cost = FactionsPlugin.getInstance().getFileManager().getShop().fetchInt(varItems + s + ".cost");
+            String name = FactionsPlugin.getInstance().getFileManager().getShop().fetchString(varItems + s + ".name");
+            boolean glowing = FactionsPlugin.getInstance().getFileManager().getShop().fetchBoolean(varItems + s + ".glowing");
+            List<String> lore = FactionsPlugin.getInstance().getFileManager().getShop().fetchStringList(varItems + s + ".lore");
 
-            int slot = FactionsPlugin.getInstance().getFileManager().getShop().fetchInt("items." + s + ".slot");
-            ItemStack item = XMaterial.matchXMaterial(FactionsPlugin.getInstance().getFileManager().getShop().fetchString("items." + s + ".block")).get().parseItem();
-            int cost = FactionsPlugin.getInstance().getFileManager().getShop().fetchInt("items." + s + ".cost");
-            String name = FactionsPlugin.getInstance().getFileManager().getShop().fetchString("items." + s + ".name");
-            boolean glowing = FactionsPlugin.getInstance().getFileManager().getShop().fetchBoolean("items." + s + ".glowing");
-            List<String> lore = FactionsPlugin.getInstance().getFileManager().getShop().fetchStringList("items." + s + ".lore");
 
             assert item != null;
             ItemMeta meta = item.getItemMeta();
@@ -66,26 +62,23 @@ public class ShopGUIFrame {
                 meta.addItemFlags(ItemFlag.HIDE_ENCHANTS);
                 meta.addEnchant(Enchantment.DURABILITY, 1, true);
             }
-            if (!glowing)
+            if (!glowing) meta.removeEnchant(Enchantment.DURABILITY);
-                meta.removeEnchant(Enchantment.DURABILITY);
             List<String> replacedLore = lore.stream().map(t -> t.replace("{cost}", cost + "")).collect(Collectors.toList());
             meta.setLore(FactionsPlugin.instance.colorList(replacedLore));
             item.setItemMeta(meta);
-            GUIItems.set(slot, new GuiItem(item, e ->
+            GUIItems.set(slot, new GuiItem(item, e -> {
-            {
                 e.setCancelled(true);
                 FPlayer fme = FPlayers.getInstance().getByPlayer((Player) e.getWhoClicked());
                 if (fplayer.getFaction().getPoints() >= cost) {
-                    if (runCommands(FactionsPlugin.getInstance().getFileManager().getShop().fetchStringList("items." + s + ".cmds"), fplayer.getPlayer())) {
+                    fplayer.getFaction().setPoints(fplayer.getFaction().getPoints() - cost);
-                        fplayer.getFaction().setPoints(fplayer.getFaction().getPoints() - cost);
+                    runCommands(FactionsPlugin.getInstance().getFileManager().getShop().fetchStringList("items." + s + ".cmds"), fplayer.getPlayer());
-                        for (FPlayer fplayerBuy : fplayer.getFaction().getFPlayers()) {
+                    for (FPlayer fplayerBuy : fplayer.getFaction().getFPlayers()) {
-                            fplayerBuy.getPlayer().sendMessage(TL.SHOP_BOUGHT_BROADCAST_FACTION.toString().replace("{player}", fplayer.getPlayer().getName()).replace("{item}", ChatColor.stripColor(FactionsPlugin.getInstance().color(name)))
+                        fplayerBuy.getPlayer().sendMessage(TL.SHOP_BOUGHT_BROADCAST_FACTION.toString()
-                                    .replace("{cost}", cost + ""));
+                                .replace("{player}", fplayer.getPlayer().getName())
-                        }
+                                .replace("{item}", ChatColor.stripColor(FactionsPlugin.getInstance().color(name)))
-                        buildGUI(fme);
+                                .replace("{cost}", cost + ""));
-                    } else {
-                        fplayer.msg(TL.SHOP_ERROR_DURING_PURCHASE);
                     }
+                    buildGUI(fme);
                 } else {
                     fplayer.msg(TL.SHOP_NOT_ENOUGH_POINTS);
                 }
@@ -97,6 +90,7 @@ public class ShopGUIFrame {
         }
     }
 
+
     private ItemStack buildDummyItem(Faction f) {
         ConfigurationSection config = FactionsPlugin.getInstance().getConfig().getConfigurationSection("F-Shop.GUI.dummy-item");
         ItemStack item = XMaterial.matchXMaterial(config.getString("Type")).get().parseItem();
@@ -109,83 +103,10 @@ public class ShopGUIFrame {
         return item;
     }
 
-    public boolean checkShopConfig() {
+    public void runCommands(List<String> list, Player p) {
-        boolean ret = true;
-        Set<String> items = FactionsPlugin.getInstance().getFileManager().getShop().getConfig().getConfigurationSection("items").getKeys(false);
-        for (String s : items) {
-            if (checkShopConfig(s) == false) {
-                ret = false;
-            }
-        }
-        return ret;
-    }
-
-    public boolean checkShopConfig(String s) {
-        boolean ret = true;
-        if (!FactionsPlugin.getInstance().getFileManager().getShop().containsKey("items." + s + ".slot")) {
-            FactionsPlugin.getInstance().log(Level.WARNING, "Problem with config item '" + s + "' missing slot variable");
-            ret = false;
-        }
-        if (!FactionsPlugin.getInstance().getFileManager().getShop().containsKey("items." + s + ".block")) {
-            FactionsPlugin.getInstance().log(Level.WARNING, "Problem with config item '" + s + "' missing block variable");
-            ret = false;
-        }
-
-        if (!FactionsPlugin.getInstance().getFileManager().getShop().containsKey("items." + s + ".cmds")) {
-            FactionsPlugin.getInstance().log(Level.WARNING, "Problee with config item '" + s + "' missing cmds variable");
-            ret = false;
-        }
-
-        if (!FactionsPlugin.getInstance().getFileManager().getShop().containsKey("items." + s + ".cost")) {
-            FactionsPlugin.getInstance().log(Level.WARNING, "Problem with config item '" + s + "' missing cost variable this item will cost 0");
-        }
-        if (!FactionsPlugin.getInstance().getFileManager().getShop().containsKey("items." + s + ".name")) {
-            FactionsPlugin.getInstance().log(Level.WARNING, "Problem with config item '" + s + "' missing name variable");
-            ret = false;
-        }
-        return ret;
-    }
-
-    /**
-     * @param list The list of commands to be ran.
-     * @param p    The player that is using the shop
-     * @return if all commands are able to be ran or if they did run.
-     */
-    public boolean runCommands(List<String> list, Player p) {
-        for (String cmd : list) {
-            cmd = cmd.replace("%player%", p.getName());
-            if (cmd.toLowerCase().startsWith("give")) {
-                String[] args = cmd.split(" ");
-                if (args.length == 4) {
-                    Material material = Material.matchMaterial(args[2]);
-                    int amount = Integer.parseInt(args[3]);
-                    Player player = Bukkit.getPlayer(args[1]);
-                    if (!player.isOnline()) {
-                        return false;
-                    }
-                    // See if the player has this item in their inventory;
-                    if (player.getInventory().contains(material) && player.getInventory().firstEmpty() < 0) {
-                        int spacesAvailable = 0;
-                        Map<Integer, ? extends ItemStack> contents = player.getInventory().all(material);
-                        for (ItemStack stack : contents.values()) {
-                            spacesAvailable += stack.getMaxStackSize() - stack.getAmount();
-                        }
-                        if (spacesAvailable < amount) {
-                            return false;
-                        }
-
-                    } else {
-                        if (player.getInventory().firstEmpty() < 0) {
-                            return false;
-                        }
-                    }
-                }
-            }
-        }
         for (String cmd : list) {
             cmd = cmd.replace("%player%", p.getName());
             Bukkit.dispatchCommand(Bukkit.getConsoleSender(), cmd);
         }
-        return true;
     }
 }

src/main/java/com/massivecraft/factions/struct/Role.java

@@ -55,9 +55,9 @@ public enum Role implements Permissable {
                 return COLEADER;
             case 4:
                 return LEADER;
+            default:
+                throw new IllegalStateException("Unexpected value: " + value);
         }
-
-        return null;
     }
 
     public static Role fromString(String check) {
@@ -76,9 +76,9 @@ public enum Role implements Permissable {
             case "recruit":
             case "rec":
                 return RECRUIT;
+            default:
+                throw new IllegalStateException("Unexpected value: " + check.toLowerCase());
         }
-
-        return null;
     }
 
     public boolean isAtLeast(Role role) {

src/main/java/com/massivecraft/factions/tag/FactionTag.java

@@ -6,9 +6,7 @@ import com.massivecraft.factions.Faction;
 import com.massivecraft.factions.FactionsPlugin;
 import com.massivecraft.factions.integration.Econ;
 import com.massivecraft.factions.struct.Relation;
-import com.massivecraft.factions.util.timer.DateTimeFormats;
 import com.massivecraft.factions.zcore.util.TL;
-import org.apache.commons.lang.time.DurationFormatUtils;
 
 import java.util.function.BiFunction;
 import java.util.function.Function;
@@ -19,32 +17,27 @@ public enum FactionTag implements Tag {
      * @author FactionsUUID Team
      */
 
-    HOME_X("{x}", (fac) -> fac.hasHome() ? String.valueOf(fac.getHome().getBlockX()) : Tag.isMinimalShow() ? null : "{ig}"),
+    HOME_X("{x}", fac -> fac.hasHome() ? String.valueOf(fac.getHome().getBlockX()) : Tag.isMinimalShow() ? null : "{ig}"),
-    HOME_Y("{y}", (fac) -> fac.hasHome() ? String.valueOf(fac.getHome().getBlockY()) : Tag.isMinimalShow() ? null : "{ig}"),
+    HOME_Y("{y}", fac -> fac.hasHome() ? String.valueOf(fac.getHome().getBlockY()) : Tag.isMinimalShow() ? null : "{ig}"),
-    HOME_Z("{z}", (fac) -> fac.hasHome() ? String.valueOf(fac.getHome().getBlockZ()) : Tag.isMinimalShow() ? null : "{ig}"),
+    HOME_Z("{z}", fac -> fac.hasHome() ? String.valueOf(fac.getHome().getBlockZ()) : Tag.isMinimalShow() ? null : "{ig}"),
-    CHUNKS("{chunks}", (fac) -> String.valueOf(fac.getLandRounded())),
+    CHUNKS("{chunks}", fac -> String.valueOf(fac.getLandRounded())),
-    WARPS("{warps}", (fac) -> String.valueOf(fac.getWarps().size())),
+    WARPS("{warps}", fac -> String.valueOf(fac.getWarps().size())),
     HEADER("{header}", (fac, fp) -> FactionsPlugin.getInstance().txt.titleize(fac.getTag(fp))),
-    POWER("{power}", (fac) -> String.valueOf(fac.getPowerRounded())),
+    POWER("{power}", fac -> String.valueOf(fac.getPowerRounded())),
-    MAX_POWER("{maxPower}", (fac) -> String.valueOf(fac.getPowerMaxRounded())),
+    MAX_POWER("{maxPower}", fac -> String.valueOf(fac.getPowerMaxRounded())),
-    POWER_BOOST("{power-boost}", (fac) -> {
+    POWER_BOOST("{power-boost}", fac -> {
         double powerBoost = fac.getPowerBoost();
         return (powerBoost == 0.0) ? "" : (powerBoost > 0.0 ? TL.COMMAND_SHOW_BONUS.toString() : TL.COMMAND_SHOW_PENALTY.toString() + powerBoost + ")");
     }),
-    LEADER("{leader}", (fac) -> {
+    LEADER("{leader}", fac -> {
         FPlayer fAdmin = fac.getFPlayerAdmin();
         return fAdmin == null ? "Server" : fAdmin.getName().substring(0, fAdmin.getName().length() > 14 ? 13 : fAdmin.getName().length());
     }),
-    JOINING("{joining}", (fac) -> (fac.getOpen() ? TL.COMMAND_SHOW_UNINVITED.toString() : TL.COMMAND_SHOW_INVITATION.toString())),
+    JOINING("{joining}", fac -> (fac.getOpen() ? TL.COMMAND_SHOW_UNINVITED.toString() : TL.COMMAND_SHOW_INVITATION.toString())),
     FACTION("{faction}", (Function<Faction, String>) Faction::getTag),
     FACTION_RELATION_COLOR("{faction-relation-color}", (fac, fp) -> fp == null ? "" : fp.getColorTo(fac).toString()),
-    //SHIELD_STATUS("{shield-status}",(fac) -> {
+    HOME_WORLD("{world}", fac -> fac.hasHome() ? fac.getHome().getWorld().getName() : Tag.isMinimalShow() ? null : "{ig}"),
-        //if(fac.isProtected() && fac.getShieldFrame() != null) return String.valueOf(TL.SHIELD_CURRENTLY_ENABLE);
+    RAIDABLE("{raidable}", fac -> {
-        //if(fac.getShieldFrame() == null) return String.valueOf(TL.SHIELD_NOT_SET);
-       // return TL.SHIELD_CURRENTLY_NOT_ENABLED.toString();
-    //}),
-    HOME_WORLD("{world}", (fac) -> fac.hasHome() ? fac.getHome().getWorld().getName() : Tag.isMinimalShow() ? null : "{ig}"),
-    RAIDABLE("{raidable}", (fac) -> {
         if (FactionsPlugin.getInstance().getConfig().getBoolean("hcf.raidable", false)) {
             boolean raidable = fac.getLandRounded() >= fac.getPowerRounded();
             String str = raidable ? TL.RAIDABLE_TRUE.toString() : TL.RAIDABLE_FALSE.toString();
@@ -57,37 +50,35 @@ public enum FactionTag implements Tag {
         return null;
     }),
 
-    ANNOUNCEMENT("{announcement}", (fac) -> {
+    ANNOUNCEMENT("{announcement}", fac -> String.valueOf(fac.getAnnouncements())),
-        return String.valueOf(fac.getAnnouncements());
+    PEACEFUL("{peaceful}", fac -> fac.isPeaceful() ? Conf.colorNeutral + TL.COMMAND_SHOW_PEACEFUL.toString() : ""),
-    }),
+    PERMANENT("permanent", fac -> fac.isPermanent() ? "permanent" : "{notPermanent}"), // no braces needed
-    PEACEFUL("{peaceful}", (fac) -> fac.isPeaceful() ? Conf.colorNeutral + TL.COMMAND_SHOW_PEACEFUL.toString() : ""),
+    LAND_VALUE("{land-value}", fac -> Econ.shouldBeUsed() ? Econ.moneyString(Econ.calculateTotalLandValue(fac.getLandRounded())) : Tag.isMinimalShow() ? null : TL.ECON_OFF.format("value")),
-    PERMANENT("permanent", (fac) -> fac.isPermanent() ? "permanent" : "{notPermanent}"), // no braces needed
-    LAND_VALUE("{land-value}", (fac) -> Econ.shouldBeUsed() ? Econ.moneyString(Econ.calculateTotalLandValue(fac.getLandRounded())) : Tag.isMinimalShow() ? null : TL.ECON_OFF.format("value")),
     DESCRIPTION("{description}", Faction::getDescription),
-    CREATE_DATE("{create-date}", (fac) -> TL.sdf.format(fac.getFoundedDate())),
+    CREATE_DATE("{create-date}", fac -> TL.sdf.format(fac.getFoundedDate())),
-    LAND_REFUND("{land-refund}", (fac) -> Econ.shouldBeUsed() ? Econ.moneyString(Econ.calculateTotalLandRefund(fac.getLandRounded())) : Tag.isMinimalShow() ? null : TL.ECON_OFF.format("refund")),
+    LAND_REFUND("{land-refund}", fac -> Econ.shouldBeUsed() ? Econ.moneyString(Econ.calculateTotalLandRefund(fac.getLandRounded())) : Tag.isMinimalShow() ? null : TL.ECON_OFF.format("refund")),
-    BANK_BALANCE("{faction-balance}", (fac) -> {
+    BANK_BALANCE("{faction-balance}", fac -> {
         if (Econ.shouldBeUsed()) {
             return Conf.bankEnabled ? Econ.moneyString(Econ.getBalance(fac.getAccountId())) : Tag.isMinimalShow() ? null : TL.ECON_OFF.format("balance");
         }
         return Tag.isMinimalShow() ? null : TL.ECON_OFF.format("balance");
     }),
-    TNT_BALANCE("{tnt-balance}", (fac) -> {
+    TNT_BALANCE("{tnt-balance}", fac -> {
         if (FactionsPlugin.instance.getConfig().getBoolean("ftnt.Enabled")) {
             return String.valueOf(fac.getTnt());
         }
         return Tag.isMinimalShow() ? null : "";
     }),
-    TNT_MAX("{tnt-max-balance}", (fac) -> {
+    TNT_MAX("{tnt-max-balance}", fac -> {
         if (FactionsPlugin.instance.getConfig().getBoolean("ftnt.Enabled")) {
             return String.valueOf(fac.getTntBankLimit());
         }
         return Tag.isMinimalShow() ? null : "";
     }),
 
-    ALLIES_COUNT("{allies}", (fac) -> String.valueOf(fac.getRelationCount(Relation.ALLY))),
+    ALLIES_COUNT("{allies}", fac -> String.valueOf(fac.getRelationCount(Relation.ALLY))),
-    ENEMIES_COUNT("{enemies}", (fac) -> String.valueOf(fac.getRelationCount(Relation.ENEMY))),
+    ENEMIES_COUNT("{enemies}", fac -> String.valueOf(fac.getRelationCount(Relation.ENEMY))),
-    TRUCES_COUNT("{truces}", (fac) -> String.valueOf(fac.getRelationCount(Relation.TRUCE))),
+    TRUCES_COUNT("{truces}", fac -> String.valueOf(fac.getRelationCount(Relation.TRUCE))),
     ONLINE_COUNT("{online}", (fac, fp) -> {
         if (fp != null && fp.isOnline()) {
             return String.valueOf(fac.getFPlayersWhereOnline(true, fp).size());
@@ -104,12 +95,12 @@ public enum FactionTag implements Tag {
             return String.valueOf(fac.getFPlayersWhereOnline(false).size());
         }
     }),
-    FACTION_STRIKES("{faction-strikes}", (fac) -> String.valueOf(fac.getStrikes())),
+    FACTION_STRIKES("{faction-strikes}", fac -> String.valueOf(fac.getStrikes())),
-    FACTION_POINTS("{faction-points}", (fac) -> String.valueOf(fac.getPoints())),
+    FACTION_POINTS("{faction-points}", fac -> String.valueOf(fac.getPoints())),
-    FACTION_SIZE("{members}", (fac) -> String.valueOf(fac.getFPlayers().size())),
+    FACTION_SIZE("{members}", fac -> String.valueOf(fac.getFPlayers().size())),
-    FACTION_KILLS("{faction-kills}", (fac) -> String.valueOf(fac.getKills())),
+    FACTION_KILLS("{faction-kills}", fac -> String.valueOf(fac.getKills())),
-    FACTION_DEATHS("{faction-deaths}", (fac) -> String.valueOf(fac.getDeaths())),
+    FACTION_DEATHS("{faction-deaths}", fac -> String.valueOf(fac.getDeaths())),
-    FACTION_BANCOUNT("{faction-bancount}", (fac) -> String.valueOf(fac.getBannedPlayers().size())),
+    FACTION_BANCOUNT("{faction-bancount}", fac -> String.valueOf(fac.getBannedPlayers().size())),
     ;
 
     private final String tag;

src/main/java/com/massivecraft/factions/tag/FancyTag.java

@@ -177,7 +177,7 @@ public enum FancyTag implements Tag {
 
     public List getMessage(String text, Faction faction, FPlayer player, Map<UUID, String> groupMap) {
         if (!this.foundInString(text)) {
-            return Collections.EMPTY_LIST; // We really, really shouldn't be here.
+            return Collections.emptyList(); // We really, really shouldn't be here.
         }
         return this.function.apply(faction, player, text.replace(this.getTag(), ""), groupMap);
     }

src/main/java/com/massivecraft/factions/util/AutoLeaveProcessTask.java

@@ -10,8 +10,8 @@ import java.util.logging.Level;
 
 public class AutoLeaveProcessTask extends BukkitRunnable {
 
-    private transient boolean readyToGo = false;
+    private transient boolean readyToGo;
-    private transient boolean finished = false;
+    private transient boolean finished;
     private transient ListIterator<FPlayer> iterator;
     private transient double toleranceMillis;
 

src/main/java/com/massivecraft/factions/util/ClipPlaceholderAPIManager.java

@@ -15,15 +15,12 @@ import org.bukkit.ChatColor;
 import org.bukkit.entity.Player;
 
 import java.lang.reflect.InvocationTargetException;
+import java.util.Arrays;
 import java.util.UUID;
 import java.util.logging.Level;
 
 public class ClipPlaceholderAPIManager extends PlaceholderExpansion implements Relational {
 
-    private static void logInvalid(String placeholder) {
-        FactionsPlugin.getInstance().getLogger().log(Level.INFO, "Invalid request through PlaceholderAPI for placeholder '" + placeholder + "'");
-    }
-
     // Identifier for this expansion
     @Override
     public String getIdentifier() {
@@ -217,7 +214,7 @@ public class ClipPlaceholderAPIManager extends PlaceholderExpansion implements R
             case "faction_relation_color":
                 return fPlayer.getColorTo(faction).toString();
             case "grace_time":
-                if (FactionsPlugin.getInstance().getTimerManager().graceTimer.getRemaining() >= 0) {
+                if(FactionsPlugin.getInstance().getTimerManager().graceTimer.getRemaining() >= 0) {
                     return String.valueOf(TimerManager.getRemaining(FactionsPlugin.getInstance().getTimerManager().graceTimer.getRemaining(), true));
                 } else {
                     return TL.GRACE_DISABLED_PLACEHOLDER.toString();
@@ -252,6 +249,10 @@ public class ClipPlaceholderAPIManager extends PlaceholderExpansion implements R
         return TL.PLACEHOLDERAPI_NULL.toString();
     }
 
+    private static void logInvalid(String placeholder) {
+        FactionsPlugin.getInstance().getLogger().log(Level.INFO, "Invalid request through PlaceholderAPI for placeholder '" + placeholder + "'");
+    }
+
     private int countOn(Faction f, Relation relation, Boolean status, FPlayer player) {
         int count = 0;
         for (Faction faction : Factions.getInstance().getAllFactions()) {

src/main/java/com/massivecraft/factions/util/Cooldown.java

@@ -3,6 +3,7 @@ package com.massivecraft.factions.util;
 import com.massivecraft.factions.FactionsPlugin;
 import org.bukkit.entity.Player;
 import org.bukkit.metadata.FixedMetadataValue;
+import org.bukkit.metadata.MetadataValue;
 
 import java.util.concurrent.TimeUnit;
 
@@ -18,7 +19,7 @@ public class Cooldown {
     }
 
     public static boolean isOnCooldown(Player player, String name) {
-        if (!player.hasMetadata(name) || player.getMetadata(name).size() <= 0) return false;
+        if (!player.hasMetadata(name) || player.getMetadata(name).isEmpty()) return false;
         long time = player.getMetadata(name).get(0).asLong();
         return (time > System.currentTimeMillis());
     }

src/main/java/com/massivecraft/factions/util/InventoryUtil.java

@@ -15,7 +15,7 @@ import java.io.IOException;
 public class InventoryUtil {
 
 
-    public static String InventoryToString(ItemStack[] items) throws IllegalStateException {
+    public static String InventoryToString(ItemStack[] items) {
         try {
             ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
             BukkitObjectOutputStream dataOutput = new BukkitObjectOutputStream(outputStream);

src/main/java/com/massivecraft/factions/util/MiscUtil.java

@@ -109,8 +109,6 @@ public class MiscUtil {
 
             switch (player.getRole()) {
                 case LEADER:
-                    admins.add(player);
-                    break;
                 case COLEADER:
                     admins.add(player);
                     break;

src/main/java/com/massivecraft/factions/util/RelationUtil.java

@@ -20,8 +20,6 @@ public class RelationUtil {
         }
 
         Faction myFaction = getFaction(me);
-//		if (myFaction == null) return that.describeTo(null); // no relation, but can show basic name or tag
-
         if (that instanceof Faction) {
             if (me instanceof FPlayer && myFaction == thatFaction) {
                 ret = TL.GENERIC_YOURFACTION.toString();

src/main/java/com/massivecraft/factions/util/SpiralTask.java

@@ -187,7 +187,6 @@ public abstract class SpiralTask implements Runnable {
 
     // for successful completion
     public void finish() {
-//		FactionsPlugin.getInstance().log("SpiralTask successfully completed!");
         this.stop();
     }
 

src/main/java/com/massivecraft/factions/util/VisualizeUtil.java

@@ -16,8 +16,7 @@ public class VisualizeUtil {
     }
 
     public static Set<Location> getPlayerLocations(UUID uuid) {
-        Set<Location> ret = playerLocations.computeIfAbsent(uuid, k -> new HashSet<>());
+        return playerLocations.computeIfAbsent(uuid, k -> new HashSet<>());
-        return ret;
     }
 
     @SuppressWarnings("deprecation")

src/main/java/com/massivecraft/factions/util/XMaterial.java

@@ -1,4 +1,5 @@
 package com.massivecraft.factions.util;
+
 /*
  * The MIT License (MIT)
  *
@@ -41,23 +42,30 @@ import java.util.*;
 import java.util.concurrent.TimeUnit;
 import java.util.regex.Pattern;
 
-/**
+/*
- * <b>XMaterial</b> - Data Values/Pre-flattening<br>
+ * References
- * 1.13 and above as priority.
+ *
- * <p>
+ * * * GitHub: https://github.com/CryptoMorin/XSeries/blob/master/XMaterial.java
- * This class is mainly designed to support ItemStacks.
+ * * XSeries: https://www.spigotmc.org/threads/378136/
- * If you want to use it on blocks you'll have to
- * use <a href="https://github.com/CryptoMorin/XSeries/blob/master/XBlock.java">XBlock</a>
- * <p>
  * Pre-flattening: https://minecraft.gamepedia.com/Java_Edition_data_values/Pre-flattening
  * Materials: https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Material.html
  * Materials (1.12): https://helpch.at/docs/1.12.2/index.html?org/bukkit/Material.html
  * Material IDs: https://minecraft-ids.grahamedgecombe.com/
  * Material Source Code: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/browse/src/main/java/org/bukkit/Material.java
  * XMaterial v1: https://www.spigotmc.org/threads/329630/
+ */
+
+/**
+ * <b>XMaterial</b> - Data Values/Pre-flattening<br>
+ * Supports 1.8-1.15<br>
+ * 1.13 and above as priority.
+ * <p>
+ * This class is mainly designed to support ItemStacks.
+ * If you want to use it on blocks you'll have to
+ * use <a href="https://github.com/CryptoMorin/XSeries/blob/master/XBlock.java">XBlock</a>
  *
  * @author Crypto Morin
- * @version 5.0.0
+ * @version 4.0.0
  * @see Material
  * @see ItemStack
  */
@@ -88,7 +96,6 @@ public enum XMaterial {
      */
     AIR,
     ALLIUM(2, "RED_ROSE"),
-    ANCIENT_DEBRIS("1.16"),
     ANDESITE(5, "STONE"),
     ANDESITE_SLAB,
     ANDESITE_STAIRS,
@@ -105,7 +112,6 @@ public enum XMaterial {
     BAMBOO_SAPLING("1.14"),
     BARREL("1.14", "CHEST", ""),
     BARRIER,
-    BASALT("1.16"),
     BAT_SPAWN_EGG(65, "MONSTER_EGG"),
     BEACON,
     BEDROCK,
@@ -138,12 +144,8 @@ public enum XMaterial {
     BIRCH_TRAPDOOR("TRAP_DOOR"),
     BIRCH_WALL_SIGN("SIGN_POST", "WALL_SIGN"),
     BIRCH_WOOD(2, "LOG"),
-    BLACKSTONE("1.16"),
-    BLACKSTONE_SLAB("1.16"),
-    BLACKSTONE_STAIRS("1.16"),
-    BLACKSTONE_WALL("1.16"),
     BLACK_BANNER("BANNER", "STANDING_BANNER"),
-    BLACK_BED(15, "BED_BLOCK", "BED"),
+    BLACK_BED(15, "BED", "BED_BLOCK"),
     BLACK_CARPET(15, "CARPET"),
     BLACK_CONCRETE(15, "CONCRETE"),
     BLACK_CONCRETE_POWDER(15, "CONCRETE_POWDER"),
@@ -159,8 +161,8 @@ public enum XMaterial {
     BLAZE_POWDER,
     BLAZE_ROD,
     BLAZE_SPAWN_EGG(61, "MONSTER_EGG"),
-    BLUE_BANNER(4, "BANNER", "STANDING_BANNER"),
+    BLUE_BANNER(11, "BANNER", "STANDING_BANNER"),
-    BLUE_BED(11, "BED_BLOCK", "BED"),
+    BLUE_BED(4, "BED", "BED_BLOCK"),
     BLUE_CARPET(11, "CARPET"),
     BLUE_CONCRETE(11, "CONCRETE"),
     BLUE_CONCRETE_POWDER(11, "CONCRETE_POWDER"),
@@ -171,8 +173,8 @@ public enum XMaterial {
     BLUE_SHULKER_BOX,
     BLUE_STAINED_GLASS(11, "STAINED_GLASS"),
     BLUE_STAINED_GLASS_PANE(11, "THIN_GLASS", "STAINED_GLASS_PANE"),
-    BLUE_TERRACOTTA(11, "HARD_CLAY", "STAINED_CLAY"),
+    BLUE_TERRACOTTA(11, "STAINED_CLAY"),
-    BLUE_WALL_BANNER(4, "WALL_BANNER"),
+    BLUE_WALL_BANNER(11, "WALL_BANNER"),
     BLUE_WOOL(11, "WOOL"),
     BONE,
     BONE_BLOCK,
@@ -193,7 +195,7 @@ public enum XMaterial {
     BRICK_STAIRS,
     BRICK_WALL,
     BROWN_BANNER(3, "BANNER", "STANDING_BANNER"),
-    BROWN_BED(12, "BED_BLOCK", "BED"),
+    BROWN_BED(12, "BED", "BED_BLOCK"),
     BROWN_CARPET(12, "CARPET"),
     BROWN_CONCRETE(12, "CONCRETE"),
     BROWN_CONCRETE_POWDER(12, "CONCRETE_POWDER"),
@@ -230,7 +232,6 @@ public enum XMaterial {
      */
     CAVE_AIR("AIR"),
     CAVE_SPIDER_SPAWN_EGG(59, "MONSTER_EGG"),
-    CHAIN("1.16"),
     CHAINMAIL_BOOTS,
     CHAINMAIL_CHESTPLATE,
     CHAINMAIL_HELMET,
@@ -242,8 +243,6 @@ public enum XMaterial {
     CHICKEN("RAW_CHICKEN"),
     CHICKEN_SPAWN_EGG(93, "MONSTER_EGG"),
     CHIPPED_ANVIL(1, "ANVIL"),
-    CHISELED_NETHER_BRICKS(1, "NETHER_BRICKS"),
-    CHISELED_POLISHED_BLACKSTONE("1.16", "POLISHED_BLACKSTONE"),
     CHISELED_QUARTZ_BLOCK(1, "QUARTZ_BLOCK"),
     CHISELED_RED_SANDSTONE(1, "RED_SANDSTONE"),
     CHISELED_SANDSTONE(1, "SANDSTONE"),
@@ -270,14 +269,7 @@ public enum XMaterial {
     COD_SPAWN_EGG("1.13", "MONSTER_EGG", ""),
     COMMAND_BLOCK("COMMAND"),
     COMMAND_BLOCK_MINECART("COMMAND_MINECART"),
-    /**
+    COMPARATOR("REDSTONE_COMPARATOR", "REDSTONE_COMPARATOR_ON", "REDSTONE_COMPARATOR_OFF"),
-     * Unlike redstone torch and redstone lamp... neither REDTONE_COMPARATOR_OFF nor REDSTONE_COMPARATOR_ON
-     * are items. REDSTONE_COMPARATOR is.
-     *
-     * @see #REDSTONE_TORCH
-     * @see #REDSTONE_LAMP
-     */
-    COMPARATOR("REDSTONE_COMPARATOR_OFF", "REDSTONE_COMPARATOR_ON", "REDSTONE_COMPARATOR"),
     COMPASS,
     COMPOSTER("1.14", "CAULDRON", ""),
     CONDUIT("1.13", "BEACON"),
@@ -291,38 +283,19 @@ public enum XMaterial {
     COOKIE,
     CORNFLOWER(4, "1.14", "BLUE_DYE", ""),
     COW_SPAWN_EGG(92, "MONSTER_EGG"),
-    CRACKED_NETHER_BRICKS(2, "NETHER_BRICKS"),
-    CRACKED_POLISHED_BLACKSTONE_BRICKS("1.16", "POLISHED_BLACKSTONE_BRICKS"),
     CRACKED_STONE_BRICKS(2, "SMOOTH_BRICK"),
     CRAFTING_TABLE("WORKBENCH"),
     CREEPER_BANNER_PATTERN,
     CREEPER_HEAD(4, "SKULL", "SKULL_ITEM"),
     CREEPER_SPAWN_EGG(50, "MONSTER_EGG"),
     CREEPER_WALL_HEAD(4, "SKULL", "SKULL_ITEM"),
-    CRIMSON_BUTTON("1.16"),
-    CRIMSON_DOOR("1.16"),
-    CRIMSON_FENCE("1.16"),
-    CRIMSON_FENCE_GATE("1.16"),
-    CRIMSON_FUNGUS("1.16"),
-    CRIMSON_HYPHAE("1.16"),
-    CRIMSON_NYLIUM("1.16"),
-    CRIMSON_PLANKS("1.16"),
-    CRIMSON_PRESSURE_PLATE("1.16"),
-    CRIMSON_ROOTS("1.16"),
-    CRIMSON_SIGN("1.16"),
-    CRIMSON_SLAB("1.16"),
-    CRIMSON_STAIRS("1.16"),
-    CRIMSON_STEM("1.16"),
-    CRIMSON_TRAPDOOR("1.16"),
-    CRIMSON_WALL_SIGN("1.16"),
     CROSSBOW,
-    CRYING_OBSIDIAN("1.16"),
     CUT_RED_SANDSTONE("1.13"),
     CUT_RED_SANDSTONE_SLAB("STONE_SLAB2"),
     CUT_SANDSTONE("1.13"),
     CUT_SANDSTONE_SLAB("STEP"),
     CYAN_BANNER(6, "BANNER", "STANDING_BANNER"),
-    CYAN_BED(9, "BED_BLOCK", "BED"),
+    CYAN_BED(9, "BED", "BED_BLOCK"),
     CYAN_CARPET(9, "CARPET"),
     CYAN_CONCRETE(9, "CONCRETE"),
     CYAN_CONCRETE_POWDER(9, "CONCRETE_POWDER"),
@@ -341,13 +314,13 @@ public enum XMaterial {
     DARK_OAK_DOOR("DARK_OAK_DOOR_ITEM"),
     DARK_OAK_FENCE,
     DARK_OAK_FENCE_GATE,
-    DARK_OAK_LEAVES(4, "LEAVES", "LEAVES_2"),
+    DARK_OAK_LEAVES(1, "LEAVES", "LEAVES_2"),
     DARK_OAK_LOG(1, "LOG", "LOG_2"),
     DARK_OAK_PLANKS(5, "WOOD"),
     DARK_OAK_PRESSURE_PLATE("WOOD_PLATE"),
     DARK_OAK_SAPLING(5, "SAPLING"),
     DARK_OAK_SIGN("SIGN"),
-    DARK_OAK_SLAB(5, "WOOD_STEP", "WOODEN_SLAB", "WOOD_DOUBLE_STEP"),
+    DARK_OAK_SLAB("WOOD_STEP", "WOODEN_SLAB", "WOOD_DOUBLE_STEP"),
     DARK_OAK_STAIRS,
     DARK_OAK_TRAPDOOR("TRAP_DOOR"),
     DARK_OAK_WALL_SIGN("SIGN_POST", "WALL_SIGN"),
@@ -429,7 +402,7 @@ public enum XMaterial {
     END_ROD("1.9", "BLAZE_ROD", ""),
     END_STONE("ENDER_STONE"),
     END_STONE_BRICKS("END_BRICKS"),
-    END_STONE_BRICK_SLAB(6, "STEP"),
+    END_STONE_BRICK_SLAB(4, "STEP"),
     END_STONE_BRICK_STAIRS("SMOOTH_STAIRS"),
     END_STONE_BRICK_WALL,
     EVOKER_SPAWN_EGG(34, "MONSTER_EGG"),
@@ -437,12 +410,7 @@ public enum XMaterial {
     FARMLAND("SOIL"),
     FEATHER,
     FERMENTED_SPIDER_EYE,
-    FERN(1, "LONG_GRASS"),
+    FERN(2, "LONG_GRASS"),
-    /**
-     * For some reasons filled map items are really special.
-     * Their data value starts from 0 and every time a player
-     * creates a new map that maps data value increases.
-     */
     FILLED_MAP("MAP"),
     FIRE,
     FIREWORK_ROCKET("FIREWORK"),
@@ -499,7 +467,7 @@ public enum XMaterial {
     GRASS_PATH,
     GRAVEL,
     GRAY_BANNER(8, "BANNER", "STANDING_BANNER"),
-    GRAY_BED(7, "BED_BLOCK", "BED"),
+    GRAY_BED(7, "BED", "BED_BLOCK"),
     GRAY_CARPET(7, "CARPET"),
     GRAY_CONCRETE(7, "CONCRETE"),
     GRAY_CONCRETE_POWDER(7, "CONCRETE_POWDER"),
@@ -512,7 +480,7 @@ public enum XMaterial {
     GRAY_WALL_BANNER(8, "WALL_BANNER"),
     GRAY_WOOL(7, "WOOL"),
     GREEN_BANNER(2, "BANNER", "STANDING_BANNER"),
-    GREEN_BED(13, "BED_BLOCK", "BED"),
+    GREEN_BED(13, "BED", "BED_BLOCK"),
     GREEN_CARPET(13, "CARPET"),
     GREEN_CONCRETE(13, "CONCRETE"),
     GREEN_CONCRETE_POWDER(13, "CONCRETE_POWDER"),
@@ -530,7 +498,6 @@ public enum XMaterial {
     HAY_BLOCK,
     HEART_OF_THE_SEA("1.13"),
     HEAVY_WEIGHTED_PRESSURE_PLATE("IRON_PLATE"),
-    HOGLIN_SPAWN_EGG("1.16", "MONSTER_EGG"),
     HONEYCOMB("1.15"),
     HONEYCOMB_BLOCK("1.15"),
     HONEY_BLOCK("1.15", "SLIME_BLOCK", ""),
@@ -608,8 +575,8 @@ public enum XMaterial {
     LEATHER_LEGGINGS,
     LECTERN("1.14", "BOOKSHELF", ""),
     LEVER,
-    LIGHT_BLUE_BANNER(12, "BANNER", "STANDING_BANNER"),
+    LIGHT_BLUE_BANNER(3, "BANNER", "STANDING_BANNER"),
-    LIGHT_BLUE_BED(3, "BED_BLOCK", "BED"),
+    LIGHT_BLUE_BED(3, "BED", "BED_BLOCK"),
     LIGHT_BLUE_CARPET(3, "CARPET"),
     LIGHT_BLUE_CONCRETE(3, "CONCRETE"),
     LIGHT_BLUE_CONCRETE_POWDER(3, "CONCRETE_POWDER"),
@@ -622,16 +589,16 @@ public enum XMaterial {
     LIGHT_BLUE_WALL_BANNER(12, "WALL_BANNER", "BANNER", "STANDING_BANNER"),
     LIGHT_BLUE_WOOL(3, "WOOL"),
     LIGHT_GRAY_BANNER(7, "BANNER", "STANDING_BANNER"),
-    LIGHT_GRAY_BED(8, "BED_BLOCK", "BED"),
+    LIGHT_GRAY_BED(8, "BED", "BED_BLOCK"),
     LIGHT_GRAY_CARPET(8, "CARPET"),
     LIGHT_GRAY_CONCRETE(8, "CONCRETE"),
     LIGHT_GRAY_CONCRETE_POWDER(8, "CONCRETE_POWDER"),
     LIGHT_GRAY_DYE(7, "INK_SACK"),
     /**
-     * Renamed to SILVER_GLAZED_TERRACOTTA in 1.12
+     * Renamed to SILVER_GLAZED_TERRACOTTA in 1.13
      * Renamed to LIGHT_GRAY_GLAZED_TERRACOTTA in 1.14
      */
-    LIGHT_GRAY_GLAZED_TERRACOTTA("1.12", "HARD_CLAY", "STAINED_CLAY", "LIGHT_GRAY_TERRACOTTA", "SILVER_GLAZED_TERRACOTTA"),
+    LIGHT_GRAY_GLAZED_TERRACOTTA(8, "1.12", "HARD_CLAY", "STAINED_CLAY", "LIGHT_GRAY_TERRACOTTA", "SILVER_GLAZED_TERRACOTTA"),
     LIGHT_GRAY_SHULKER_BOX("SILVER_SHULKER_BOX"),
     LIGHT_GRAY_STAINED_GLASS(8, "STAINED_GLASS"),
     LIGHT_GRAY_STAINED_GLASS_PANE(8, "THIN_GLASS", "STAINED_GLASS_PANE"),
@@ -643,7 +610,7 @@ public enum XMaterial {
     LILY_OF_THE_VALLEY(15, "1.14", "WHITE_DYE", ""),
     LILY_PAD("WATER_LILY"),
     LIME_BANNER(10, "BANNER", "STANDING_BANNER"),
-    LIME_BED(5, "BED_BLOCK", "BED"),
+    LIME_BED(5, "BED", "BED_BLOCK"),
     LIME_CARPET(5, "CARPET"),
     LIME_CONCRETE(5, "CONCRETE"),
     LIME_CONCRETE_POWDER(5, "CONCRETE_POWDER"),
@@ -657,10 +624,9 @@ public enum XMaterial {
     LIME_WOOL(5, "WOOL"),
     LINGERING_POTION,
     LLAMA_SPAWN_EGG(103, "MONSTER_EGG"),
-    LODESTONE("1.16"),
     LOOM("1.14"),
     MAGENTA_BANNER(13, "BANNER", "STANDING_BANNER"),
-    MAGENTA_BED(2, "BED_BLOCK", "BED"),
+    MAGENTA_BED(2, "BED", "BED_BLOCK"),
     MAGENTA_CARPET(2, "CARPET"),
     MAGENTA_CONCRETE(2, "CONCRETE"),
     MAGENTA_CONCRETE_POWDER(2, "CONCRETE_POWDER"),
@@ -675,13 +641,6 @@ public enum XMaterial {
     MAGMA_BLOCK("1.10", "MAGMA"),
     MAGMA_CREAM,
     MAGMA_CUBE_SPAWN_EGG(62, "MONSTER_EGG"),
-    /**
-     * Adding this to the duplicated list will give you a filled map
-     * for 1.13+ versions and removing it from duplicated list will
-     * still give you a filled map in -1.12 versions.
-     * Since higher versions are our priority I'll keep 1.13+ support
-     * until I can come up with something to fix it.
-     */
     MAP("EMPTY_MAP"),
     MELON("MELON_BLOCK"),
     MELON_SEEDS,
@@ -696,7 +655,7 @@ public enum XMaterial {
     MOSSY_COBBLESTONE_STAIRS,
     MOSSY_COBBLESTONE_WALL(1, "COBBLE_WALL", "COBBLESTONE_WALL"),
     MOSSY_STONE_BRICKS(1, "SMOOTH_BRICK"),
-    MOSSY_STONE_BRICK_SLAB(5, "STEP"),
+    MOSSY_STONE_BRICK_SLAB(4, "STEP"),
     MOSSY_STONE_BRICK_STAIRS("SMOOTH_STAIRS"),
     MOSSY_STONE_BRICK_WALL,
     MOVING_PISTON("PISTON_BASE", "PISTON_MOVING_PIECE"),
@@ -719,29 +678,15 @@ public enum XMaterial {
     MYCELIUM("MYCEL"),
     NAME_TAG,
     NAUTILUS_SHELL("1.13"),
-    NETHERITE_AXE("1.16"),
-    NETHERITE_BLOCK("1.16"),
-    NETHERITE_BOOTS("1.16"),
-    NETHERITE_CHESTPLATE("1.16"),
-    NETHERITE_HELMET("1.16"),
-    NETHERITE_HOE("1.16"),
-    NETHERITE_INGOT("1.16"),
-    NETHERITE_LEGGINGS("1.16"),
-    NETHERITE_PICKAXE("1.16"),
-    NETHERITE_SCRAP("1.16"),
-    NETHERITE_SHOVEL("1.16"),
-    NETHERITE_SWORD("1.16"),
     NETHERRACK,
     NETHER_BRICK("NETHER_BRICK_ITEM"),
     NETHER_BRICKS("NETHER_BRICK"),
     NETHER_BRICK_FENCE("NETHER_FENCE"),
-    NETHER_BRICK_SLAB(6, "STEP"),
+    NETHER_BRICK_SLAB(4, "STEP"),
     NETHER_BRICK_STAIRS,
     NETHER_BRICK_WALL,
-    NETHER_GOLD_ORE("1.16"),
     NETHER_PORTAL("PORTAL"),
     NETHER_QUARTZ_ORE("QUARTZ_ORE"),
-    NETHER_SPROUTS("1.16"),
     NETHER_STAR,
     /**
      * Just like mentioned in https://minecraft.gamepedia.com/Nether_Wart
@@ -771,7 +716,7 @@ public enum XMaterial {
     OBSIDIAN,
     OCELOT_SPAWN_EGG(98, "MONSTER_EGG"),
     ORANGE_BANNER(14, "BANNER", "STANDING_BANNER"),
-    ORANGE_BED(1, "BED_BLOCK", "BED"),
+    ORANGE_BED(1, "BED", "BED_BLOCK"),
     ORANGE_CARPET(1, "CARPET"),
     ORANGE_CONCRETE(1, "CONCRETE"),
     ORANGE_CONCRETE_POWDER(1, "CONCRETE_POWDER"),
@@ -797,7 +742,7 @@ public enum XMaterial {
     PIG_SPAWN_EGG(90, "MONSTER_EGG"),
     PILLAGER_SPAWN_EGG("1.14"),
     PINK_BANNER(9, "BANNER", "STANDING_BANNER"),
-    PINK_BED(6, "BED_BLOCK", "BED"),
+    PINK_BED(6, "BED", "BED_BLOCK"),
     PINK_CARPET(6, "CARPET"),
     PINK_CONCRETE(6, "CONCRETE"),
     PINK_CONCRETE_POWDER(6, "CONCRETE_POWDER"),
@@ -808,7 +753,7 @@ public enum XMaterial {
     PINK_STAINED_GLASS_PANE(6, "THIN_GLASS", "STAINED_GLASS_PANE"),
     PINK_TERRACOTTA(6, "HARD_CLAY", "STAINED_CLAY"),
     PINK_TULIP(7, "RED_ROSE"),
-    PINK_WALL_BANNER(9, "WALL_BANNER"),
+    PINK_WALL_BANNER(14, "WALL_BANNER"),
     PINK_WOOL(6, "WOOL"),
     PISTON("PISTON_BASE"),
     PISTON_HEAD("PISTON_EXTENSION"),
@@ -820,17 +765,6 @@ public enum XMaterial {
     POLISHED_ANDESITE(6, "STONE"),
     POLISHED_ANDESITE_SLAB,
     POLISHED_ANDESITE_STAIRS,
-    POLISHED_BASALT("1.16"),
-    POLISHED_BLACKSTONE("1.16"),
-    POLISHED_BLACKSTONE_BRICKS("1.16"),
-    POLISHED_BLACKSTONE_BRICK_SLAB("1.16"),
-    POLISHED_BLACKSTONE_BRICK_STAIRS("1.16"),
-    POLISHED_BLACKSTONE_BRICK_WALL("1.16"),
-    POLISHED_BLACKSTONE_BUTTON("1.16"),
-    POLISHED_BLACKSTONE_PRESSURE_PLATE("1.16"),
-    POLISHED_BLACKSTONE_SLAB("1.16"),
-    POLISHED_BLACKSTONE_STAIRS("1.16"),
-    POLISHED_BLACKSTONE_WALL("1.16"),
     POLISHED_DIORITE(4, "STONE"),
     POLISHED_DIORITE_SLAB,
     POLISHED_DIORITE_STAIRS,
@@ -886,7 +820,7 @@ public enum XMaterial {
     PUMPKIN_SEEDS,
     PUMPKIN_STEM,
     PURPLE_BANNER(5, "BANNER", "STANDING_BANNER"),
-    PURPLE_BED(10, "BED_BLOCK", "BED"),
+    PURPLE_BED(10, "BED", "BED_BLOCK"),
     PURPLE_CARPET(10, "CARPET"),
     PURPLE_CONCRETE(10, "CONCRETE"),
     PURPLE_CONCRETE_POWDER(10, "CONCRETE_POWDER"),
@@ -916,34 +850,17 @@ public enum XMaterial {
     RAVAGER_SPAWN_EGG("1.14"),
     REDSTONE,
     REDSTONE_BLOCK,
-    /**
+    REDSTONE_LAMP("REDSTONE_LAMP_OFF", "REDSTONE_LAMP_ON"),
-     * Unlike redstone torch, REDSTONE_LAMP_ON isn't an item.
-     * The name is just here on the list for matching.
-     *
-     * @see #REDSTONE_TORCH
-     */
-    REDSTONE_LAMP("REDSTONE_LAMP_ON", "REDSTONE_LAMP_OFF"),
     REDSTONE_ORE("GLOWING_REDSTONE_ORE"),
-    /**
+    REDSTONE_TORCH("REDSTONE_TORCH_ON", "REDSTONE_TORCH_OFF"),
-     * REDSTONE_TORCH_OFF isn't an item, but a block.
+    REDSTONE_WALL_TORCH(1, "REDSTONE_TORCH_ON", "REDSTONE_TORCH_OFF"),
-     * But REDSTONE_TORCH_ON is the item.
-     * The name is just here on the list for matching.
-     */
-    REDSTONE_TORCH("REDSTONE_TORCH_OFF", "REDSTONE_TORCH_ON"),
-    REDSTONE_WALL_TORCH,
     REDSTONE_WIRE,
     RED_BANNER(1, "BANNER", "STANDING_BANNER"),
-    /**
+    RED_BED(14, "BED", "BED_BLOCK"),
-     * Data value 14 or 0
-     */
-    RED_BED(0, "BED_BLOCK", "BED"),
     RED_CARPET(14, "CARPET"),
     RED_CONCRETE(14, "CONCRETE"),
     RED_CONCRETE_POWDER(14, "CONCRETE_POWDER"),
-    /**
+    RED_DYE(1, "ROSE_RED"),
-     * Data value 0 or 1?
-     */
-    RED_DYE(0, "INK_SACK", "ROSE_RED"),
     RED_GLAZED_TERRACOTTA(14, "1.12", "HARD_CLAY", "STAINED_CLAY", "RED_TERRACOTTA"),
     RED_MUSHROOM,
     RED_MUSHROOM_BLOCK("RED_MUSHROOM", "HUGE_MUSHROOM_2"),
@@ -965,7 +882,6 @@ public enum XMaterial {
     RED_WOOL(14, "WOOL"),
     REPEATER("DIODE", "DIODE_BLOCK_ON", "DIODE_BLOCK_OFF"),
     REPEATING_COMMAND_BLOCK("COMMAND", "COMMAND_REPEATING"),
-    RESPAWN_ANCHOR("1.16"),
     ROSE_BUSH(4, "DOUBLE_PLANT"),
     ROTTEN_FLESH,
     SADDLE,
@@ -985,7 +901,6 @@ public enum XMaterial {
     SHEARS,
     SHEEP_SPAWN_EGG(91, "MONSTER_EGG"),
     SHIELD,
-    SHROOMLIGHT("1.16"),
     SHULKER_BOX("PURPLE_SHULKER_BOX"),
     SHULKER_SHELL,
     SHULKER_SPAWN_EGG(69, "MONSTER_EGG"),
@@ -1014,13 +929,7 @@ public enum XMaterial {
     SNOW,
     SNOWBALL("SNOW_BALL"),
     SNOW_BLOCK,
-    SOUL_CAMPFIRE("1.16"),
-    SOUL_FIRE("1.16"),
-    SOUL_LANTERN("1.16"),
     SOUL_SAND,
-    SOUL_SOIL("1.16"),
-    SOUL_TORCH("1.16"),
-    SOUL_WALL_TORCH("1.16"),
     SPAWNER("MOB_SPAWNER"),
     SPECTRAL_ARROW("1.9", "ARROW", ""),
     SPIDER_EYE,
@@ -1067,8 +976,6 @@ public enum XMaterial {
     STRIPPED_ACACIA_WOOD("LOG_2"),
     STRIPPED_BIRCH_LOG(2, "LOG"),
     STRIPPED_BIRCH_WOOD(2, "LOG"),
-    STRIPPED_CRIMSON_HYPHAE("1.16"),
-    STRIPPED_CRIMSON_STEM("1.16"),
     STRIPPED_DARK_OAK_LOG("LOG"),
     STRIPPED_DARK_OAK_WOOD("LOG"),
     STRIPPED_JUNGLE_LOG(3, "LOG"),
@@ -1077,8 +984,6 @@ public enum XMaterial {
     STRIPPED_OAK_WOOD("LOG"),
     STRIPPED_SPRUCE_LOG(1, "LOG"),
     STRIPPED_SPRUCE_WOOD(1, "LOG"),
-    STRIPPED_WARPED_HYPHAE("1.16"),
-    STRIPPED_WARPED_STEM("1.16"),
     STRUCTURE_BLOCK,
     /**
      * Originally developers used barrier blocks for its purpose.
@@ -1097,7 +1002,6 @@ public enum XMaterial {
     SWEET_BERRY_BUSH("1.14", "GRASS", ""),
     TALL_GRASS(2, "DOUBLE_PLANT"),
     TALL_SEAGRASS(2, "1.13", "TALL_GRASS", ""),
-    TARGET("1.16"),
     TERRACOTTA("HARD_CLAY"),
     TIPPED_ARROW("1.9", "ARROW", ""),
     TNT,
@@ -1119,8 +1023,6 @@ public enum XMaterial {
     TURTLE_EGG("1.13", "EGG", ""),
     TURTLE_HELMET("1.13", "IRON_HELMET", ""),
     TURTLE_SPAWN_EGG("1.13", "CHICKEN_SPAWN_EGG", ""),
-    TWISTING_VINES("1.16"),
-    TWISTING_VINES_PLANT("1.16"),
     VEX_SPAWN_EGG(35, "MONSTER_EGG"),
     VILLAGER_SPAWN_EGG(120, "MONSTER_EGG"),
     VINDICATOR_SPAWN_EGG(36, "MONSTER_EGG"),
@@ -1133,24 +1035,6 @@ public enum XMaterial {
     VOID_AIR("AIR"),
     WALL_TORCH("TORCH"),
     WANDERING_TRADER_SPAWN_EGG("1.14", "VILLAGER_SPAWN_EGG", ""),
-    WARPED_BUTTON("1.16"),
-    WARPED_DOOR("1.16"),
-    WARPED_FENCE("1.16"),
-    WARPED_FENCE_GATE("1.16"),
-    WARPED_FUNGUS("1.16"),
-    WARPED_FUNGUS_ON_A_STICK("1.16"),
-    WARPED_HYPHAE("1.16"),
-    WARPED_NYLIUM("1.16"),
-    WARPED_PLANKS("1.16"),
-    WARPED_PRESSURE_PLATE("1.16"),
-    WARPED_ROOTS("1.16"),
-    WARPED_SIGN("1.16"),
-    WARPED_SLAB("1.16"),
-    WARPED_STAIRS("1.16"),
-    WARPED_STEM("1.16"),
-    WARPED_TRAPDOOR("1.16"),
-    WARPED_WALL_SIGN("1.16"),
-    WARPED_WART_BLOCK("1.16"),
     /**
      * This is used for blocks only.
      * In 1.13- WATER will turn into STATIONARY_WATER after it finished spreading.
@@ -1160,8 +1044,6 @@ public enum XMaterial {
      */
     WATER("STATIONARY_WATER"),
     WATER_BUCKET,
-    WEEPING_VINES("1.16"),
-    WEEPING_VINES_PLANT("1.16"),
     WET_SPONGE(1, "SPONGE"),
     /**
      * Wheat is a known material in pre-1.13
@@ -1170,16 +1052,16 @@ public enum XMaterial {
     WHEAT("CROPS"),
     WHEAT_SEEDS("SEEDS"),
     WHITE_BANNER(15, "BANNER", "STANDING_BANNER"),
-    WHITE_BED("BED_BLOCK", "BED"),
+    WHITE_BED("BED", "BED_BLOCK"),
     WHITE_CARPET("CARPET"),
     WHITE_CONCRETE("CONCRETE"),
     WHITE_CONCRETE_POWDER("CONCRETE_POWDER"),
     WHITE_DYE(15, "1.14", "INK_SACK", "BONE_MEAL"),
-    WHITE_GLAZED_TERRACOTTA("1.12", "HARD_CLAY", "STAINED_CLAY"),
+    WHITE_GLAZED_TERRACOTTA("1.12", "HARD_CLAY", "STAINED_CLAY", "WHITE_TERRACOTTA"),
     WHITE_SHULKER_BOX,
     WHITE_STAINED_GLASS("STAINED_GLASS"),
     WHITE_STAINED_GLASS_PANE("THIN_GLASS", "STAINED_GLASS_PANE"),
-    WHITE_TERRACOTTA("HARD_CLAY", "STAINED_CLAY", "TERRACOTTA"),
+    WHITE_TERRACOTTA("HARD_CLAY", "TERRACOTTA"),
     WHITE_TULIP(6, "RED_ROSE"),
     WHITE_WALL_BANNER(15, "WALL_BANNER"),
     WHITE_WOOL("WOOL"),
@@ -1197,7 +1079,7 @@ public enum XMaterial {
     WRITABLE_BOOK("BOOK_AND_QUILL"),
     WRITTEN_BOOK,
     YELLOW_BANNER(11, "BANNER", "STANDING_BANNER"),
-    YELLOW_BED(4, "BED_BLOCK", "BED"),
+    YELLOW_BED(4, "BED", "BED_BLOCK"),
     YELLOW_CARPET(4, "CARPET"),
     YELLOW_CONCRETE(4, "CONCRETE"),
     YELLOW_CONCRETE_POWDER(4, "CONCRETE_POWDER"),
@@ -1214,8 +1096,7 @@ public enum XMaterial {
     ZOMBIE_PIGMAN_SPAWN_EGG(57, "MONSTER_EGG"),
     ZOMBIE_SPAWN_EGG(54, "MONSTER_EGG"),
     ZOMBIE_VILLAGER_SPAWN_EGG(27, "MONSTER_EGG"),
-    ZOMBIE_WALL_HEAD(2, "SKULL", "SKULL_ITEM"),
+    ZOMBIE_WALL_HEAD(2, "SKULL", "SKULL_ITEM");
-    ZOMBIFIED_PIGLIN_SPAWN_EGG(54, "MONSTER_EGG");
 
 
     /**
@@ -1251,26 +1132,16 @@ public enum XMaterial {
      * @since 3.0.0
      */
     @SuppressWarnings("UnstableApiUsage")
-    private static final ImmutableMap<XMaterial, XMaterial> duplicated = Maps.immutableEnumMap(ImmutableMap.<XMaterial, XMaterial>builder()
+    private static final ImmutableMap<XMaterial, XMaterial> DUPLICATED = Maps.immutableEnumMap(ImmutableMap.<XMaterial, XMaterial>builder()
             .put(MELON, MELON_SLICE)
             .put(CARROT, CARROTS)
             .put(POTATO, POTATOES)
             .put(BEETROOT, BEETROOTS)
             .put(BROWN_MUSHROOM, BROWN_MUSHROOM_BLOCK)
             .put(BRICK, BRICKS)
+            .put(RED_MUSHROOM, RED_MUSHROOM_BLOCK)
+            .put(MAP, FILLED_MAP)
             .put(NETHER_BRICK, NETHER_BRICKS)
-
-            // Illegal Elements
-            // Since both 1.12 and 1.13 have <type>_DOOR XMaterial will use it
-            // for 1.12 to parse the material, but it needs <type>_DOOR_ITEM.
-            // We'll trick XMaterial into thinking this needs to be parsed
-            // using the old methods.
-            .put(DARK_OAK_DOOR, DARK_OAK_DOOR)
-            .put(ACACIA_DOOR, ACACIA_DOOR)
-            .put(BIRCH_DOOR, BIRCH_DOOR)
-            .put(JUNGLE_DOOR, JUNGLE_DOOR)
-            .put(SPRUCE_DOOR, SPRUCE_DOOR)
-
             .build()
     );
     /*
@@ -1361,7 +1232,7 @@ public enum XMaterial {
      * An invocation of this method yields the cached result from the expression:
      * <p>
      * <blockquote>
-     * {@link #supports(int) 13}}
+     * {@link #supports(int 13)}}
      * </blockquote>
      *
      * @return true if 1.13 or higher.
@@ -1412,14 +1283,13 @@ public enum XMaterial {
     @Nullable
     private static XMaterial requestOldXMaterial(@Nonnull String name, byte data) {
         String holder = name + data;
-        XMaterial cache = NAME_CACHE.getIfPresent(holder);
+        XMaterial material = NAME_CACHE.getIfPresent(holder);
-        if (cache != null) return cache;
+        if (material != null) return material;
 
-        for (XMaterial material : VALUES) {
+        for (XMaterial materials : VALUES) {
-            // Not using material.name().equals(name) check is intended.
+            if ((data == -1 || data == materials.data) && materials.anyMatchLegacy(name)) {
-            if ((data == -1 || data == material.data) && material.anyMatchLegacy(name)) {
+                NAME_CACHE.put(holder, materials);
-                NAME_CACHE.put(holder, material);
+                return materials;
-                return material;
             }
         }
 
@@ -1450,15 +1320,37 @@ public enum XMaterial {
     /**
      * Parses the given material name as an XMaterial with unspecified data value.
      *
-     * @see #matchXMaterialWithData(String)
+     * @see #matchXMaterial(String, byte)
      * @since 2.0.0
      */
     @Nonnull
     public static Optional<XMaterial> matchXMaterial(@Nonnull String name) {
+        return matchXMaterial(name, (byte) -1);
+    }
+
+    /**
+     * Parses the given material name as an XMaterial.
+     * Can also be used like: <b>MATERIAL:DATA</b>
+     * <p>
+     * <b>Examples</b>
+     * <pre>
+     *     INK_SACK:1 -> RED_DYE
+     *     WOOL, 14  -> RED_WOOL
+     * </pre>
+     *
+     * @see #matchDefinedXMaterial(String, byte)
+     * @see #matchXMaterial(ItemStack)
+     * @since 2.0.0
+     */
+    @Nonnull
+    public static Optional<XMaterial> matchXMaterial(@Nonnull String name, byte data) {
         Validate.notEmpty(name, "Cannot match a material with null or empty material name");
         Optional<XMaterial> oldMatch = matchXMaterialWithData(name);
         if (oldMatch.isPresent()) return oldMatch;
-        return matchDefinedXMaterial(format(name), (byte) -1);
+
+        // -1 Determines whether the item's data value is unknown and only the name is given.
+        // Checking if the item is damageable won't do anything as the data is not going to be checked in requestOldMaterial anyway.
+        return matchDefinedXMaterial(format(name), data);
     }
 
     /**
@@ -1468,8 +1360,8 @@ public enum XMaterial {
      * <p>
      * <b>Examples</b>
      * <p><pre>
-     *     {@code INK_SACK:1 -> RED_DYE}
+     *     INK_SACK:1 -> RED_DYE
-     *     {@code WOOL, 14  -> RED_WOOL}
+     *     WOOL, 14  -> RED_WOOL
      * </pre>
      *
      * @param name the material string that consists of the material name, data and separator character.
@@ -1502,7 +1394,7 @@ public enum XMaterial {
     public static XMaterial matchXMaterial(@Nonnull Material material) {
         Objects.requireNonNull(material, "Cannot match null material");
         return matchDefinedXMaterial(material.name(), (byte) -1)
-                .orElseThrow(() -> new IllegalArgumentException("Unsupported Material With No Bytes: " + material.name()));
+                .orElseThrow(() -> new IllegalArgumentException("Unsupported Material: " + material));
     }
 
     /**
@@ -1519,10 +1411,9 @@ public enum XMaterial {
     public static XMaterial matchXMaterial(@Nonnull ItemStack item) {
         Objects.requireNonNull(item, "Cannot match null ItemStack");
         String material = item.getType().name();
-        byte data = (byte) (ISFLAT || isDamageable(material) ? 0 : item.getDurability());
+        return matchDefinedXMaterial(material,
-
+                isDamageable(material) ? (byte) 0 : (byte) item.getDurability())
-        return matchDefinedXMaterial(material, data)
+                .orElseThrow(() -> new IllegalArgumentException("Unsupported Material: " + material));
-                .orElseThrow(() -> new IllegalArgumentException("Unsupported Material: " + material + " (" + data + ')'));
     }
 
     /**
@@ -1532,6 +1423,7 @@ public enum XMaterial {
      * @param name the formatted name of the material.
      * @param data the data value of the material.
      * @return an XMaterial (with the same data value if specified)
+     * @see #matchXMaterial(String, byte)
      * @see #matchXMaterial(Material)
      * @see #matchXMaterial(int, byte)
      * @see #matchXMaterial(ItemStack)
@@ -1544,7 +1436,7 @@ public enum XMaterial {
         // Do basic number and boolean checks before accessing more complex enum stuff.
         // Maybe we can simplify (ISFLAT || !duplicated) with the (!ISFLAT && duplicated) under it to save a few nanoseconds?
         // if (!Boolean.valueOf(Boolean.getBoolean(Boolean.TRUE.toString())).equals(Boolean.FALSE.booleanValue())) return null;
-        if (data <= 0 && !duplicated) {
+        if (data <= 0 && (ISFLAT || !duplicated)) {
             // Apparently the transform method is more efficient than toJavaUtil()
             // toJavaUtil isn't even supported in older versions.
             Optional<XMaterial> xMat = Enums.getIfPresent(XMaterial.class, name).transform(Optional::of).or(Optional.empty());
@@ -1555,20 +1447,8 @@ public enum XMaterial {
         // I've concluded that this is just an infinite loop that keeps
         // going around the Singular Form and the Plural Form materials. A waste of brain cells and a waste of time.
         // This solution works just fine anyway.
-        XMaterial xMat = requestOldXMaterial(name, data);
+        if (!ISFLAT && duplicated) return Optional.ofNullable(requestDuplicatedXMaterial(name, data));
-        if (xMat == null) {
+        return Optional.ofNullable(requestOldXMaterial(name, data));
-            // Special case. Refer to FILLED_MAP for more info.
-            if (data > 0 && name.endsWith("MAP")) return Optional.of(FILLED_MAP);
-            return Optional.empty();
-        }
-
-        if (!ISFLAT && duplicated && xMat.name().charAt(xMat.name().length() - 1) == 'S') {
-            // A solution for XMaterial Paradox.
-            // Manually parses the duplicated materials to find the exact material based on the server version.
-            // If ends with "S" -> Plural Form Material
-            return Enums.getIfPresent(XMaterial.class, name).transform(Optional::of).or(Optional.empty());
-        }
-        return Optional.ofNullable(xMat);
     }
 
     /**
@@ -1583,12 +1463,13 @@ public enum XMaterial {
      * @see #isDuplicated()
      * @since 2.0.0
      */
-    private static boolean isDuplicated(@Nonnull String name) {
+    public static boolean isDuplicated(@Nonnull String name) {
+        Validate.notEmpty(name, "Cannot check duplication for null or empty material name");
+        name = format(name);
+
         // Don't use matchXMaterial() since this method is being called from matchXMaterial() itself and will cause a StackOverflowError.
-        for (Map.Entry<XMaterial, XMaterial> duplicated : duplicated.entrySet()) {
+        for (Map.Entry<XMaterial, XMaterial> duplicated : DUPLICATED.entrySet())
-            XMaterial material = duplicated.getKey();
+            if (duplicated.getKey().name().equals(name) || duplicated.getKey().anyMatchLegacy(name)) return true;
-            if (material.name().equals(name) || material.anyMatchLegacy(name)) return true;
-        }
         return false;
     }
 
@@ -1612,6 +1493,60 @@ public enum XMaterial {
         return Optional.empty();
     }
 
+    /**
+     * A solution for <b>XMaterial Paradox</b>.
+     * Manually parses the duplicated materials to find the exact material based on the server version.
+     *
+     * @param name the name of the material.
+     * @return the duplicated XMaterial based on the version.
+     * @throws IllegalArgumentException may be thrown. If thrown, it's a bug.
+     * @since 2.0.0
+     */
+    @Nullable
+    private static XMaterial requestDuplicatedXMaterial(@Nonnull String name, byte data) {
+        XMaterial mat = requestOldXMaterial(name, data);
+        // If ends with "S" -> Plural Form Material
+        return mat.name().charAt(mat.name().length() - 1) == 'S' ? Enums.getIfPresent(XMaterial.class, name).orNull() : mat;
+    }
+
+    /**
+     * Always returns the value with the given duplicated material key name.
+     *
+     * @param name the name of the material.
+     * @return the new XMaterial of this duplicated material.
+     * @see #getXMaterialIfDuplicated(String)
+     * @since 2.0.0
+     */
+    @Nonnull
+    public static Optional<XMaterial> getNewXMaterialIfDuplicated(@Nonnull String name) {
+        Validate.notEmpty(name, "Cannot get new duplicated material for null or empty material name");
+        name = format(name);
+
+        for (Map.Entry<XMaterial, XMaterial> duplicated : DUPLICATED.entrySet())
+            if (duplicated.getKey().name().equals(name)) return Optional.of(duplicated.getKey());
+        return Optional.empty();
+    }
+
+    /**
+     * Checks if the item is duplicated for a different purpose in new versions from {@link #DUPLICATED}.
+     *
+     * @param name the name of the material.
+     * @return the other XMaterial (key or value) of the XMaterial (key or value).
+     * @see #matchXMaterial(String, byte)
+     * @since 2.0.0
+     */
+    @Nullable
+    public static XMaterial getXMaterialIfDuplicated(@Nonnull String name) {
+        Validate.notEmpty(name, "Cannot get duplicated material for null or empty material name");
+        name = format(name);
+
+        for (Map.Entry<XMaterial, XMaterial> duplicated : DUPLICATED.entrySet())
+            if (duplicated.getKey().name().equals(name)) return duplicated.getValue();
+            else if (duplicated.getValue().name().equals(name)) return duplicated.getKey();
+
+        return null;
+    }
+
     /**
      * Attempts to build the string like an enum name.
      * Removes all the spaces, numbers and extra non-English characters. Also removes some config/in-game based strings.
@@ -1629,7 +1564,7 @@ public enum XMaterial {
     /**
      * Checks if the specified version is the same version or higher than the current server version.
      *
-     * @param version the major version to be checked. "1." is ignored. E.g. 1.12 = 12 | 1.9 = 9
+     * @param version the major version to be checked. "1." is ignored -> 1.12 = 12 | 1.9 = 9
      * @return true of the version is equal or higher than the current version.
      * @since 2.0.0
      */
@@ -1728,14 +1663,14 @@ public enum XMaterial {
      * <br>
      * <b>{@code CONTAINS} Examples:</b>
      * <pre>
-     *     {@code "CONTAINS:CHEST" -> CHEST, ENDERCHEST, TRAPPED_CHEST -> true}
+     *     "CONTAINS:CHEST" -> CHEST, ENDERCHEST, TRAPPED_CHEST -> true
-     *     {@code "cOnTaINS:dYe" -> GREEN_DYE, YELLOW_DYE, BLUE_DYE, INK_SACK -> true}
+     *     "cOnTaINS:dYe" -> GREEN_DYE, YELLOW_DYE, BLUE_DYE, INK_SACK -> true
      * </pre>
      * <p>
      * <b>{@code REGEX} Examples</b>
      * <pre>
-     *     {@code "REGEX:^.+_.+_.+$" -> Every Material with 3 underlines or more: SHULKER_SPAWN_EGG, SILVERFISH_SPAWN_EGG, SKELETON_HORSE_SPAWN_EGG}
+     *     "REGEX:^.+_.+_.+$" -> Every Material with 3 underlines or more: SHULKER_SPAWN_EGG, SILVERFISH_SPAWN_EGG, SKELETON_HORSE_SPAWN_EGG
-     *     {@code "REGEX:^.{1,3}$" -> Material names that have 3 letters only: BED, MAP, AIR}
+     *     "REGEX:^.{1,3}$" -> Material names that have 3 letters only: BED, MAP, AIR
      * </pre>
      * <p>
      * The reason that there are tags for {@code CONTAINS} and {@code REGEX}
@@ -1868,7 +1803,8 @@ public enum XMaterial {
      */
     @SuppressWarnings("deprecation")
     public int getId() {
-        if (this.data != 0 || (this.legacy.length != 0 && Integer.parseInt(this.legacy[0].substring(2)) >= 13)) return -1;
+        if (this.data != 0 || (this.legacy.length != 0 && Integer.parseInt(this.legacy[0].substring(2)) >= 13))
+            return -1;
         Material material = this.parseMaterial();
         return material == null ? -1 : material.getId();
     }
@@ -1877,11 +1813,25 @@ public enum XMaterial {
      * Checks if the material has any duplicates.
      *
      * @return true if there is a duplicated name for this material, otherwise false.
+     * @see #getXMaterialIfDuplicated()
      * @see #isDuplicated(String)
      * @since 2.0.0
      */
     public boolean isDuplicated() {
-        return duplicated.containsKey(this);
+        return DUPLICATED.containsKey(this);
+    }
+
+    /**
+     * Checks if the item is duplicated for a different purpose in new versions.
+     *
+     * @return true if the item's name is duplicated, otherwise false.
+     * @see #isDuplicated()
+     * @see #getNewXMaterialIfDuplicated(String)
+     * @since 2.0.0
+     */
+    @Nullable
+    public XMaterial getXMaterialIfDuplicated() {
+        return DUPLICATED.get(this);
     }
 
     /**
@@ -1941,7 +1891,7 @@ public enum XMaterial {
      * Parses an item from this XMaterial.
      * Uses data values on older versions.
      *
-     * @param suggest if true {@link #parseMaterial(boolean)} true will be used.
+     * @param suggest if true {@link #parseMaterial(boolean true)} will be used.
      * @return an ItemStack with the same material (and data value if in older versions.)
      * @see #setType(ItemStack)
      * @since 2.0.0
@@ -1971,6 +1921,7 @@ public enum XMaterial {
      *
      * @param suggest use a suggested material (from older materials) if the material is added in a later version of Minecraft.
      * @return the material related to this XMaterial based on the server version.
+     * @see #matchXMaterial(String, byte)
      * @since 2.0.0
      */
     @SuppressWarnings("OptionalAssignedToNull")

src/main/java/com/massivecraft/factions/util/timer/GlobalTimer.java

@@ -1,5 +1,12 @@
 package com.massivecraft.factions.util.timer;
 
+import com.massivecraft.factions.util.Config;
+
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.Set;
+import java.util.UUID;
+
 /**
  * Factions - Developed by Driftay.
  * All rights reserved 2020.

src/main/java/com/massivecraft/factions/util/timer/Timer.java

@@ -8,8 +8,8 @@ import com.massivecraft.factions.util.Config;
  * Creation Date: 4/7/2020
  */
 public abstract class Timer {
-    public final long defaultCooldown;
     protected final String name;
+    public final long defaultCooldown;
 
 
     public Timer(String name, long defaultCooldown) {

src/main/java/com/massivecraft/factions/util/timer/TimerManager.java

@@ -16,24 +16,14 @@ import java.util.concurrent.TimeUnit;
  * Creation Date: 4/7/2020
  */
 public class TimerManager implements Listener, Runnable {
-    private static final long MINUTE = TimeUnit.MINUTES.toMillis(1L);
-    private static final long HOUR = TimeUnit.HOURS.toMillis(1L);
-    private static final long MULTI_HOUR = TimeUnit.HOURS.toMillis(10);
     private final Set<Timer> timers;
     private final FactionsPlugin plugin;
     private final List<TimerRunnable> timerRunnableList = new ArrayList<>();
-    public GraceTimer graceTimer;
     private Config config;
-
+    public GraceTimer graceTimer;
-    public TimerManager(FactionsPlugin plugin) {
+    private static final long MINUTE = TimeUnit.MINUTES.toMillis(1L);
-        this.timers = new HashSet<>();
+    private static final long HOUR = TimeUnit.HOURS.toMillis(1L);
-        this.plugin = plugin;
+    private static final long MULTI_HOUR = TimeUnit.HOURS.toMillis(10);
-        plugin.getServer().getPluginManager().registerEvents(this, plugin);
-        if (Conf.useGraceSystem) {
-            this.registerTimer(this.graceTimer = new GraceTimer());
-        }
-        plugin.getServer().getScheduler().runTaskTimer(plugin, this, 4, 4);
-    }
 
     public static String getRemaining(long millis, boolean milliseconds) {
         return getRemaining(millis, milliseconds, true);
@@ -41,11 +31,21 @@ public class TimerManager implements Listener, Runnable {
 
     public static String getRemaining(long duration, boolean milliseconds, boolean trail) {
         if ((milliseconds) && (duration < MINUTE)) {
-            return ((trail ? DateTimeFormats.REMAINING_SECONDS_TRAILING : DateTimeFormats.REMAINING_SECONDS).get()).format(duration * 0.001D) + 's';
+            return ( (trail ? DateTimeFormats.REMAINING_SECONDS_TRAILING : DateTimeFormats.REMAINING_SECONDS).get()).format(duration * 0.001D) + 's';
         }
         return DurationFormatUtils.formatDuration(duration, (duration >= HOUR ? (duration >= MULTI_HOUR ? "d" : "") + "d:" : "") + "HH:mm:ss");
     }
 
+    public TimerManager(FactionsPlugin plugin) {
+        this.timers = new HashSet<>();
+        this.plugin = plugin;
+        plugin.getServer().getPluginManager().registerEvents(this, plugin);
+        if(Conf.useGraceSystem) {
+            this.registerTimer(this.graceTimer = new GraceTimer());
+        }
+        plugin.getServer().getScheduler().runTaskTimer(plugin, this, 4, 4);
+    }
+
     public Collection<Timer> getTimers() {
         return this.timers;
     }

src/main/java/com/massivecraft/factions/util/timer/TimerRunnable.java

@@ -25,13 +25,6 @@ public class TimerRunnable {
     }
 
 
-    public TimerRunnable(UUID playerUUID, Timer timer, long duration) {
-        this.timer = timer;
-        setRemaining(duration);
-        FactionsPlugin plugin = FactionsPlugin.getInstance();
-        plugin.getTimerManager().getTimerRunnableList().add(this);
-    }
-
     public boolean isCancelled() {
         return cancelled;
     }
@@ -45,13 +38,15 @@ public class TimerRunnable {
         return getRemaining(false);
     }
 
+    public long getRemaining(long now) {
+        return getRemaining(false, now);
+    }
+
+
     public void setRemaining(long remaining) {
         setExpiryMillis(remaining);
     }
 
-    public long getRemaining(long now) {
-        return getRemaining(false, now);
-    }
 
     public long getRemaining(boolean ignorePaused) {
         if ((!ignorePaused) && (this.pauseMillis != 0L)) return this.pauseMillis;

src/main/java/com/massivecraft/factions/util/timer/type/GraceTimer.java

@@ -26,22 +26,20 @@ public class GraceTimer extends GlobalTimer implements Listener {
 
     @EventHandler
     public void onBreak(EntityExplodeEvent e) {
-        if (getRemaining() > 0)
+        if (getRemaining() > 0) {
             e.setCancelled(true);
+        }
     }
 
     @EventHandler
     public void onTNTPlace(BlockPlaceEvent event) {
         FPlayer fp = FPlayers.getInstance().getByPlayer(event.getPlayer());
-        if (getRemaining() > 0) {
+        if (getRemaining() > 0 && !fp.isAdminBypassing() && event.getBlock().getType().equals(Material.TNT)) {
-            if (!fp.isAdminBypassing()) {
+            event.setCancelled(true);
-                if (event.getBlock().getType().equals(Material.TNT)) {
-                    event.setCancelled(true);
-                }
-            }
         }
     }
 
+
     @Override
     public void load(Config config) {
         setPaused(config.getBoolean(this.name + ".paused"));

src/main/java/com/massivecraft/factions/zcore/MPlugin.java

@@ -3,10 +3,7 @@ package com.massivecraft.factions.zcore;
 import com.google.gson.Gson;
 import com.google.gson.GsonBuilder;
 import com.google.gson.reflect.TypeToken;
-import com.massivecraft.factions.Board;
+import com.massivecraft.factions.*;
-import com.massivecraft.factions.Conf;
-import com.massivecraft.factions.FPlayers;
-import com.massivecraft.factions.Factions;
 import com.massivecraft.factions.zcore.persist.SaveTask;
 import com.massivecraft.factions.zcore.util.PermUtil;
 import com.massivecraft.factions.zcore.util.Persist;

src/main/java/com/massivecraft/factions/zcore/file/CustomFile.java

@@ -56,10 +56,6 @@ public class CustomFile {
         }
     }
 
-    public boolean containsKey(String key) {
-        return getCachedObjects().containsKey(key) || getConfig().contains(key);
-    }
-
     public String fetchString(String key) {
         return (String) getObj(key, dataTypes.STRING);
     }

src/main/java/com/massivecraft/factions/zcore/fperms/gui/PermissableActionFrame.java

@@ -6,11 +6,13 @@ import com.github.stefvanschie.inventoryframework.pane.PaginatedPane;
 import com.massivecraft.factions.FPlayer;
 import com.massivecraft.factions.Faction;
 import com.massivecraft.factions.FactionsPlugin;
+import com.massivecraft.factions.cmd.audit.FLogType;
 import com.massivecraft.factions.util.XMaterial;
 import com.massivecraft.factions.zcore.fperms.Access;
 import com.massivecraft.factions.zcore.fperms.Permissable;
 import com.massivecraft.factions.zcore.fperms.PermissableAction;
 import com.massivecraft.factions.zcore.util.TL;
+import org.bukkit.ChatColor;
 import org.bukkit.configuration.ConfigurationSection;
 import org.bukkit.inventory.ItemStack;
 import org.bukkit.inventory.meta.ItemMeta;

src/main/java/com/massivecraft/factions/zcore/frame/fupgrades/FUpgradeFrame.java

@@ -16,6 +16,7 @@ import org.bukkit.inventory.meta.ItemMeta;
 
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Objects;
 
 /**
  * @author Saser
@@ -35,8 +36,7 @@ public class FUpgradeFrame {
         PaginatedPane pane = new PaginatedPane(0, 0, 9, this.gui.getRows());
         List<GuiItem> GUIItems = new ArrayList<>();
         ItemStack dummy = buildDummyItem();
-        for (int x = 0; x <= this.gui.getRows() * 9 - 1; ++x)
+        for (int x = 0; x <= this.gui.getRows() * 9 - 1; ++x) GUIItems.add(new GuiItem(dummy, e -> e.setCancelled(true)));
-            GUIItems.add(new GuiItem(dummy, e -> e.setCancelled(true)));
         for (UpgradeType value : UpgradeType.values()) {
             if (value.getSlot() != -1) {
                 GUIItems.set(value.getSlot(), new GuiItem(value.buildAsset(fplayer.getFaction()), e -> {
@@ -44,19 +44,19 @@ public class FUpgradeFrame {
                     FPlayer fme = FPlayers.getInstance().getByPlayer((Player) e.getWhoClicked());
                     if (fme.getFaction().getUpgrade(value) == value.getMaxLevel()) return;
                     int cost = FactionsPlugin.getInstance().getConfig().getInt("fupgrades.MainMenu." + value.toString() + ".Cost.level-" + (fme.getFaction().getUpgrade(value) + 1));
-                    if (fme.hasMoney(cost)) {
+                        if (fme.hasMoney(cost)) {
-                        fme.takeMoney(cost);
+                            fme.takeMoney(cost);
-                        if (value == UpgradeType.CHEST) updateChests(fme.getFaction());
+                            if (value == UpgradeType.CHEST) updateChests(fme.getFaction());
 
-                        if (value == UpgradeType.POWER) updateFactionPowerBoost(fme.getFaction());
+                            if (value == UpgradeType.POWER) updateFactionPowerBoost(fme.getFaction());
 
-                        if (value == UpgradeType.TNT) updateTNT(fme.getFaction());
+                            if (value == UpgradeType.TNT) updateTNT(fme.getFaction());
 
-                        if (value == UpgradeType.WARP) updateWarps(fme.getFaction());
+                            if (value == UpgradeType.WARP) updateWarps(fme.getFaction());
 
-                        fme.getFaction().setUpgrade(value, fme.getFaction().getUpgrade(value) + 1);
+                            fme.getFaction().setUpgrade(value, fme.getFaction().getUpgrade(value) + 1);
-                        buildGUI(fme);
+                            buildGUI(fme);
-                    }
+                        }
                 }));
             }
         }

src/main/java/com/massivecraft/factions/zcore/frame/fupgrades/UpgradesListener.java

@@ -28,7 +28,7 @@ public class UpgradesListener implements Listener {
         if (e.isCancelled()) return;
 
         if (!(e.getDamager() instanceof Player) || !(e.getEntity() instanceof Player)) return;
-        if (e.getEntity() == null) return;
+        if(e.getEntity() == null) return;
 
         FPlayer fme = FPlayers.getInstance().getByPlayer((Player) e.getEntity());
         FPlayer dame = FPlayers.getInstance().getByPlayer((Player) e.getDamager());
@@ -36,7 +36,7 @@ public class UpgradesListener implements Listener {
         if (fme == null || dame == null) return;
         FLocation floc = new FLocation(fme.getPlayer().getLocation());
 
-        if (floc == null) return;
+        if(floc == null) return;
 
         if (Board.getInstance().getFactionAt(floc) == fme.getFaction()) {
             if (dame.getFaction() == fme.getFaction()) return;

src/main/java/com/massivecraft/factions/zcore/persist/MemoryFPlayer.java

@@ -738,7 +738,7 @@ public abstract class MemoryFPlayer implements FPlayer {
     public void sendFactionHereMessage(Faction from) {
         Faction toShow = Board.getInstance().getFactionAt(getLastStoodAt());
 
-        if (Conf.worldsNoClaiming.contains(getLastStoodAt().getWorldName())) return;
+        if(Conf.worldsNoClaiming.contains(getLastStoodAt().getWorldName())) return;
 
         if (showInfoBoard(toShow)) {
             FScoreboard.get(this).setTemporarySidebar(new FInfoSidebar(toShow));
@@ -860,7 +860,7 @@ public abstract class MemoryFPlayer implements FPlayer {
         int factionBuffer = plugin.getConfig().getInt("hcf.buffer-zone", 0);
         int worldBuffer = plugin.getConfig().getInt("world-border.buffer", 0) - 1;
 
-        if (Conf.worldGuardChecking && Worldguard.getInstance().checkForRegionsInChunk(flocation)) {
+        if (Conf.worldGuardChecking &&  Worldguard.getInstance().checkForRegionsInChunk(flocation)) {
             // Checks for WorldGuard regions in the chunk attempting to be claimed
             error = plugin.txt.parse(TL.CLAIM_PROTECTED.toString());
         } else if (flocation.isOutsideWorldBorder(plugin.getConfig().getInt("world-border.buffer", 0) - 1)) {
@@ -873,7 +873,7 @@ public abstract class MemoryFPlayer implements FPlayer {
             return true;
         } else if (forFaction.isWarZone() && Permission.MANAGE_WAR_ZONE.has(getPlayer())) {
             return true;
-        } else if (currentFaction.getAccess(this, PermissableAction.TERRITORY) == Access.ALLOW && forFaction != currentFaction) {
+        } else if (currentFaction.getAccess(this, PermissableAction.TERRITORY) == Access.ALLOW && forFaction != currentFaction ) {
             return true;
         } else if (myFaction != forFaction) {
             error = plugin.txt.parse(TL.CLAIM_CANTCLAIM.toString(), forFaction.describeTo(this));
@@ -972,38 +972,36 @@ public abstract class MemoryFPlayer implements FPlayer {
     }
 
     public void setFFlying(boolean fly, boolean damage) {
-        if (FactionsPlugin.getInstance().getConfig().getBoolean("enable-faction-flight")) {
+        Player player = getPlayer();
-            Player player = getPlayer();
+        if (player == null) return;
-            if (player == null) return;
 
-            player.setAllowFlight(fly);
+        player.setAllowFlight(fly);
-            player.setFlying(fly);
+        player.setFlying(fly);
 
-            if (!damage) {
+        if (!damage) {
-                msg(TL.COMMAND_FLY_CHANGE, fly ? "enabled" : "disabled");
+            msg(TL.COMMAND_FLY_CHANGE, fly ? "enabled" : "disabled");
-                if (!fly) {
-                    sendMessage(TL.COMMAND_FLY_COOLDOWN.toString().replace("{amount}", FactionsPlugin.getInstance().getConfig().getInt("fly-falldamage-cooldown", 3) + ""));
-                }
-            } else {
-                msg(TL.COMMAND_FLY_DAMAGE);
-            }
-
-            // If leaving fly mode, don't let them take fall damage for x seconds.
             if (!fly) {
-                int cooldown = FactionsPlugin.getInstance().getConfig().getInt("fly-falldamage-cooldown", 3);
+                sendMessage(TL.COMMAND_FLY_COOLDOWN.toString().replace("{amount}", FactionsPlugin.getInstance().getConfig().getInt("fly-falldamage-cooldown", 3) + ""));
-                CmdFly.flyMap.remove(player.getName());
-
-                // If the value is 0 or lower, make them take fall damage.
-                // Otherwise, start a timer and have this cancel after a few seconds.
-                // Short task so we're just doing it in method. Not clean but eh.
-                if (cooldown > 0) {
-                    setTakeFallDamage(false);
-                    Bukkit.getScheduler().runTaskLater(FactionsPlugin.getInstance(), () -> setTakeFallDamage(true), 20L * cooldown);
-                }
             }
-
+        } else {
-            isFlying = fly;
+            msg(TL.COMMAND_FLY_DAMAGE);
         }
+
+        // If leaving fly mode, don't let them take fall damage for x seconds.
+        if (!fly) {
+            int cooldown = FactionsPlugin.getInstance().getConfig().getInt("fly-falldamage-cooldown", 3);
+            CmdFly.flyMap.remove(player.getName());
+
+            // If the value is 0 or lower, make them take fall damage.
+            // Otherwise, start a timer and have this cancel after a few seconds.
+            // Short task so we're just doing it in method. Not clean but eh.
+            if (cooldown > 0) {
+                setTakeFallDamage(false);
+                Bukkit.getScheduler().runTaskLater(FactionsPlugin.getInstance(), () -> setTakeFallDamage(true), 20L * cooldown);
+            }
+        }
+
+        isFlying = fly;
     }
 
     public boolean isInFactionsChest() {
@@ -1222,11 +1220,11 @@ public abstract class MemoryFPlayer implements FPlayer {
     }
 
 
-    public boolean hasFriendlyFire() {
+    public boolean hasFriendlyFire(){
         return friendlyFire;
     }
 
-    public void setFriendlyFire(boolean status) {
+    public void setFriendlyFire(boolean status){
         friendlyFire = status;
     }
 
@@ -1304,7 +1302,7 @@ public abstract class MemoryFPlayer implements FPlayer {
 
 
         // announce success
-        if (!FactionsPlugin.cachedRadiusClaim) {
+        if(!FactionsPlugin.cachedRadiusClaim) {
             Set<FPlayer> informTheseFPlayers = new HashSet<>();
             informTheseFPlayers.add(this);
             informTheseFPlayers.addAll(forFaction.getFPlayersWhereOnline(true));

src/main/java/com/massivecraft/factions/zcore/persist/MemoryFaction.java

@@ -1277,7 +1277,7 @@ public abstract class MemoryFaction implements Faction, EconomyParticipator {
             if (Conf.logFactionDisband)
                 FactionsPlugin.getInstance().log("The faction " + this.getTag() + " (" + this.getId() + ") has been disbanded since it has no members left" + (autoLeave ? " and by inactivity" : "") + ".");
 
-            if (FactionsPlugin.getInstance().getConfig().getBoolean("faction-disband-broadcast")) {
+            if(FactionsPlugin.getInstance().getConfig().getBoolean("faction-disband-broadcast")) {
                 for (FPlayer fplayer : FPlayers.getInstance().getOnlinePlayers())
                     fplayer.msg(TL.COMMAND_DISBAND_BROADCAST_GENERIC, this.getTag(fplayer));
             }

src/main/java/com/massivecraft/factions/zcore/persist/json/JSONFPlayers.java

@@ -73,22 +73,21 @@ public class JSONFPlayers extends MemoryFPlayers {
         if (!this.file.exists()) return new HashMap<>();
         String content = DiscUtil.readCatch(this.file);
         if (content == null) return null;
-        try {
+        Map<String, JSONFPlayer> data = this.gson.fromJson(content, new TypeToken<Map<String, JSONFPlayer>>() {
-            Map<String, JSONFPlayer> data = this.gson.fromJson(content, new TypeToken<Map<String, JSONFPlayer>>() {
+        }.getType());
-            }.getType());
+        Set<String> list = new HashSet<>();
-            Set<String> list = new HashSet<>();
+        Set<String> invalidList = new HashSet<>();
-            Set<String> invalidList = new HashSet<>();
+        for (Entry<String, JSONFPlayer> entry : data.entrySet()) {
-            for (Entry<String, JSONFPlayer> entry : data.entrySet()) {
+            String key = entry.getKey();
-                String key = entry.getKey();
+            entry.getValue().setId(key);
-                entry.getValue().setId(key);
+            if (doesKeyNeedMigration(key)) {
-                if (doesKeyNeedMigration(key)) {
+                if (!isKeyInvalid(key)) {
-                    if (!isKeyInvalid(key)) {
+                    list.add(key);
-                        list.add(key);
+                } else {
-                    } else {
+                    invalidList.add(key);
-                        invalidList.add(key);
-                    }
                 }
             }
+        }
 
         if (list.size() > 0) {
             // We've got some converting to do!
@@ -151,14 +150,6 @@ public class JSONFPlayers extends MemoryFPlayers {
             Bukkit.getLogger().log(Level.INFO, "Done converting players.json to UUID.");
         }
         return data;
-        } catch (NullPointerException exception) {
-            exception.printStackTrace();
-            if (this.file.length() < 200) {
-                return new HashMap<>();
-            } else {
-                throw exception;
-            }
-        }
     }
 
     private boolean doesKeyNeedMigration(String key) {

src/main/java/com/massivecraft/factions/zcore/util/TL.java

@@ -824,7 +824,6 @@ public enum TL {
     COMMAND_STRIKESINFO_DESCRIPTION("Get a faction's strikes"),
 
     SHOP_NOT_ENOUGH_POINTS("&c&l[!] &7Your faction does not have enough points to purchase this!"),
-    SHOP_ERROR_DURING_PURCHASE("&c&l[!] &7There was an error while trying to give items please check your inventory! Purchase was not completed!"),
     SHOP_BOUGHT_BROADCAST_FACTION("\n&c&l[!] &e&lFactionShop » &b{player} &7bought &b{item}&7 for &b{cost} &7points!\n"),
 
 
@@ -1251,10 +1250,6 @@ public enum TL {
     PLAYER_PVP_NEUTRALFAIL("You can't hurt %s in their own territory unless you declare them as an enemy."),
     PLAYER_PVP_TRIED("%s tried to hurt you."),
 
-    SHIELD_CURRENTLY_ENABLE("&a&lCurrently Protected"),
-    SHIELD_NOT_SET("&c&lNot Set"),
-    SHIELD_CURRENTLY_NOT_ENABLED("&c&lCurrently Unprotected"),
-
     /**
      * Strings lying around in other bits of the plugins
      */

src/main/java/com/massivecraft/factions/zcore/util/TagReplacer.java

@@ -78,7 +78,6 @@ public enum TagReplacer {
     FACTION_BANCOUNT(TagType.FACTION, "{faction-bancount}"),
     FACTION_STRIKES(TagType.FACTION, "{strikes}"),
     FACTION_POINTS(TagType.FACTION, "{faction-points}"),
-    SHIELD_STATUS(TagType.FACTION, "{shield-status}"),
 
 
     /**
@@ -240,10 +239,6 @@ public enum TagReplacer {
                 return fac.hasHome() ? String.valueOf(fac.getHome().getBlockY()) : minimal ? null : "{ig}";
             case HOME_Z:
                 return fac.hasHome() ? String.valueOf(fac.getHome().getBlockZ()) : minimal ? null : "{ig}";
-            //case SHIELD_STATUS:
-                    //if(fac.isProtected() && fac.getShieldFrame() != null) return String.valueOf(TL.SHIELD_CURRENTLY_ENABLE);
-                    //if(fac.getShieldFrame() == null) return String.valueOf(TL.SHIELD_NOT_SET);
-                    //return TL.SHIELD_CURRENTLY_NOT_ENABLED.toString();
             case LAND_VALUE:
                 return Econ.shouldBeUsed() ? Econ.moneyString(Econ.calculateTotalLandValue(fac.getLandRounded())) : minimal ? null : TL.ECON_OFF.format("value");
             case LAND_REFUND: