some cleanup

This commit is contained in:
Thomas Borgen
2020-08-09 23:26:34 +02:00
parent d46fd7631c
commit c02e6c08cc

View File

@@ -3,7 +3,6 @@ import json
import os import os
import sys import sys
parser = argparse.ArgumentParser( parser = argparse.ArgumentParser(
description='Updates output settings file based on a default file', description='Updates output settings file based on a default file',
) )
@@ -39,18 +38,33 @@ if os.path.isfile(transmission_settings):
else: else:
configuration_baseline = default_settings configuration_baseline = default_settings
print('Using config baseline ' + configuration_baseline) print('Using config baseline', configuration_baseline)
# Read config base # Read config base
with open(configuration_baseline, 'r') as f: with open(configuration_baseline, 'r') as input_file:
settings_dict = json.load(f) settings_dict = json.load(input_file)
def setting_as_env(setting: str) -> str:
"""Get a transmission settings environment variable name."""
return 'TRANSMISSION_{setting}'.format(
setting=setting.upper().replace('-', '_'),
)
# For each setting, check if an environment variable is set to override it # For each setting, check if an environment variable is set to override it
for setting in settings_dict: for setting in settings_dict:
setting_env_name = 'TRANSMISSION_' + setting.upper().replace('-', '_') setting_env_name = setting_as_env(setting)
if setting_env_name in os.environ: if setting_env_name in os.environ:
print('Overriding ' + setting + ' because ' + setting_env_name + ' is set to ' + os.environ.get(setting_env_name)) env_value = os.environ.get(setting_env_name)
settings_dict[setting] = os.environ.get(setting_env_name) print(
'Overriding {setting} because {env_name} is set to {value}'.format(
setting=setting,
env_name=setting_env_name,
value=env_value,
),
)
settings_dict[setting] = env_value
# Dump resulting settings to file # Dump resulting settings to file
with open(transmission_settings, 'w') as fp: with open(transmission_settings, 'w') as fp: