From 9087bf746556cd33eeae69c384f709fc82532e05 Mon Sep 17 00:00:00 2001 From: evsasha Date: Fri, 23 Feb 2018 10:37:47 -0500 Subject: [PATCH 1/3] Fix settings.json file attributes on Synology NAS. By default in Synology NAS the user Root creates files with the permissions "---------" (0). Other users can't access to file after chown. Fix #423 --- transmission/start.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/transmission/start.sh b/transmission/start.sh index f150d84dc..87c12cdf5 100755 --- a/transmission/start.sh +++ b/transmission/start.sh @@ -39,6 +39,14 @@ echo "Generating transmission settings.json from env variables" mkdir -p ${TRANSMISSION_HOME} dockerize -template /etc/transmission/settings.tmpl:${TRANSMISSION_HOME}/settings.json +echo "Check transmission settings.json file attributes" +SETTINGS_PATH=${TRANSMISSION_HOME}/settings.json +SETTINGS_ATTRIBUTES=$(stat -c %a ${SETTINGS_PATH}) +if [ ${SETTINGS_ATTRIBUTES} = 0 ]; then + # Ensure settings.json have non zero attributes (actual for Synology NAS) + chmod 640 ${SETTINGS_PATH} && echo "INFO: Attributes of setting.json changed to 640" +fi + echo "sed'ing True to true" sed -i 's/True/true/g' ${TRANSMISSION_HOME}/settings.json From 040c09299df6f1432eb500b584ef296d0dd5874a Mon Sep 17 00:00:00 2001 From: evsasha Date: Sat, 24 Feb 2018 22:14:33 +0300 Subject: [PATCH 2/3] Update start.sh Move file permission settings to userSetup.sh --- transmission/start.sh | 8 -------- 1 file changed, 8 deletions(-) diff --git a/transmission/start.sh b/transmission/start.sh index 87c12cdf5..f150d84dc 100755 --- a/transmission/start.sh +++ b/transmission/start.sh @@ -39,14 +39,6 @@ echo "Generating transmission settings.json from env variables" mkdir -p ${TRANSMISSION_HOME} dockerize -template /etc/transmission/settings.tmpl:${TRANSMISSION_HOME}/settings.json -echo "Check transmission settings.json file attributes" -SETTINGS_PATH=${TRANSMISSION_HOME}/settings.json -SETTINGS_ATTRIBUTES=$(stat -c %a ${SETTINGS_PATH}) -if [ ${SETTINGS_ATTRIBUTES} = 0 ]; then - # Ensure settings.json have non zero attributes (actual for Synology NAS) - chmod 640 ${SETTINGS_PATH} && echo "INFO: Attributes of setting.json changed to 640" -fi - echo "sed'ing True to true" sed -i 's/True/true/g' ${TRANSMISSION_HOME}/settings.json From a152a575eb38db352166f55c554b993b2cc32d54 Mon Sep 17 00:00:00 2001 From: evsasha Date: Sat, 24 Feb 2018 22:15:30 +0300 Subject: [PATCH 3/3] Update userSetup.sh Move file permission settings to userSetup.sh --- transmission/userSetup.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/transmission/userSetup.sh b/transmission/userSetup.sh index e0cc4c0b2..c3c5402d8 100644 --- a/transmission/userSetup.sh +++ b/transmission/userSetup.sh @@ -16,6 +16,14 @@ if [ -n "$PUID" ] && [ ! "$(id -u root)" -eq "$PUID" ]; then ${TRANSMISSION_DOWNLOAD_DIR} \ ${TRANSMISSION_INCOMPLETE_DIR} \ ${TRANSMISSION_WATCH_DIR} + + echo "Setting permission for files (644) and directories (755)" + chmod -R go=rX,u=rwX \ + /config \ + ${TRANSMISSION_HOME} \ + ${TRANSMISSION_DOWNLOAD_DIR} \ + ${TRANSMISSION_INCOMPLETE_DIR} \ + ${TRANSMISSION_WATCH_DIR} fi echo "