diff --git a/src/main/java/com/massivecraft/factions/Conf.java b/src/main/java/com/massivecraft/factions/Conf.java index 9f84fe17..c1055a93 100644 --- a/src/main/java/com/massivecraft/factions/Conf.java +++ b/src/main/java/com/massivecraft/factions/Conf.java @@ -98,6 +98,7 @@ public class Conf { public static double autoLeaveRoutineRunsEveryXMinutes = 5.0; public static int autoLeaveRoutineMaxMillisecondsPerTick = 5; // 1 server tick is roughly 50ms, so default max 10% of a tick public static boolean removePlayerDataWhenBanned = true; + public static String removePlayerDataWhenBannedReason = "Banned by admin."; public static boolean autoLeaveDeleteFPlayerData = true; // Let them just remove player from Faction. public static boolean worldGuardChecking = false; public static boolean worldGuardBuildPriority = false; diff --git a/src/main/java/com/massivecraft/factions/listeners/FactionsBlockListener.java b/src/main/java/com/massivecraft/factions/listeners/FactionsBlockListener.java index e008f1e7..54dd479d 100644 --- a/src/main/java/com/massivecraft/factions/listeners/FactionsBlockListener.java +++ b/src/main/java/com/massivecraft/factions/listeners/FactionsBlockListener.java @@ -191,7 +191,7 @@ public class FactionsBlockListener implements Listener { event.setCancelled(true); return; } - + if (to.isNormal()) { if (from.isNormal() && from.getRelationTo(to).isAlly()) { return; diff --git a/src/main/java/com/massivecraft/factions/listeners/FactionsPlayerListener.java b/src/main/java/com/massivecraft/factions/listeners/FactionsPlayerListener.java index e4f497ca..97f6f8aa 100644 --- a/src/main/java/com/massivecraft/factions/listeners/FactionsPlayerListener.java +++ b/src/main/java/com/massivecraft/factions/listeners/FactionsPlayerListener.java @@ -47,9 +47,7 @@ import org.bukkit.event.inventory.InventoryClickEvent; import org.bukkit.event.inventory.InventoryCloseEvent; import org.bukkit.event.inventory.InventoryDragEvent; import org.bukkit.event.player.*; -import org.bukkit.inventory.ItemStack; import org.bukkit.scheduler.BukkitTask; -import org.bukkit.util.NumberConversions; import java.util.*; import java.util.logging.Level; @@ -455,7 +453,6 @@ public class FactionsPlayerListener implements Listener { case CHIPPED_ANVIL: case DAMAGED_ANVIL: case BREWING_STAND: - return PermissableAction.CONTAINER; default: return null; @@ -843,15 +840,12 @@ public class FactionsPlayerListener implements Listener { @EventHandler public void onInventorySee(InventoryClickEvent e) { - if (e.getCurrentItem() == null) - return; - - if (!e.getView().getTitle().endsWith("'s Inventory")) - return; - + if (e.getCurrentItem() == null) return; + if (!e.getView().getTitle().endsWith("'s Inventory")) return; e.setCancelled(true); } + @EventHandler public void onPlayerBoneMeal(PlayerInteractEvent event) { Block block = event.getClickedBlock(); @@ -971,7 +965,7 @@ public class FactionsPlayerListener implements Listener { if (badGuy == null) return; // if player was banned (not just kicked), get rid of their stored info - if (Conf.removePlayerDataWhenBanned && event.getReason().equals("Banned by admin.")) { + if (Conf.removePlayerDataWhenBanned && event.getReason().equals(Conf.removePlayerDataWhenBannedReason)) { if (badGuy.getRole() == Role.LEADER) badGuy.getFaction().promoteNewLeader(); diff --git a/src/main/java/com/massivecraft/factions/zcore/frame/fwarps/FactionWarpsFrame.java b/src/main/java/com/massivecraft/factions/zcore/frame/fwarps/FactionWarpsFrame.java index 31be3e85..2ef816a6 100644 --- a/src/main/java/com/massivecraft/factions/zcore/frame/fwarps/FactionWarpsFrame.java +++ b/src/main/java/com/massivecraft/factions/zcore/frame/fwarps/FactionWarpsFrame.java @@ -40,7 +40,8 @@ public class FactionWarpsFrame { int count = 0; for (int x = 0; x <= gui.getRows() * 9 - 1; ++x) GUIItems.add(new GuiItem(buildDummyItem(), e -> e.setCancelled(true))); - slots.forEach(slot -> GUIItems.set(slot, new GuiItem(XMaterial.AIR.parseItem()))); + //We comment this out for now so it does not interfere with item placement when no warps are set + //slots.forEach(slot -> GUIItems.set(slot, new GuiItem(XMaterial.AIR.parseItem()))); for (final Map.Entry warp : fplayer.getFaction().getWarps().entrySet()) { if (slots.size() < fplayer.getFaction().getWarps().entrySet().size()) { slots.add(slots.get(slots.size() - 1) + 1);