From 5799a0480bea2785d0238c8e4d7dab3bcd1b7e0e Mon Sep 17 00:00:00 2001 From: eueln Date: Tue, 6 Jan 2015 11:42:56 -0600 Subject: [PATCH] Fix String-related bugs The result of a call to String#toLowerCase() was ignored, and two Strings were being compared with == --- src/main/java/com/massivecraft/factions/cmd/CmdChat.java | 2 +- src/main/java/com/massivecraft/factions/cmd/CmdTag.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/massivecraft/factions/cmd/CmdChat.java b/src/main/java/com/massivecraft/factions/cmd/CmdChat.java index 12504212..e54ab6ef 100644 --- a/src/main/java/com/massivecraft/factions/cmd/CmdChat.java +++ b/src/main/java/com/massivecraft/factions/cmd/CmdChat.java @@ -35,7 +35,7 @@ public class CmdChat extends FCommand { ChatMode modeTarget = fme.getChatMode().getNext(); if (modeString != null) { - modeString.toLowerCase(); + modeString = modeString.toLowerCase(); if (modeString.startsWith("p")) { modeTarget = ChatMode.PUBLIC; } else if (modeString.startsWith("a")) { diff --git a/src/main/java/com/massivecraft/factions/cmd/CmdTag.java b/src/main/java/com/massivecraft/factions/cmd/CmdTag.java index 631789c3..414a1671 100644 --- a/src/main/java/com/massivecraft/factions/cmd/CmdTag.java +++ b/src/main/java/com/massivecraft/factions/cmd/CmdTag.java @@ -65,7 +65,7 @@ public class CmdTag extends FCommand { // Inform for (FPlayer fplayer : FPlayers.getInstance().getOnlinePlayers()) { - if (fplayer.getFactionId() == myFaction.getId()) { + if (fplayer.getFactionId().equals(myFaction.getId())) { fplayer.msg(TL.COMMAND_TAG_FACTION, fme.describeTo(myFaction, true), myFaction.getTag(myFaction)); continue; }