From 3f949e18cc5052c36b36fb5455a812be3e7373da Mon Sep 17 00:00:00 2001
From: t00thpick1 <t00thpick1dirko@gmail.com>
Date: Tue, 30 Dec 2014 00:31:36 -0500
Subject: [PATCH] Lets not do hundreds of object clones when they are nearly
 never needed.

---
 .../massivecraft/factions/cmd/CmdShow.java    | 46 ++++++-------------
 1 file changed, 13 insertions(+), 33 deletions(-)

diff --git a/src/main/java/com/massivecraft/factions/cmd/CmdShow.java b/src/main/java/com/massivecraft/factions/cmd/CmdShow.java
index d24bcbdb..100f72d5 100644
--- a/src/main/java/com/massivecraft/factions/cmd/CmdShow.java
+++ b/src/main/java/com/massivecraft/factions/cmd/CmdShow.java
@@ -16,7 +16,7 @@ import java.util.ArrayList;
 import java.util.List;
 
 public class CmdShow extends FCommand {
-
+    private static final int ARBITRARY_LIMIT = 25000;
     public CmdShow() {
         this.aliases.add("show");
         this.aliases.add("who");
@@ -70,11 +70,6 @@ public class CmdShow extends FCommand {
             Relation rel = otherFaction.getRelationTo(faction);
             String s = otherFaction.getTag(fme);
             if (rel.isAlly()) {
-                FancyMessage beforeAdd = null;
-                try {
-                    beforeAdd = currentAllies.clone();
-                } catch (CloneNotSupportedException ignored) {}
-
                 if (firstAlly) {
                     currentAllies.then(s).tooltip(getToolTips(otherFaction));
                 } else {
@@ -82,16 +77,11 @@ public class CmdShow extends FCommand {
                 }
                 firstAlly = false;
 
-                if (currentAllies.toJSONString().length() > Short.MAX_VALUE) {
-                    allies.add(beforeAdd);
-                    currentAllies = new FancyMessage(s).tooltip(getToolTips(otherFaction));
+                if (currentAllies.toJSONString().length() > ARBITRARY_LIMIT) {
+                    allies.add(currentAllies);
+                    currentAllies = new FancyMessage();
                 }
             } else if (rel.isEnemy()) {
-                FancyMessage beforeAdd = null;
-                try {
-                    beforeAdd = currentEnemies.clone();
-                } catch (CloneNotSupportedException ignored) {}
-
                 if (firstEnemy) {
                     currentEnemies.then(s).tooltip(getToolTips(otherFaction));
                 } else {
@@ -99,9 +89,9 @@ public class CmdShow extends FCommand {
                 }
                 firstEnemy = false;
 
-                if (currentEnemies.toJSONString().length() > Short.MAX_VALUE) {
-                    enemies.add(beforeAdd);
-                    currentEnemies = new FancyMessage(s).tooltip(getToolTips(otherFaction));
+                if (currentEnemies.toJSONString().length() > ARBITRARY_LIMIT) {
+                    enemies.add(currentEnemies);
+                    currentEnemies = new FancyMessage();
                 }
             }
         }
@@ -117,11 +107,6 @@ public class CmdShow extends FCommand {
         for (FPlayer p : MiscUtil.rankOrder(faction.getFPlayers())) {
             String name = p.getNameAndTitle();
             if (p.isOnline()) {
-                FancyMessage beforeAdd = null;
-                try {
-                    beforeAdd = currentOnline.clone();
-                } catch (CloneNotSupportedException ignored) {}
-
                 if (firstOnline) {
                     currentOnline.then(name).tooltip(getToolTips(p));
                 } else {
@@ -129,16 +114,11 @@ public class CmdShow extends FCommand {
                 }
                 firstOnline = false;
 
-                if (currentOnline.toJSONString().length() > Short.MAX_VALUE) {
-                    online.add(beforeAdd);
-                    currentOnline = new FancyMessage(name).tooltip(getToolTips(p));
+                if (currentOnline.toJSONString().length() > ARBITRARY_LIMIT) {
+                    online.add(currentOnline);
+                    currentOnline = new FancyMessage();
                 }
             } else {
-                FancyMessage beforeAdd = null;
-                try {
-                    beforeAdd = currentOffline.clone();
-                } catch (CloneNotSupportedException ignored) {}
-
                 if (firstOffline) {
                     currentOffline.then(name).tooltip(getToolTips(p));
                 } else {
@@ -146,9 +126,9 @@ public class CmdShow extends FCommand {
                 }
                 firstOffline = false;
 
-                if (currentOffline.toJSONString().length() > Short.MAX_VALUE) {
-                    offline.add(beforeAdd);
-                    currentOffline = new FancyMessage(name).tooltip(getToolTips(p));
+                if (currentOffline.toJSONString().length() > ARBITRARY_LIMIT) {
+                    offline.add(currentOffline);
+                    currentOffline = new FancyMessage();
                 }
             }
         }