Add expansion is external + persistent = true check to unregisterAll method loop.

This commit is contained in:
Andre601 2024-07-07 21:37:09 +02:00
parent 19fca16653
commit 9689eec3ab
No known key found for this signature in database
GPG Key ID: 90E82BD59347A86C

View File

@ -411,6 +411,14 @@ public final class LocalExpansionManager implements Listener {
private void unregisterAll() { private void unregisterAll() {
for (final PlaceholderExpansion expansion : Sets.newHashSet(expansions.values())) { for (final PlaceholderExpansion expansion : Sets.newHashSet(expansions.values())) {
if (expansion.persist() || expansion.getExpansionType() == Type.INTERNAL) { if (expansion.persist() || expansion.getExpansionType() == Type.INTERNAL) {
// Print warning if an external expansion is set to be persistent.
if (expansion.getExpansionType() == Type.EXTERNAL && expansion.persist()) {
Msg.warn("Nag author(s) %s about their expansion %s being marked as \"external\" "
+ "but having persist() set to true!", expansion.getAuthor(), expansion.getIdentifier());
Msg.warn("External Expansions should not be set to be persistent! PlaceholderAPI "
+ "will respect this setting and skip the unregister of this Expansion...");
}
continue; continue;
} }