Changed command system (#304)

* Save Cacheable expansions data on shutdown

* Prepare for 1.16

* 1.16.1 is out apparently

* Further fixes, still not done

* Inline JSONMessages & fix for 1.16

* Done :O

* Done for real now, (hopefully)

* Changed to static instead of DI for plugin instance

* Cleanup

* Modified tab completions. Removed extra command.

* Apparently this is needed

* Started cleaning stuff up

basically just pushing so I can continue on laptop

* did more cleaning, probs like half way done

* more cleaning. reverted back to a min arg system somewhat similar to what frosty had, but less boilerplate.

* Started debugging and fixing runtime/compile errors

* Fixed bugs, still needs thorough testing

* Re-enable metrics

* relocated stuff again

* - Remove json message relocation
- uncomment other relocations
- reformat pom
- remove useless scope declaration
- Fix metrics constructor
- Switch commands to use inline json message

Co-authored-by: iGabyTM <contactgabytm@gmail.com>
Co-authored-by: darbyjack <admin@glaremasters.me>
Co-authored-by: PiggyPiglet <noreply@piggypiglet.me>

src/main/java/me/clip/placeholderapi/PlaceholderHook.java

@@ -25,30 +25,30 @@ import org.bukkit.entity.Player;
 
 public abstract class PlaceholderHook {
 
-  /**
-   * called when a placeholder value is requested from this hook
-   *
-   * @param p {@link OfflinePlayer} to request the placeholder value for, null if not needed for a
-   * player
-   * @param params String passed to the hook to determine what value to return
-   * @return value for the requested player and params
-   */
-  public String onRequest(OfflinePlayer p, String params) {
-    if (p != null && p.isOnline()) {
-      return onPlaceholderRequest((Player) p, params);
+    /**
+     * called when a placeholder value is requested from this hook
+     *
+     * @param player {@link OfflinePlayer} to request the placeholder value for, null if not needed for a
+     *               player
+     * @param params String passed to the hook to determine what value to return
+     * @return value for the requested player and params
+     */
+    public String onRequest(OfflinePlayer player, String params) {
+        if (player != null && player.isOnline()) {
+            return onPlaceholderRequest((Player) player, params);
+        }
+
+        return onPlaceholderRequest(null, params);
     }
 
-    return onPlaceholderRequest(null, params);
-  }
-
-  /**
-   * called when a placeholder is requested from this hook
-   *
-   * @param p {@link Player} to request the placeholder value for, null if not needed for a player
-   * @param params String passed to the hook to determine what value to return
-   * @return value for the requested player and params
-   */
-  public String onPlaceholderRequest(Player p, String params) {
-    return null;
-  }
+    /**
+     * called when a placeholder is requested from this hook
+     *
+     * @param player {@link Player} to request the placeholder value for, null if not needed for a player
+     * @param params String passed to the hook to determine what value to return
+     * @return value for the requested player and params
+     */
+    public String onPlaceholderRequest(Player player, String params) {
+        return null;
+    }
 }