mirror of
				https://github.com/PlaceholderAPI/PlaceholderAPI
				synced 2025-10-31 18:22:27 +01:00 
			
		
		
		
	updated placeholder hook to define immutability and null contracts, deprecated online player function
This commit is contained in:
		| @@ -22,8 +22,11 @@ package me.clip.placeholderapi; | |||||||
|  |  | ||||||
| import org.bukkit.OfflinePlayer; | import org.bukkit.OfflinePlayer; | ||||||
| import org.bukkit.entity.Player; | import org.bukkit.entity.Player; | ||||||
|  | import org.jetbrains.annotations.NotNull; | ||||||
|  | import org.jetbrains.annotations.Nullable; | ||||||
|  |  | ||||||
| public abstract class PlaceholderHook { | public abstract class PlaceholderHook | ||||||
|  | { | ||||||
|  |  | ||||||
| 	/** | 	/** | ||||||
| 	 * called when a placeholder value is requested from this hook | 	 * called when a placeholder value is requested from this hook | ||||||
| @@ -33,8 +36,11 @@ public abstract class PlaceholderHook { | |||||||
| 	 * @param params String passed to the hook to determine what value to return | 	 * @param params String passed to the hook to determine what value to return | ||||||
| 	 * @return value for the requested player and params | 	 * @return value for the requested player and params | ||||||
| 	 */ | 	 */ | ||||||
|     public String onRequest(OfflinePlayer player, String params) { | 	@Nullable | ||||||
|         if (player != null && player.isOnline()) { | 	public String onRequest(@Nullable final OfflinePlayer player, @NotNull final String params) | ||||||
|  | 	{ | ||||||
|  | 		if (player != null && player.isOnline()) | ||||||
|  | 		{ | ||||||
| 			return onPlaceholderRequest((Player) player, params); | 			return onPlaceholderRequest((Player) player, params); | ||||||
| 		} | 		} | ||||||
|  |  | ||||||
| @@ -48,7 +54,11 @@ public abstract class PlaceholderHook { | |||||||
| 	 * @param params String passed to the hook to determine what value to return | 	 * @param params String passed to the hook to determine what value to return | ||||||
| 	 * @return value for the requested player and params | 	 * @return value for the requested player and params | ||||||
| 	 */ | 	 */ | ||||||
|     public String onPlaceholderRequest(Player player, String params) { | 	@Nullable | ||||||
|  | 	@Deprecated | ||||||
|  | 	public String onPlaceholderRequest(@Nullable final Player player, @NotNull final String params) | ||||||
|  | 	{ | ||||||
| 		return null; | 		return null; | ||||||
| 	} | 	} | ||||||
|  |  | ||||||
| } | } | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user