From be956f52b0d55a80a21e454531fb5daabfffb497 Mon Sep 17 00:00:00 2001 From: mfnalex Date: Tue, 29 Aug 2023 00:55:28 +0200 Subject: [PATCH 1/3] added missing @NotNull to return value and List parameter of setBracketPlaceholders(Player, List) --- src/main/java/me/clip/placeholderapi/PlaceholderAPI.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/me/clip/placeholderapi/PlaceholderAPI.java b/src/main/java/me/clip/placeholderapi/PlaceholderAPI.java index a5228db..d26ee96 100644 --- a/src/main/java/me/clip/placeholderapi/PlaceholderAPI.java +++ b/src/main/java/me/clip/placeholderapi/PlaceholderAPI.java @@ -162,7 +162,8 @@ public final class PlaceholderAPI { * @param text List of Strings to set the placeholder values in * @return String containing all translated placeholders */ - public static List setBracketPlaceholders(Player player, List text) { + @NotNull + public static List setBracketPlaceholders(Player player, @NotNull List text) { return setBracketPlaceholders((OfflinePlayer) player, text); } From 152105017dcec7921a6a5cb7374a676493fb40e9 Mon Sep 17 00:00:00 2001 From: mfnalex Date: Tue, 29 Aug 2023 00:56:12 +0200 Subject: [PATCH 2/3] added missing @NotNull to return value and String parameter of setBracketPlaceholders(Player, String) --- src/main/java/me/clip/placeholderapi/PlaceholderAPI.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/me/clip/placeholderapi/PlaceholderAPI.java b/src/main/java/me/clip/placeholderapi/PlaceholderAPI.java index d26ee96..632bd62 100644 --- a/src/main/java/me/clip/placeholderapi/PlaceholderAPI.java +++ b/src/main/java/me/clip/placeholderapi/PlaceholderAPI.java @@ -150,7 +150,8 @@ public final class PlaceholderAPI { * @param text Text to set the placeholder values in * @return String containing all translated placeholders */ - public static String setBracketPlaceholders(Player player, String text) { + @NotNull + public static String setBracketPlaceholders(Player player, @NotNull String text) { return setBracketPlaceholders((OfflinePlayer) player, text); } From 32f3d14682f4d85ebce4c361515bd4f4ee84261a Mon Sep 17 00:00:00 2001 From: mfnalex Date: Tue, 29 Aug 2023 00:57:42 +0200 Subject: [PATCH 3/3] added missing @NotNull to the returned List's type parameter and the parameter List's type parameter (is that proper English?) --- src/main/java/me/clip/placeholderapi/PlaceholderAPI.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/me/clip/placeholderapi/PlaceholderAPI.java b/src/main/java/me/clip/placeholderapi/PlaceholderAPI.java index 632bd62..366ef63 100644 --- a/src/main/java/me/clip/placeholderapi/PlaceholderAPI.java +++ b/src/main/java/me/clip/placeholderapi/PlaceholderAPI.java @@ -136,8 +136,8 @@ public final class PlaceholderAPI { * @return String containing all translated placeholders */ @NotNull - public static List setBracketPlaceholders(final OfflinePlayer player, - @NotNull final List text) { + public static List<@NotNull String> setBracketPlaceholders(final OfflinePlayer player, + @NotNull final List<@NotNull String> text) { return text.stream().map(line -> setBracketPlaceholders(player, line)) .collect(Collectors.toList()); }